All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Paul Burton <paul.burton@mips.com>
Cc: Elvira Khabirova <lineprinter@altlinux.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <jhogan@kernel.org>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mips: fix mips_get_syscall_arg o32 check
Date: Wed, 21 Nov 2018 22:14:39 +0300	[thread overview]
Message-ID: <20181121191438.GB10301@altlinux.org> (raw)
In-Reply-To: <20181121190009.GA10301@altlinux.org>

When checking for TIF_32BIT_REGS flag, mips_get_syscall_arg() should
use the task specified as its argument instead of the current task.

This potentially affects all syscall_get_arguments() users
who specify tasks different from the current.

Fixes: c0ff3c53d4f99 ("MIPS: Enable HAVE_ARCH_TRACEHOOK.")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
 arch/mips/include/asm/syscall.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
index 0170602a1e4e..6cf8ffb5367e 100644
--- a/arch/mips/include/asm/syscall.h
+++ b/arch/mips/include/asm/syscall.h
@@ -73,7 +73,7 @@ static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
 #ifdef CONFIG_64BIT
 	case 4: case 5: case 6: case 7:
 #ifdef CONFIG_MIPS32_O32
-		if (test_thread_flag(TIF_32BIT_REGS))
+		if (test_tsk_thread_flag(task, TIF_32BIT_REGS))
 			return get_user(*arg, (int *)usp + n);
 		else
 #endif
-- 
ldv

  reply	other threads:[~2018-11-21 19:16 UTC|newest]

Thread overview: 214+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07  3:27 [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request Elvira Khabirova
2018-11-07 11:21 ` Oleg Nesterov
2018-11-07 14:06   ` Andy Lutomirski
2018-11-07 16:44     ` Oleg Nesterov
2018-11-07 20:02       ` Elvira Khabirova
2018-11-08  9:16         ` Oleg Nesterov
2018-11-07 20:20       ` Andy Lutomirski
2018-11-08 14:33         ` Oleg Nesterov
2018-11-07 16:12   ` Dmitry V. Levin
2018-11-07 15:50 ` Dmitry V. Levin
2018-11-07 20:44 ` Andy Lutomirski
2018-11-09  3:13   ` [PATCH 00/13] Prepare for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2018-11-09  3:13     ` Dmitry V. Levin
2018-11-09  3:13     ` Dmitry V. Levin
2018-11-09  3:13     ` Dmitry V. Levin
2018-11-09  3:13     ` Dmitry V. Levin
2018-11-09  3:15     ` [PATCH 01/13] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-09  3:15     ` [PATCH 02/13] elf-em.h: add EM_ARC Dmitry V. Levin
2018-11-09  3:15       ` Dmitry V. Levin
2018-11-09 14:20       ` Alexey Brodkin
2018-11-09 14:20         ` Alexey Brodkin
2018-11-09 16:41       ` Vineet Gupta
2018-11-09 16:41         ` Vineet Gupta
2018-11-09 21:44         ` Dmitry V. Levin
2018-11-09 21:44           ` Dmitry V. Levin
2018-11-09 23:33           ` [PATCH 02/13 v2] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-09 23:33             ` Dmitry V. Levin
2018-11-09 23:42             ` Vineet Gupta
2018-11-09 23:42               ` Vineet Gupta
2018-11-09  3:15     ` [PATCH 03/13] elf-em.h: add EM_NDS32 Dmitry V. Levin
2018-11-09  3:15     ` [PATCH 04/13] elf-em.h: add EM_XTENSA Dmitry V. Levin
2018-11-09  6:45       ` Max Filippov
2018-11-09  3:15     ` [PATCH 05/13] m68k: define syscall_get_arch() Dmitry V. Levin
2018-11-09  3:16     ` [PATCH 06/13] arc: " Dmitry V. Levin
2018-11-09  3:16       ` Dmitry V. Levin
2018-11-09 14:22       ` Alexey Brodkin
2018-11-09 14:22         ` Alexey Brodkin
2018-11-09 15:17         ` Andy Lutomirski
2018-11-09 15:17           ` Andy Lutomirski
2018-11-09 15:27           ` Alexey Brodkin
2018-11-09 15:27             ` Alexey Brodkin
2018-11-09 15:56             ` Andy Lutomirski
2018-11-09 15:56               ` Andy Lutomirski
2018-11-09 16:11               ` Alexey Brodkin
2018-11-09 16:11                 ` Alexey Brodkin
2018-11-09 16:35                 ` Andy Lutomirski
2018-11-09 16:35                   ` Andy Lutomirski
2018-11-09 23:33                   ` [PATCH 06/13 v2] " Dmitry V. Levin
2018-11-09 23:33                     ` Dmitry V. Levin
2018-11-09 23:39                     ` Vineet Gupta
2018-11-09 23:39                       ` Vineet Gupta
2018-11-09 23:54                       ` [PATCH 06/13 v3] " Dmitry V. Levin
2018-11-09 23:54                         ` Dmitry V. Levin
2018-11-10  0:06                         ` Vineet Gupta
2018-11-10  0:06                           ` Vineet Gupta
2018-11-09 16:50       ` [PATCH 06/13] " Vineet Gupta
2018-11-09 16:50         ` Vineet Gupta
2018-11-09 19:03         ` Andy Lutomirski
2018-11-09 19:03           ` Andy Lutomirski
2018-11-09 19:13           ` Vineet Gupta
2018-11-09 19:13             ` Vineet Gupta
2018-11-09  3:16     ` [PATCH 07/13] c6x: " Dmitry V. Levin
2018-11-10  2:01       ` [PATCH 07/13 v2] " Dmitry V. Levin
2018-11-09  3:16     ` [PATCH 08/13] h8300: " Dmitry V. Levin
2018-11-09  3:16     ` [PATCH 09/13] hexagon: " Dmitry V. Levin
2018-11-09  3:16     ` [PATCH 10/13] nds32: " Dmitry V. Levin
2018-11-10  2:01       ` [PATCH 10/13 v2] " Dmitry V. Levin
2018-11-09  3:17     ` [PATCH 11/13] nios2: " Dmitry V. Levin
2018-11-09  3:17     ` [PATCH 12/13] riscv: " Dmitry V. Levin
2018-11-09  3:17       ` Dmitry V. Levin
2018-11-09  3:17       ` Dmitry V. Levin
2018-11-09  6:59       ` David Abdurachmanov
2018-11-09  6:59         ` David Abdurachmanov
2018-11-09  6:59         ` David Abdurachmanov
2018-11-09 22:28         ` Dmitry V. Levin
2018-11-09 22:28           ` Dmitry V. Levin
2018-11-09 22:28           ` Dmitry V. Levin
2018-11-10  5:12           ` David Abdurachmanov
2018-11-10  5:12             ` David Abdurachmanov
2018-11-10  5:12             ` David Abdurachmanov
2018-11-10  9:27           ` Andreas Schwab
2018-11-10  9:27             ` Andreas Schwab
2018-11-10  9:27             ` Andreas Schwab
2018-11-10  9:27             ` Andreas Schwab
2018-11-09 18:45       ` Palmer Dabbelt
2018-11-09 18:45         ` Palmer Dabbelt
2018-11-09 18:45         ` Palmer Dabbelt
2018-11-09 21:31         ` Dmitry V. Levin
2018-11-09 21:31           ` Dmitry V. Levin
2018-11-09 21:31           ` Dmitry V. Levin
2018-11-09 22:48           ` [PATCH 12/13 v2] " Dmitry V. Levin
2018-11-09 22:48             ` Dmitry V. Levin
2018-11-09 22:48             ` Dmitry V. Levin
2018-11-11 21:21             ` Palmer Dabbelt
2018-11-11 21:21               ` Palmer Dabbelt
2018-11-11 21:21               ` Palmer Dabbelt
2018-11-09  3:17     ` [PATCH 13/13] xtensa: " Dmitry V. Levin
2018-11-09  6:48       ` Max Filippov
2018-11-09  6:06     ` [PATCH 00/13] Prepare for PTRACE_GET_SYSCALL_INFO Andy Lutomirski
2018-11-09  6:06       ` Andy Lutomirski
2018-11-09  6:06       ` Andy Lutomirski
2018-11-09  6:06       ` Andy Lutomirski
2018-11-09  6:06       ` Andy Lutomirski
2018-11-10 14:09     ` [PATCH 14/13] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-10 14:10     ` [PATCH 15/13] unicore32: define syscall_get_arch() Dmitry V. Levin
2018-11-13  3:38   ` [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-11-20  0:11   ` [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2018-11-20  0:11     ` Dmitry V. Levin
2018-11-20  0:11     ` Dmitry V. Levin
2018-11-20  0:11     ` Dmitry V. Levin
2018-11-20  0:11     ` Dmitry V. Levin
2018-11-20  0:14     ` [PATCH v2 01/15] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-20  0:14     ` [PATCH v2 02/15] Move EM_ARCOMPACT and EM_ARCV2 " Dmitry V. Levin
2018-11-20  0:14       ` Dmitry V. Levin
2018-11-20  0:14     ` [PATCH v2 03/15] Move EM_UNICORE " Dmitry V. Levin
2018-11-20  0:15     ` [PATCH v2 04/15] elf-em.h: add EM_NDS32 Dmitry V. Levin
2018-11-20  0:15     ` [PATCH v2 05/15] elf-em.h: add EM_XTENSA Dmitry V. Levin
2018-11-20  0:15     ` [PATCH v2 06/15] m68k: define syscall_get_arch() Dmitry V. Levin
2018-12-02 10:29       ` Geert Uytterhoeven
2018-12-03  0:24         ` Dmitry V. Levin
2018-12-03  7:36           ` Geert Uytterhoeven
2018-11-20  0:15     ` [PATCH v2 07/15] arc: " Dmitry V. Levin
2018-11-20  0:15       ` Dmitry V. Levin
2018-11-20  0:15     ` [PATCH v2 08/15] c6x: " Dmitry V. Levin
2018-11-20  0:16     ` [PATCH v2 09/15] h8300: " Dmitry V. Levin
2018-11-20  0:16     ` [PATCH v2 10/15] hexagon: " Dmitry V. Levin
2018-11-20  0:16     ` [PATCH v2 11/15] nds32: " Dmitry V. Levin
2018-11-20  0:16     ` [PATCH v2 12/15] nios2: " Dmitry V. Levin
2018-11-20  0:16     ` [PATCH v2 13/15] riscv: " Dmitry V. Levin
2018-11-20  0:16       ` Dmitry V. Levin
2018-11-20  0:16       ` Dmitry V. Levin
2018-11-20  0:16     ` [PATCH v2 14/15] unicore32: " Dmitry V. Levin
2018-11-20  0:17     ` [PATCH v2 15/15] xtensa: " Dmitry V. Levin
2018-11-20 20:26     ` [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO Paul Moore
2018-11-20 20:26       ` Paul Moore
2018-11-20 20:26       ` Paul Moore
2018-11-20 20:26       ` Paul Moore
2018-11-21  0:44     ` [PATCH v2 16/15] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-11-21  0:44       ` Dmitry V. Levin
2018-11-21  0:44       ` [OpenRISC] " Dmitry V. Levin
2018-11-21  0:44       ` Dmitry V. Levin
2018-11-21  0:44       ` Dmitry V. Levin
2018-11-21  0:44       ` Dmitry V. Levin
2018-11-21  0:44       ` Dmitry V. Levin
2018-11-21  0:44       ` Dmitry V. Levin
2018-11-21 15:15       ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` [OpenRISC] " Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:15         ` Andy Lutomirski
2018-11-21 15:47       ` Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 15:47         ` [OpenRISC] " Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 15:47         ` Palmer Dabbelt
2018-11-21 18:40       ` Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 18:40         ` [OpenRISC] " Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 18:40         ` Paul Burton
2018-11-21 19:00         ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` [OpenRISC] " Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:00           ` Dmitry V. Levin
2018-11-21 19:14           ` Dmitry V. Levin [this message]
2018-11-21 19:23             ` [PATCH] mips: fix mips_get_syscall_arg o32 check Paul Burton
2018-11-21 19:23               ` Paul Burton
2018-11-21 19:35           ` [PATCH v2 16/15 v2] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` [OpenRISC] " Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:35             ` Dmitry V. Levin
2018-11-21 19:45             ` Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-21 19:45               ` [OpenRISC] " Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-21 19:45               ` Paul Burton
2018-11-27 10:34       ` [PATCH v2 16/15] " Michael Ellerman
2018-11-27 10:34         ` Michael Ellerman
2018-11-27 10:34         ` [OpenRISC] " Michael Ellerman
2018-11-27 10:34         ` Michael Ellerman
2018-11-27 10:34         ` Michael Ellerman
2018-11-27 10:34         ` Michael Ellerman
2018-11-27 10:34         ` Michael Ellerman
2018-11-27 10:34         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181121191438.GB10301@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=jhogan@kernel.org \
    --cc=lineprinter@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=paul.burton@mips.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.