* [PATCH] nvme: fixup ANA group descriptor offset
@ 2018-11-05 15:00 Hannes Reinecke
2018-11-06 19:02 ` Schremmer, Steven
2018-11-07 8:28 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Hannes Reinecke @ 2018-11-05 15:00 UTC (permalink / raw)
The ANA group descriptor offset changed between the specification
sent for ratification and the final ratified document, causing the
ANA log page not to be displayed correctly.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
linux/nvme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux/nvme.h b/linux/nvme.h
index 37d3bc1..1ad970a 100644
--- a/linux/nvme.h
+++ b/linux/nvme.h
@@ -546,7 +546,7 @@ struct nvme_ana_group_desc {
__le32 nnsids;
__le64 chgcnt;
__u8 state;
- __u8 rsvd17[7];
+ __u8 rsvd17[15];
__le32 nsids[];
};
--
2.13.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] nvme: fixup ANA group descriptor offset
2018-11-05 15:00 [PATCH] nvme: fixup ANA group descriptor offset Hannes Reinecke
@ 2018-11-06 19:02 ` Schremmer, Steven
2018-11-08 16:27 ` Keith Busch
2018-11-07 8:28 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Schremmer, Steven @ 2018-11-06 19:02 UTC (permalink / raw)
> From: Linux-nvme <linux-nvme-bounces at lists.infradead.org> On Behalf Of Hannes Reinecke
>
> The ANA group descriptor offset changed between the specification
> sent for ratification and the final ratified document, causing the
> ANA log page not to be displayed correctly.
>
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> ---
> linux/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux/nvme.h b/linux/nvme.h
> index 37d3bc1..1ad970a 100644
> --- a/linux/nvme.h
> +++ b/linux/nvme.h
> @@ -546,7 +546,7 @@ struct nvme_ana_group_desc {
> __le32 nnsids;
> __le64 chgcnt;
> __u8 state;
> - __u8 rsvd17[7];
> + __u8 rsvd17[15];
> __le32 nsids[];
> };
>
> --
> 2.13.7
Thanks, I was just getting ready to create a patch for this.
Reviewed-by: Steve Schremmer <steve.schremmer at netapp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] nvme: fixup ANA group descriptor offset
2018-11-06 19:02 ` Schremmer, Steven
@ 2018-11-08 16:27 ` Keith Busch
0 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2018-11-08 16:27 UTC (permalink / raw)
On Tue, Nov 06, 2018@07:02:33PM +0000, Schremmer, Steven wrote:
> > From: Linux-nvme <linux-nvme-bounces at lists.infradead.org> On Behalf Of Hannes Reinecke
> >
> > The ANA group descriptor offset changed between the specification
> > sent for ratification and the final ratified document, causing the
> > ANA log page not to be displayed correctly.
> >
> > Signed-off-by: Hannes Reinecke <hare at suse.com>
> > ---
> > linux/nvme.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/linux/nvme.h b/linux/nvme.h
> > index 37d3bc1..1ad970a 100644
> > --- a/linux/nvme.h
> > +++ b/linux/nvme.h
> > @@ -546,7 +546,7 @@ struct nvme_ana_group_desc {
> > __le32 nnsids;
> > __le64 chgcnt;
> > __u8 state;
> > - __u8 rsvd17[7];
> > + __u8 rsvd17[15];
> > __le32 nsids[];
> > };
> >
> > --
> > 2.13.7
>
>
> Thanks, I was just getting ready to create a patch for this.
>
> Reviewed-by: Steve Schremmer <steve.schremmer at netapp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme: fixup ANA group descriptor offset
2018-11-05 15:00 [PATCH] nvme: fixup ANA group descriptor offset Hannes Reinecke
2018-11-06 19:02 ` Schremmer, Steven
@ 2018-11-07 8:28 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2018-11-07 8:28 UTC (permalink / raw)
On Mon, Nov 05, 2018@04:00:36PM +0100, Hannes Reinecke wrote:
> The ANA group descriptor offset changed between the specification
> sent for ratification and the final ratified document, causing the
> ANA log page not to be displayed correctly.
Please fix the subject line, this is a nvme-cli patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-08 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-05 15:00 [PATCH] nvme: fixup ANA group descriptor offset Hannes Reinecke
2018-11-06 19:02 ` Schremmer, Steven
2018-11-08 16:27 ` Keith Busch
2018-11-07 8:28 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.