[PATCH v2] staging: davinci_vpfe: Remove one blank space

[PATCH v2] staging: davinci_vpfe: Remove one blank space

[Irenge Jules Bashizi]

Remove one blank space complained by checkpatch

Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 81b369b28a47..79f7f7f9a36b 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1466,7 +1466,7 @@ ipipe_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
 	struct v4l2_mbus_framefmt *format;
 
 	format = __ipipe_get_format(ipipe, cfg, fmt->pad, fmt->which);
-	if (format == NULL)
+	if (!format)
 		return -EINVAL;
 
 	ipipe_try_format(ipipe, cfg, fmt->pad, &fmt->format, fmt->which);
@@ -1818,7 +1818,6 @@ vpfe_ipipe_init(struct vpfe_ipipe_device *ipipe, struct platform_device *pdev)
 			  V4L2_CID_CONTRAST, 0,
 			  IPIPE_CONTRAST_HIGH, 1, 16);
 
-
 	v4l2_ctrl_handler_setup(&ipipe->ctrls);
 	sd->ctrl_handler = &ipipe->ctrls;
 
-- 
2.17.2

Re: [PATCH v2] staging: davinci_vpfe: Remove one blank space

[Greg KH]

On Thu, Nov 08, 2018 at 11:09:18PM +0000, Irenge Jules Bashizi wrote:
> Remove one blank space complained by checkpatch

That is not what this patch did :(

Re: [Outreachy kernel] [PATCH v2] staging: davinci_vpfe: Remove one blank space

[Julia Lawall]

On Thu, 8 Nov 2018, Irenge Jules Bashizi wrote:

> Remove one blank space complained by checkpatch
>
> Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
> ---
>  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index 81b369b28a47..79f7f7f9a36b 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1466,7 +1466,7 @@ ipipe_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>  	struct v4l2_mbus_framefmt *format;
>
>  	format = __ipipe_get_format(ipipe, cfg, fmt->pad, fmt->which);
> -	if (format == NULL)
> +	if (!format)
>  		return -EINVAL;

This change was part of another patch.

julia

>
>  	ipipe_try_format(ipipe, cfg, fmt->pad, &fmt->format, fmt->which);
> @@ -1818,7 +1818,6 @@ vpfe_ipipe_init(struct vpfe_ipipe_device *ipipe, struct platform_device *pdev)
>  			  V4L2_CID_CONTRAST, 0,
>  			  IPIPE_CONTRAST_HIGH, 1, 16);
>
> -
>  	v4l2_ctrl_handler_setup(&ipipe->ctrls);
>  	sd->ctrl_handler = &ipipe->ctrls;
>
> --
> 2.17.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181108230918.4477-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>