All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: John Stultz <john.stultz@linaro.org>
Cc: hch@lst.de, Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	robin.murphy@arm.com, konrad.wilk@oracle.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	iommu@lists.linux-foundation.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>
Subject: Re: [PATCH 06/10] swiotlb: use swiotlb_map_page in swiotlb_map_sg_attrs
Date: Fri, 9 Nov 2018 08:49:55 +0100	[thread overview]
Message-ID: <20181109074955.GA27489@lst.de> (raw)
In-Reply-To: <CANcMJZAzrxA9LGNvP-epv2DwsUacEM_hcgA1n5gmaPuWRJG4iw@mail.gmail.com>

On Tue, Nov 06, 2018 at 05:27:14PM -0800, John Stultz wrote:
> But at that point if I just re-apply "swiotlb: use swiotlb_map_page in
> swiotlb_map_sg_attrs", I reproduce the hangs.
> 
> Any suggestions for how to further debug what might be going wrong
> would be appreciated!

Very odd.  In the end map_sg and map_page are defined to do the same
things to start with.  The only real issue we had in this area was:

"[PATCH v2] of/device: Really only set bus DMA mask when appropriate"

so with current mainline + that you still see a problem, and if you
rever the commit we are replying to it still goes away?

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] swiotlb: use swiotlb_map_page in swiotlb_map_sg_attrs
Date: Fri, 9 Nov 2018 08:49:55 +0100	[thread overview]
Message-ID: <20181109074955.GA27489@lst.de> (raw)
In-Reply-To: <CANcMJZAzrxA9LGNvP-epv2DwsUacEM_hcgA1n5gmaPuWRJG4iw@mail.gmail.com>

On Tue, Nov 06, 2018 at 05:27:14PM -0800, John Stultz wrote:
> But at that point if I just re-apply "swiotlb: use swiotlb_map_page in
> swiotlb_map_sg_attrs", I reproduce the hangs.
> 
> Any suggestions for how to further debug what might be going wrong
> would be appreciated!

Very odd.  In the end map_sg and map_page are defined to do the same
things to start with.  The only real issue we had in this area was:

"[PATCH v2] of/device: Really only set bus DMA mask when appropriate"

so with current mainline + that you still see a problem, and if you
rever the commit we are replying to it still goes away?

  reply	other threads:[~2018-11-09  7:49 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  8:02 move swiotlb noncoherent dma support from arm64 to generic code V2 Christoph Hellwig
2018-10-08  8:02 ` Christoph Hellwig
2018-10-08  8:02 ` [PATCH 01/10] swiotlb: remove a pointless comment Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-11 17:49   ` Robin Murphy
2018-10-11 17:49     ` Robin Murphy
     [not found]   ` <20181008080246.20543-2-hch-jcswGhMUV9g@public.gmane.org>
2018-10-19  0:09     ` Konrad Rzeszutek Wilk
2018-10-19  0:09       ` Konrad Rzeszutek Wilk
2018-10-19  0:09       ` Konrad Rzeszutek Wilk
2018-10-08  8:02 ` [PATCH 02/10] swiotlb: mark is_swiotlb_buffer static Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-11 17:54   ` Robin Murphy
2018-10-11 17:54     ` Robin Murphy
     [not found]   ` <20181008080246.20543-3-hch-jcswGhMUV9g@public.gmane.org>
2018-10-19  0:12     ` Konrad Rzeszutek Wilk
2018-10-19  0:12       ` Konrad Rzeszutek Wilk
2018-10-19  0:12       ` Konrad Rzeszutek Wilk
2018-10-08  8:02 ` [PATCH 03/10] swiotlb: do not panic on mapping failures Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-11 18:06   ` Robin Murphy
2018-10-11 18:06     ` Robin Murphy
     [not found]     ` <ff847d0d-a2a1-65ba-ed18-aa71f632194d-5wv7dgnIgG8@public.gmane.org>
2018-10-19  0:18       ` Konrad Rzeszutek Wilk
2018-10-19  0:18         ` Konrad Rzeszutek Wilk
2018-10-19  0:18         ` Konrad Rzeszutek Wilk
     [not found]   ` <20181008080246.20543-4-hch-jcswGhMUV9g@public.gmane.org>
2018-10-19  0:17     ` Konrad Rzeszutek Wilk
2018-10-19  0:17       ` Konrad Rzeszutek Wilk
2018-10-19  0:17       ` Konrad Rzeszutek Wilk
2018-10-19  6:04       ` Christoph Hellwig
2018-10-19  6:04         ` Christoph Hellwig
     [not found]         ` <20181019060425.GA28108-jcswGhMUV9g@public.gmane.org>
2018-10-19 13:45           ` Konrad Rzeszutek Wilk
2018-10-19 13:45             ` Konrad Rzeszutek Wilk
2018-10-19 13:45             ` Konrad Rzeszutek Wilk
2018-10-08  8:02 ` [PATCH 04/10] swiotlb: remove the overflow buffer Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-11 18:19   ` Robin Murphy
2018-10-11 18:19     ` Robin Murphy
2018-10-12 17:04   ` Catalin Marinas
2018-10-12 17:04     ` Catalin Marinas
     [not found]   ` <20181008080246.20543-5-hch-jcswGhMUV9g@public.gmane.org>
2018-10-19  0:23     ` Konrad Rzeszutek Wilk
2018-10-19  0:23       ` Konrad Rzeszutek Wilk
2018-10-19  0:23       ` Konrad Rzeszutek Wilk
2018-10-08  8:02 ` [PATCH 05/10] swiotlb: merge swiotlb_unmap_page and unmap_single Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-18 17:44   ` Robin Murphy
2018-10-18 17:44     ` Robin Murphy
2018-10-19  0:25   ` Konrad Rzeszutek Wilk
2018-10-19  0:25     ` Konrad Rzeszutek Wilk
2018-10-19  0:25     ` Konrad Rzeszutek Wilk
2018-10-08  8:02 ` [PATCH 06/10] swiotlb: use swiotlb_map_page in swiotlb_map_sg_attrs Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
     [not found]   ` <20181008080246.20543-7-hch-jcswGhMUV9g@public.gmane.org>
2018-10-18 17:53     ` Robin Murphy
2018-10-18 17:53       ` Robin Murphy
2018-10-18 17:53       ` Robin Murphy
2018-10-19  0:33     ` Konrad Rzeszutek Wilk
2018-10-19  0:33       ` Konrad Rzeszutek Wilk
2018-10-19  0:33       ` Konrad Rzeszutek Wilk
2018-11-07  1:27   ` John Stultz
2018-11-07  1:27     ` John Stultz
2018-11-09  7:49     ` Christoph Hellwig [this message]
2018-11-09  7:49       ` Christoph Hellwig
2018-11-09 16:37       ` Robin Murphy
2018-11-09 16:37         ` Robin Murphy
     [not found]         ` <9922f377-ee87-ba36-8d28-26af0f7822e5-5wv7dgnIgG8@public.gmane.org>
2018-11-19 19:36           ` Robin Murphy
2018-11-19 19:36             ` Robin Murphy
2018-11-19 19:36             ` Robin Murphy
2018-11-20  9:22             ` Christoph Hellwig
2018-11-20  9:22               ` Christoph Hellwig
2018-11-13  0:07       ` John Stultz
2018-11-13  0:07         ` John Stultz
2018-11-13  0:26         ` John Stultz
2018-11-13  0:26           ` John Stultz
2018-11-14 14:13         ` Christoph Hellwig
2018-11-14 14:13           ` Christoph Hellwig
2018-11-14 16:12           ` Christoph Hellwig
2018-11-14 16:12             ` Christoph Hellwig
2018-11-19 23:22             ` John Stultz
2018-11-19 23:22               ` John Stultz
2018-11-20  9:25               ` Christoph Hellwig
2018-11-20  9:25                 ` Christoph Hellwig
2018-11-23 18:27                 ` Will Deacon
2018-11-23 18:27                   ` Will Deacon
2018-11-23 19:34                   ` Robin Murphy
2018-11-23 19:34                     ` Robin Murphy
2018-11-26 19:31                     ` Will Deacon
2018-11-26 19:31                       ` Will Deacon
2018-10-08  8:02 ` [PATCH 07/10] swiotlb: refactor swiotlb_map_page Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-18 18:09   ` Robin Murphy
2018-10-18 18:09     ` Robin Murphy
     [not found]     ` <35016142-f06d-e424-5afe-6026b6d57eda-5wv7dgnIgG8@public.gmane.org>
2018-10-19  0:37       ` Konrad Rzeszutek Wilk
2018-10-19  0:37         ` Konrad Rzeszutek Wilk
2018-10-19  0:37         ` Konrad Rzeszutek Wilk
     [not found]         ` <20181019003715.GI1251-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
2018-10-19  6:52           ` Christoph Hellwig
2018-10-19  6:52             ` Christoph Hellwig
2018-10-19  6:52             ` Christoph Hellwig
     [not found]             ` <20181019065258.GA29249-jcswGhMUV9g@public.gmane.org>
2018-10-19 13:46               ` Konrad Rzeszutek Wilk
2018-10-19 13:46                 ` Konrad Rzeszutek Wilk
2018-10-19 13:46                 ` Konrad Rzeszutek Wilk
2018-10-08  8:02 ` [PATCH 08/10] swiotlb: don't dip into swiotlb pool for coherent allocations Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-12 17:04   ` Catalin Marinas
2018-10-12 17:04     ` Catalin Marinas
     [not found]   ` <20181008080246.20543-9-hch-jcswGhMUV9g@public.gmane.org>
2018-10-19  0:40     ` Konrad Rzeszutek Wilk
2018-10-19  0:40       ` Konrad Rzeszutek Wilk
2018-10-19  0:40       ` Konrad Rzeszutek Wilk
2018-10-19 16:45   ` Robin Murphy
2018-10-19 16:45     ` Robin Murphy
2018-10-08  8:02 ` [PATCH 09/10] swiotlb: add support for non-coherent DMA Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-19  0:49   ` Konrad Rzeszutek Wilk
2018-10-19  0:49     ` Konrad Rzeszutek Wilk
2018-10-22 17:11   ` Robin Murphy
2018-10-22 17:11     ` Robin Murphy
2018-10-26  8:04     ` Christoph Hellwig
2018-10-26  8:04       ` Christoph Hellwig
     [not found]       ` <20181026080421.GA6100-jcswGhMUV9g@public.gmane.org>
2018-10-26  9:59         ` Robin Murphy
2018-10-26  9:59           ` Robin Murphy
2018-10-26  9:59           ` Robin Murphy
2018-10-08  8:02 ` [PATCH 10/10] arm64: use the generic swiotlb_dma_ops Christoph Hellwig
2018-10-08  8:02   ` Christoph Hellwig
2018-10-12 13:01   ` Robin Murphy
2018-10-12 13:01     ` Robin Murphy
2018-10-12 14:40     ` Christoph Hellwig
2018-10-12 14:40       ` Christoph Hellwig
     [not found]       ` <20181012144049.GA28925-jcswGhMUV9g@public.gmane.org>
2018-10-12 17:05         ` Catalin Marinas
2018-10-12 17:05           ` Catalin Marinas
2018-10-12 17:05           ` Catalin Marinas
     [not found]   ` <20181008080246.20543-11-hch-jcswGhMUV9g@public.gmane.org>
2018-10-22 17:52     ` Robin Murphy
2018-10-22 17:52       ` Robin Murphy
2018-10-22 17:52       ` Robin Murphy
2018-10-26 12:44       ` Christoph Hellwig
2018-10-26 12:44         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109074955.GA27489@lst.de \
    --to=hch@lst.de \
    --cc=catalin.marinas@arm.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=john.stultz@linaro.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=valentin.schneider@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.