From: Christoph Hellwig <hch@lst.de>
To: Guo Ren <ren_guo@c-sky.com>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Laura Abbott <labbott@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] csky: use the generic remapping dma alloc implementation
Date: Fri, 9 Nov 2018 08:51:58 +0100 [thread overview]
Message-ID: <20181109075158.GB27489@lst.de> (raw)
In-Reply-To: <20181106070140.GA6232@guoren-Inspiron-7460>
On Tue, Nov 06, 2018 at 03:01:41PM +0800, Guo Ren wrote:
> > + return dma_atomic_pool_init(GFP_KERNEL, pgprot_noncached(PAGE_KERNEL));
> > }
> > postcore_initcall(atomic_pool_init);
> Seems also could remove atomic_pool_init from csky, why not put them in
> common?
The code basically moved to common code, but the architecture needs
to pick the gfp mask (GFP_DMA32 on arm vs GFP_KERNEL on csky for example)
and the pgprot it needs for uncached remappings.
> Reviewed-by: Guo Ren <ren_guo@c-sky.com>
>
> Compile is OK, qemu boot OK. Functions are the same and just move to common.
Thanks for your review!
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] csky: use the generic remapping dma alloc implementation
Date: Fri, 9 Nov 2018 08:51:58 +0100 [thread overview]
Message-ID: <20181109075158.GB27489@lst.de> (raw)
In-Reply-To: <20181106070140.GA6232@guoren-Inspiron-7460>
On Tue, Nov 06, 2018 at 03:01:41PM +0800, Guo Ren wrote:
> > + return dma_atomic_pool_init(GFP_KERNEL, pgprot_noncached(PAGE_KERNEL));
> > }
> > postcore_initcall(atomic_pool_init);
> Seems also could remove atomic_pool_init from csky, why not put them in
> common?
The code basically moved to common code, but the architecture needs
to pick the gfp mask (GFP_DMA32 on arm vs GFP_KERNEL on csky for example)
and the pgprot it needs for uncached remappings.
> Reviewed-by: Guo Ren <ren_guo@c-sky.com>
>
> Compile is OK, qemu boot OK. Functions are the same and just move to common.
Thanks for your review!
next prev parent reply other threads:[~2018-11-09 7:51 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 12:19 move the arm arch_dma_alloc implementation to common code Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 1/9] dma-direct: provide page based alloc/free helpers Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-30 19:04 ` Robin Murphy
2018-11-30 19:04 ` Robin Murphy
2018-12-01 16:56 ` Christoph Hellwig
2018-12-01 16:56 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 2/9] dma-direct: reject highmem pages from dma_alloc_from_contiguous Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-30 19:04 ` Robin Murphy
2018-11-30 19:04 ` Robin Murphy
2018-12-01 16:57 ` Christoph Hellwig
2018-12-01 16:57 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 3/9] dma-mapping: move the remap helpers to a separate file Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
[not found] ` <20181105121931.13481-4-hch-jcswGhMUV9g@public.gmane.org>
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
2018-12-01 16:59 ` Christoph Hellwig
2018-12-01 16:59 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 4/9] dma-mapping: move the arm64 ncoherent alloc/free support to common code Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-15 19:50 ` Will Deacon
2018-11-15 19:50 ` Will Deacon
[not found] ` <20181105121931.13481-5-hch-jcswGhMUV9g@public.gmane.org>
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
2018-12-01 17:03 ` Christoph Hellwig
2018-12-01 17:03 ` Christoph Hellwig
2018-12-04 10:09 ` Russell King - ARM Linux
2018-12-04 10:09 ` Russell King - ARM Linux
2018-12-04 10:09 ` Russell King - ARM Linux
2018-12-04 14:22 ` Christoph Hellwig
2018-12-04 14:22 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 5/9] dma-mapping: support highmem in the generic remap allocator Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
2018-12-04 8:38 ` Marek Szyprowski
2018-12-04 8:38 ` Marek Szyprowski
[not found] ` <e1567e0d-4724-fb6b-cc22-3a723eec5e0f-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-12-04 14:23 ` Christoph Hellwig
2018-12-04 14:23 ` Christoph Hellwig
2018-12-04 14:23 ` Christoph Hellwig
2018-12-05 10:14 ` [PATCH] dma-mapping: fix lack of DMA address assignment in " Marek Szyprowski
2018-12-05 10:14 ` Marek Szyprowski
2018-12-05 12:35 ` Thierry Reding
2018-12-05 12:35 ` Thierry Reding
2018-12-05 13:49 ` Christoph Hellwig
2018-12-05 13:49 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 6/9] dma-remap: support DMA_ATTR_NO_KERNEL_MAPPING Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
[not found] ` <20181105121931.13481-7-hch-jcswGhMUV9g@public.gmane.org>
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
2018-11-30 19:05 ` Robin Murphy
[not found] ` <e993440c-53bf-8071-b1b6-06d022d39e4e-5wv7dgnIgG8@public.gmane.org>
2018-12-01 17:05 ` Christoph Hellwig
2018-12-01 17:05 ` Christoph Hellwig
2018-12-01 17:05 ` Christoph Hellwig
2018-11-05 12:19 ` [PATCH 7/9] csky: don't select DMA_NONCOHERENT_OPS Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-05 15:47 ` Guo Ren
2018-11-05 15:47 ` Guo Ren
2018-11-05 12:19 ` [PATCH 8/9] csky: don't use GFP_DMA in atomic_pool_init Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-05 15:47 ` Guo Ren
2018-11-05 15:47 ` Guo Ren
2018-11-05 12:19 ` [PATCH 9/9] csky: use the generic remapping dma alloc implementation Christoph Hellwig
2018-11-05 12:19 ` Christoph Hellwig
2018-11-06 7:01 ` Guo Ren
2018-11-06 7:01 ` Guo Ren
2018-11-09 7:51 ` Christoph Hellwig [this message]
2018-11-09 7:51 ` Christoph Hellwig
2018-11-09 7:52 ` move the arm arch_dma_alloc implementation to common code Christoph Hellwig
2018-11-09 7:52 ` Christoph Hellwig
[not found] ` <20181109075238.GA27578-jcswGhMUV9g@public.gmane.org>
2018-11-15 19:50 ` Will Deacon
2018-11-15 19:50 ` Will Deacon
2018-11-15 19:50 ` Will Deacon
2018-11-15 20:58 ` Robin Murphy
2018-11-15 20:58 ` Robin Murphy
2018-11-27 7:37 ` Christoph Hellwig
2018-11-27 7:37 ` Christoph Hellwig
2018-11-28 12:18 ` Robin Murphy
2018-11-28 12:18 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109075158.GB27489@lst.de \
--to=hch@lst.de \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ren_guo@c-sky.com \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.