* [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported
@ 2018-10-12 13:47 Ulrich Hecht
2018-10-14 16:42 ` Wolfram Sang
2018-11-09 11:11 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Ulrich Hecht @ 2018-10-12 13:47 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: wsa, geert, linux-serial, Ulrich Hecht
Not all (H)SCIF devices support DMA, and failure to set it up is not
normally a cause for concern. This patch demotes the associated warning to
debug output.
Inspired by BSP patch "sci: sh-sci: Fix transfer sequence of unsupport DMA
transfer" (6beb1f98d3bd30) by Hiromitsu Yamasaki.
Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
---
drivers/tty/serial/sh-sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 426241d..ff6ba6d 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -1516,7 +1516,7 @@ static struct dma_chan *sci_request_dma_chan(struct uart_port *port,
chan = dma_request_slave_channel(port->dev,
dir == DMA_MEM_TO_DEV ? "tx" : "rx");
if (!chan) {
- dev_warn(port->dev, "dma_request_slave_channel failed\n");
+ dev_dbg(port->dev, "dma_request_slave_channel failed\n");
return NULL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported
2018-10-12 13:47 [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported Ulrich Hecht
@ 2018-10-14 16:42 ` Wolfram Sang
2018-11-09 11:11 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2018-10-14 16:42 UTC (permalink / raw)
To: Ulrich Hecht; +Cc: linux-renesas-soc, geert, linux-serial
On Fri, Oct 12, 2018 at 03:47:49PM +0200, Ulrich Hecht wrote:
> Not all (H)SCIF devices support DMA, and failure to set it up is not
> normally a cause for concern. This patch demotes the associated warning to
> debug output.
>
> Inspired by BSP patch "sci: sh-sci: Fix transfer sequence of unsupport DMA
> transfer" (6beb1f98d3bd30) by Hiromitsu Yamasaki.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported
2018-10-12 13:47 [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported Ulrich Hecht
2018-10-14 16:42 ` Wolfram Sang
@ 2018-11-09 11:11 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2018-11-09 11:11 UTC (permalink / raw)
To: Ulrich Hecht; +Cc: linux-renesas-soc, geert, linux-serial
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Fri, Oct 12, 2018 at 03:47:49PM +0200, Ulrich Hecht wrote:
> Not all (H)SCIF devices support DMA, and failure to set it up is not
> normally a cause for concern. This patch demotes the associated warning to
> debug output.
>
> Inspired by BSP patch "sci: sh-sci: Fix transfer sequence of unsupport DMA
> transfer" (6beb1f98d3bd30) by Hiromitsu Yamasaki.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-09 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-12 13:47 [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported Ulrich Hecht
2018-10-14 16:42 ` Wolfram Sang
2018-11-09 11:11 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.