All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "João Paulo Rechi Vita" <jprvita@gmail.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	"Len Brown" <lenb@kernel.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	linux-acpi@vger.kernel.org, "Daniel Drake" <drake@endlessm.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.co.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	linux@endlessm.com,
	"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%
Date: Sun, 11 Nov 2018 12:30:29 +0100	[thread overview]
Message-ID: <20181111113029.GD27666@amd> (raw)
In-Reply-To: <CA+A7VXXUB2CZUyPtaMya7in7ntO_unbqVnaZyfCBT_BXtAxeQQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi!

> > >        * was plugged in and the device thus did not start a new charge cycle.
> > >        */
> > >       if ((battery_ac_is_broken || power_supply_is_system_supplied()) &&
> > > -         battery->rate_now == 0)
> > > +         battery->rate_now == 0) {
> > > +             if (battery->capacity_now && battery->full_charge_capacity &&
> > > +                 battery->capacity_now / battery->full_charge_capacity == 1)
> > > +                     return POWER_SUPPLY_STATUS_FULL;
> >
> > Division? Really?

> 
> If you look further down in acpi_battery_get_property, that is how the
> capacity property is calculated. Do you have a better suggestion?

if (battery->capacity_now >= battery->full_charge_capacity)

?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2018-11-11 11:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-03  6:57 [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100% João Paulo Rechi Vita
2018-11-03 11:28 ` Hans de Goede
2018-11-06 20:14   ` João Paulo Rechi Vita
2018-11-05  9:19 ` Pavel Machek
2018-11-06 20:34   ` João Paulo Rechi Vita
2018-11-07  4:53     ` Daniel Drake
2018-11-11 11:57       ` Hans de Goede
2018-11-11 12:22         ` Pavel Machek
2018-11-20  2:12           ` João Paulo Rechi Vita
2018-11-20  9:16             ` Pavel Machek
2018-11-11 11:30     ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181111113029.GD27666@amd \
    --to=pavel@ucw.cz \
    --cc=drake@endlessm.com \
    --cc=hdegoede@redhat.com \
    --cc=jprvita@endlessm.com \
    --cc=jprvita@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=rjw@rjwysocki.net \
    --cc=sebastian.reichel@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.