Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

Hi!

> > > Anyways this ultimately is Rafael's call. If Rafael is ok with this
> > > patch then I would like to see Pavel's comment addressed and otherwise
> > > it is fine with me.
> > >
> 
> If we can get to an agreement on this I'll send a v2 without division.
> 
> > > Note that we will still often get the case where a laptop is charged,
> > > reports full, is unplugged for 5 minutes and then replugged and then
> > > reports a capacity of 97% combined with "not charging", so we will
> > > still need to fix userspace to handle this.
> >
> 
> Yes, I agree that should be addressed in userspace, as it is pretty
> much a policy decision.

But it is battery hardware doing this. So you need to take it into
account.

> > For the record, I don't think I'm okay with this.
> >
> > There's nothing special about 100% charge.
> >
> 
> I don't agree there is nothing special about 100% charge. There is a
> separate state to represent battery full for a reason, which is the
> user wanting to know when their battery is 100% charged and not being
> discharged.

Yes, there is full for a reason, and you can be full at 97%, for
example, as described above.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]