From: Pavel Machek <pavel@ucw.cz>
To: Brian Dodge <bdodge09@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, lee.jones@linaro.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/3] backlight/arcxcnn fix vendor prefix
Date: Sun, 11 Nov 2018 12:30:54 +0100 [thread overview]
Message-ID: <20181111113053.GF27666@amd> (raw)
In-Reply-To: <1541592640-18478-3-git-send-email-bdodge09@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1217 bytes --]
Hi!
> The vendor-prefixes.txt file properly refers to ArcticSand
> as arctic but the driver improperly abbreviated the prefix
> to arc. This was a mistake in the original patch
>
> Signed-off-by: Brian Dodge <bdodge09@gmail.com>
> ---
> drivers/video/backlight/arcxcnn_bl.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> *
> - * Copyright 2016 ArcticSand, Inc.
> - * Author : Brian Dodge <bdodge@arcticsand.com>
> + * Copyright 2018 pSemi, Inc.
> + * Author : Brian Dodge <bdodge@psemi.com>
Ummm. Copyright 2016-2018?
> @@ -202,27 +202,27 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
> if (ret == 0)
> lp->pdata->initial_brightness = prog_val;
>
> - ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
> + ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
> if (ret == 0)
> lp->pdata->led_config_0 = (u8)prog_val;
>
If there's a dts using this, you want to update it at the same
time. You may want to support both names going forward.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-11 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 12:10 [PATCH 0/3] backlight/arcxcnn fix vendor prefix in driver and bindings and add support for arc1, arc3 Brian Dodge
2018-11-07 12:10 ` [PATCH 1/3] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings Brian Dodge
2018-11-12 18:42 ` Rob Herring
2018-11-07 12:10 ` [PATCH 2/3] backlight/arcxcnn fix vendor prefix Brian Dodge
2018-11-11 11:30 ` Pavel Machek [this message]
2018-11-27 0:44 ` Brian Dodge
2019-06-21 13:39 ` Daniel Thompson
2019-06-21 13:46 ` Daniel Thompson
2019-06-21 13:48 ` Daniel Thompson
2019-06-21 22:13 ` Pavel Machek
2019-06-24 10:24 ` Daniel Thompson
2019-06-24 11:29 ` Brian Dodge
2019-06-24 13:59 ` Daniel Thompson
2018-11-07 12:10 ` [PATCH 3/3] backlight/arcxcnn add support for arc1 an arc3 chip families Brian Dodge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111113053.GF27666@amd \
--to=pavel@ucw.cz \
--cc=bdodge09@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.