From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Przemyslaw Sroka <psroka@cadence.com>,
Arkadiusz Golec <agolec@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
Alicja Jurasik-Urbaniak <alicja@cadence.com>,
Cyprian Wronka <cwronka@cadence.com>,
Suresh Punnoose <sureshp@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Vitor Soares <Vitor.Soares@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
Xiang Lin <Xiang.Lin@synaptics.com>,
linux-gpio@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
Przemyslaw Gaj <pgaj@cadence.com>, Peter Rosin <peda@axentia.se>,
Mike Shettel <mshettel@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v10 0/9] Add the I3C subsystem
Date: Sun, 11 Nov 2018 11:10:20 -0800 [thread overview]
Message-ID: <20181111191020.GA21003@kroah.com> (raw)
In-Reply-To: <20181111191017.7b2efdf1@bbrezillon>
On Sun, Nov 11, 2018 at 07:10:17PM +0100, Boris Brezillon wrote:
> Hi Greg,
>
> On Sun, 11 Nov 2018 09:39:32 -0800
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> > On Fri, Oct 26, 2018 at 04:43:24PM +0200, Boris Brezillon wrote:
> > > Hi Greg,
> > >
> > > I think we've reached a point where we can eventually consider the I3C
> > > framework for inclusion in 4.20 (5.0?). A few more issues were reported
> > > on v9 and fixed in v10. I can't guarantee that the implementation is
> > > free of bugs but I still think it's worth merging it in v4.20: it's a
> > > new subsystem, so we don't risk regressions, and the only way we can
> > > detect other issues is by having other people experiment with this
> > > implementation.
> > >
> > > The only remaining concern raised by Arnd is the fact that both hosts
> > > and slaves share the same bus type and are differentiated thanks to
> > > their device_type, which IMHO is fine since this is what other
> > > subsystems do (plus I don't see other solutions to have both I3C
> > > devices and I3C buses represented under /sys/bus/i3c/).
> >
> > Yeah, it's not the nicest, but it will work, we did it also for USB and
> > greybus and it solves the issue.
> >
> > This all looks good to me, so I've queued it up. Let's see if
> > linux-next has any problems with it.
>
> I recently asked Stephen to add the linux-i3c tree to linux-next, so
> I'm expecting conflicts :-/. Sorry, I didn't know you were planning to
> take these patches through your tree.
>
> BTW, I also fixed a couple of things when rebasing on top of 4.20-rc1:
>
> - KernelVersion in the sysfs ABI doc has been updated to 5.0
There is no 5.0 yet :)
> - Fixed i3c_master_getmxds_locked() (bug reported/fixed by Colin here
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1799850.html)
> - Removed a blank line at the end of master-driver-api.rst
>
> For the record, the i3c/next branch pulled by Stephen is available here
> [1].
>
> > Thanks for sticking with it, nice work!
>
> Thanks for reviewing it! Greg, Stephen, let me know if you want me to
> reset i3c/next to v4.20-rc1 to avoid conflicts in linux-next.
So do you want me to just drop these patches from my tree? If so, I
can, but i have no problem sending these to Linus for the next -rc1
merge window through my tree if that is easier.
It's up to you.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Przemyslaw Sroka <psroka@cadence.com>,
Arkadiusz Golec <agolec@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
Alicja Jurasik-Urbaniak <alicja@cadence.com>,
Cyprian Wronka <cwronka@cadence.com>,
Suresh Punnoose <sureshp@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>devi
Subject: Re: [PATCH v10 0/9] Add the I3C subsystem
Date: Sun, 11 Nov 2018 11:10:20 -0800 [thread overview]
Message-ID: <20181111191020.GA21003@kroah.com> (raw)
In-Reply-To: <20181111191017.7b2efdf1@bbrezillon>
On Sun, Nov 11, 2018 at 07:10:17PM +0100, Boris Brezillon wrote:
> Hi Greg,
>
> On Sun, 11 Nov 2018 09:39:32 -0800
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> > On Fri, Oct 26, 2018 at 04:43:24PM +0200, Boris Brezillon wrote:
> > > Hi Greg,
> > >
> > > I think we've reached a point where we can eventually consider the I3C
> > > framework for inclusion in 4.20 (5.0?). A few more issues were reported
> > > on v9 and fixed in v10. I can't guarantee that the implementation is
> > > free of bugs but I still think it's worth merging it in v4.20: it's a
> > > new subsystem, so we don't risk regressions, and the only way we can
> > > detect other issues is by having other people experiment with this
> > > implementation.
> > >
> > > The only remaining concern raised by Arnd is the fact that both hosts
> > > and slaves share the same bus type and are differentiated thanks to
> > > their device_type, which IMHO is fine since this is what other
> > > subsystems do (plus I don't see other solutions to have both I3C
> > > devices and I3C buses represented under /sys/bus/i3c/).
> >
> > Yeah, it's not the nicest, but it will work, we did it also for USB and
> > greybus and it solves the issue.
> >
> > This all looks good to me, so I've queued it up. Let's see if
> > linux-next has any problems with it.
>
> I recently asked Stephen to add the linux-i3c tree to linux-next, so
> I'm expecting conflicts :-/. Sorry, I didn't know you were planning to
> take these patches through your tree.
>
> BTW, I also fixed a couple of things when rebasing on top of 4.20-rc1:
>
> - KernelVersion in the sysfs ABI doc has been updated to 5.0
There is no 5.0 yet :)
> - Fixed i3c_master_getmxds_locked() (bug reported/fixed by Colin here
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1799850.html)
> - Removed a blank line at the end of master-driver-api.rst
>
> For the record, the i3c/next branch pulled by Stephen is available here
> [1].
>
> > Thanks for sticking with it, nice work!
>
> Thanks for reviewing it! Greg, Stephen, let me know if you want me to
> reset i3c/next to v4.20-rc1 to avoid conflicts in linux-next.
So do you want me to just drop these patches from my tree? If so, I
can, but i have no problem sending these to Linus for the next -rc1
merge window through my tree if that is easier.
It's up to you.
greg k-h
next prev parent reply other threads:[~2018-11-11 19:10 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 14:43 [PATCH v10 0/9] Add the I3C subsystem Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 1/9] i3c: Add core I3C infrastructure Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 2/9] docs: driver-api: Add I3C documentation Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 3/9] i3c: Add sysfs ABI spec Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 4/9] dt-bindings: i3c: Document core bindings Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-30 19:26 ` Rob Herring
2018-10-26 14:43 ` [PATCH v10 5/9] MAINTAINERS: Add myself as the I3C subsystem maintainer Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 6/9] i3c: master: Add driver for Cadence IP Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 7/9] dt-bindings: i3c: Document Cadence I3C master bindings Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 8/9] gpio: Add a driver for Cadence I3C GPIO expander Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 14:43 ` [PATCH v10 9/9] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander Boris Brezillon
2018-10-26 14:43 ` Boris Brezillon
2018-10-26 15:22 ` [PATCH v10 0/9] Add the I3C subsystem vitor
2018-10-26 15:22 ` vitor
2018-10-26 16:15 ` Boris Brezillon
2018-10-26 16:15 ` Boris Brezillon
2018-10-26 16:20 ` vitor
2018-10-26 16:20 ` vitor
2018-10-26 16:30 ` Boris Brezillon
2018-10-26 16:30 ` Boris Brezillon
2018-10-26 16:18 ` Boris Brezillon
2018-10-26 16:18 ` Boris Brezillon
2018-11-11 17:39 ` Greg Kroah-Hartman
2018-11-11 17:39 ` Greg Kroah-Hartman
2018-11-11 18:10 ` Boris Brezillon
2018-11-11 18:10 ` Boris Brezillon
2018-11-11 19:10 ` Greg Kroah-Hartman [this message]
2018-11-11 19:10 ` Greg Kroah-Hartman
2018-11-11 20:08 ` Boris Brezillon
2018-11-11 20:08 ` Boris Brezillon
2018-11-11 20:57 ` Greg Kroah-Hartman
2018-11-11 20:57 ` Greg Kroah-Hartman
2018-11-11 20:59 ` Greg Kroah-Hartman
2018-11-11 20:59 ` Greg Kroah-Hartman
2018-11-15 12:14 ` vitor
2018-11-15 12:14 ` vitor
2018-11-15 12:57 ` Boris Brezillon
2018-11-15 12:57 ` Boris Brezillon
2018-11-15 14:25 ` Arnd Bergmann
2018-11-15 14:25 ` Arnd Bergmann
2018-11-15 15:25 ` vitor
2018-11-15 15:25 ` vitor
2018-11-15 19:07 ` Boris Brezillon
2018-11-15 19:07 ` Boris Brezillon
2018-11-15 15:01 ` Wolfram Sang
2018-11-15 15:01 ` Wolfram Sang
2018-11-15 15:11 ` Arnd Bergmann
2018-11-15 15:11 ` Arnd Bergmann
2018-11-15 15:28 ` Boris Brezillon
2018-11-15 15:28 ` Boris Brezillon
2018-11-15 18:03 ` vitor
2018-11-15 18:03 ` vitor
2018-11-15 19:00 ` Boris Brezillon
2018-11-15 19:00 ` Boris Brezillon
2018-11-16 12:31 ` vitor
2018-11-16 12:31 ` vitor
2018-11-16 12:50 ` Przemyslaw Gaj
2018-11-16 12:50 ` Przemyslaw Gaj
2018-11-16 13:16 ` Boris Brezillon
2018-11-16 13:16 ` Boris Brezillon
2018-11-19 12:35 ` vitor
2018-11-19 12:35 ` vitor
2018-11-19 12:43 ` Boris Brezillon
2018-11-19 12:43 ` Boris Brezillon
2018-11-19 12:46 ` vitor
2018-11-19 12:46 ` vitor
2018-11-15 15:18 ` vitor
2018-11-15 15:18 ` vitor
2018-11-15 19:08 ` Mark Brown
2018-11-15 19:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111191020.GA21003@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Vitor.Soares@synopsys.com \
--cc=Xiang.Lin@synaptics.com \
--cc=adouglas@cadence.com \
--cc=agolec@cadence.com \
--cc=alicja@cadence.com \
--cc=arnd@arndb.de \
--cc=bfolta@cadence.com \
--cc=boris.brezillon@bootlin.com \
--cc=corbet@lwn.net \
--cc=cwronka@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=dkos@cadence.com \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mshettel@codeaurora.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=peda@axentia.se \
--cc=pgaj@cadence.com \
--cc=psroka@cadence.com \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sureshp@cadence.com \
--cc=swboyd@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.