From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: whissi@gentoo.org, stable@vger.kernel.org, dsahern@gmail.com,
pupilla@libero.it
Subject: Re: stable request: net: sched: Remove TCA_OPTIONS from policy,stable request: net: sched: Remove TCA_OPTIONS from policy
Date: Sun, 11 Nov 2018 12:50:13 -0800 [thread overview]
Message-ID: <20181111205013.GA5213@kroah.com> (raw)
In-Reply-To: <20181110.134003.1813874858920783553.davem@davemloft.net>
On Sat, Nov 10, 2018 at 01:40:03PM -0800, David Miller wrote:
> From: Thomas Deutschmann <whissi@gentoo.org>
> Date: Sat, 10 Nov 2018 20:20:01 +0100
>
> > Hi,
> >
> > all stable kernels carrying
> >
> >> From 8b4c3cdd9dd8290343ce959a132d3b334062c5b9 Mon Sep 17 00:00:00 2001
> >> From: David Ahern <dsahern@gmail.com>
> >> Date: Wed, 3 Oct 2018 15:05:36 -0700
> >> Subject: [PATCH] net: sched: Add policy validation for tc attributes
> >>
> >> A number of TC attributes are processed without proper validation
> >> (e.g., length checks). Add a tca policy for all input attributes and use
> >> when invoking nlmsg_parse.
> >>
> >> The 2 Fixes tags below cover the latest additions. The other attributes
> >> are a string (KIND), nested attribute (OPTIONS which does seem to have
> >> validation in most cases), for dumps only or a flag.
> >>
> >> Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters")
> >> Fixes: d47a6b0e7c492 ("net: sched: introduce ingress/egress block index attributes for qdisc")
> >> Signed-off-by: David Ahern <dsahern@gmail.com>
> >> Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > should backport
> >
> >> From e72bde6b66299602087c8c2350d36a525e75d06e Mon Sep 17 00:00:00 2001
> >> From: David Ahern <dsahern@gmail.com>
> >> Date: Wed, 24 Oct 2018 08:32:49 -0700
> >> Subject: [PATCH] net: sched: Remove TCA_OPTIONS from policy
> >>
> >> Marco reported an error with hfsc:
> >> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> >> Error: Attribute failed policy validation.
> >>
> >> Apparently a few implementations pass TCA_OPTIONS as a binary instead
> >> of nested attribute, so drop TCA_OPTIONS from the policy.
> >>
> >> Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
> >> Reported-by: Marco Berizzi <pupilla@libero.it>
> >> Signed-off-by: David Ahern <dsahern@gmail.com>
> >> Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > See https://lkml.org/lkml/2018/10/26/80.
>
> Indeed, -stable folks please add this latter patch on top.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2018-11-12 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 19:20 stable request: net: sched: Remove TCA_OPTIONS from policy Thomas Deutschmann
2018-11-10 21:40 ` stable request: net: sched: Remove TCA_OPTIONS from policy,stable " David Miller
2018-11-11 20:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111205013.GA5213@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=pupilla@libero.it \
--cc=stable@vger.kernel.org \
--cc=whissi@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.