From: Johan Hovold <johan@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [-next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag'
Date: Mon, 12 Nov 2018 10:35:49 +0100 [thread overview]
Message-ID: <20181112093549.GD13311@localhost> (raw)
On Fri, Oct 26, 2018 at 08:25:49PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_interrupt_callback':
> drivers/usb/serial/mos7840.c:604:14: warning:
> variable 'st' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_write':
> drivers/usb/serial/mos7840.c:1303:17: warning:
> variable 'data1' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c:1700:11: warning:
> variable 'iflag' set but not used [-Wunused-but-set-variable]
>
> They are never used since introduction in
> commit 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag'
Date: Mon, 12 Nov 2018 10:35:49 +0100 [thread overview]
Message-ID: <20181112093549.GD13311@localhost> (raw)
In-Reply-To: <20181026122549.19036-1-yuehaibing@huawei.com>
On Fri, Oct 26, 2018 at 08:25:49PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_interrupt_callback':
> drivers/usb/serial/mos7840.c:604:14: warning:
> variable 'st' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_write':
> drivers/usb/serial/mos7840.c:1303:17: warning:
> variable 'data1' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c:1700:11: warning:
> variable 'iflag' set but not used [-Wunused-but-set-variable]
>
> They are never used since introduction in
> commit 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
Johan
next reply other threads:[~2018-11-12 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 9:35 Johan Hovold [this message]
2018-11-12 9:35 ` [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag' Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-10-26 12:25 [-next] " YueHaibing
2018-10-26 12:25 ` [PATCH -next] " YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112093549.GD13311@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.