From: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] qemu-arm: Enable VirtIO distro target
Date: Mon, 12 Nov 2018 20:53:09 +0200 [thread overview]
Message-ID: <20181112205309.0f9ad2ff@thinkpad> (raw)
In-Reply-To: <1542016748-15974-1-git-send-email-sumit.garg@linaro.org>
Hi Sumit,
On Mon, 12 Nov 2018 15:29:08 +0530
Sumit Garg <sumit.garg@linaro.org> wrote:
> With -device virtio-blk-device,drive=hd0, it could detect distro boot
> target.
>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
...
> diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
> index fedc466..437c3ae 100644
> --- a/include/configs/qemu-arm.h
> +++ b/include/configs/qemu-arm.h
> @@ -25,7 +25,8 @@
>
> #define BOOT_TARGET_DEVICES(func) \
> func(SCSI, scsi, 0) \
> - func(DHCP, dhcp, na)
> + func(DHCP, dhcp, na) \
> + func(VIRTIO, virtio, 0)
>
> #include <config_distro_bootcmd.h>
>
I think typically DHCP is the very last boot option since it can take
quite long to notice if there's no DHCP server on the network and fall
back to the next option. So perhaps an order of
SCSI; VIRTIO; DHCP
would be better.
Other than that, looks fine to me.
- Tuomas
next prev parent reply other threads:[~2018-11-12 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 9:59 [U-Boot] [PATCH] qemu-arm: Enable VirtIO distro target Sumit Garg
2018-11-12 18:53 ` Tuomas Tynkkynen [this message]
2018-11-13 4:44 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112205309.0f9ad2ff@thinkpad \
--to=tuomas.tynkkynen@iki.fi \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.