From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2 v2] mfd: ab8500-core: Return zero in get_register_interruptible()
Date: Tue, 13 Nov 2018 07:41:04 +0000 [thread overview]
Message-ID: <20181113074104.GD29388@dell> (raw)
In-Reply-To: <20181025124344.xw3phqnvrwq2nj7g@kili.mountain>
On Thu, 25 Oct 2018, Dan Carpenter wrote:
> This function is supposed to return zero on success or negative error
> codes on error. Unfortunately, there is a bug so it sometimes returns
> non-zero, positive numbers on success.
>
> I noticed this bug during review and I can't test it. It does appear
> that the return is sometimes propogated back to _regmap_read() where all
> non-zero returns are treated as failure so this may affect run time.
>
> Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: In v1, I introduced an new error path and forgot to drop the lock.
>
> drivers/mfd/ab8500-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v2] mfd: ab8500-core: Return zero in get_register_interruptible()
Date: Tue, 13 Nov 2018 07:41:04 +0000 [thread overview]
Message-ID: <20181113074104.GD29388@dell> (raw)
In-Reply-To: <20181025124344.xw3phqnvrwq2nj7g@kili.mountain>
On Thu, 25 Oct 2018, Dan Carpenter wrote:
> This function is supposed to return zero on success or negative error
> codes on error. Unfortunately, there is a bug so it sometimes returns
> non-zero, positive numbers on success.
>
> I noticed this bug during review and I can't test it. It does appear
> that the return is sometimes propogated back to _regmap_read() where all
> non-zero returns are treated as failure so this may affect run time.
>
> Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: In v1, I introduced an new error path and forgot to drop the lock.
>
> drivers/mfd/ab8500-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-11-13 7:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 8:05 [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible() Dan Carpenter
2018-10-18 8:05 ` Dan Carpenter
2018-10-18 8:05 ` Dan Carpenter
2018-10-25 8:25 ` Lee Jones
2018-10-25 8:25 ` Lee Jones
2018-10-25 8:25 ` Lee Jones
2018-10-25 8:46 ` Dan Carpenter
2018-10-25 8:46 ` Dan Carpenter
2018-10-25 8:46 ` Dan Carpenter
2018-10-25 10:10 ` Lee Jones
2018-10-25 10:10 ` Lee Jones
2018-10-25 10:10 ` Lee Jones
2018-10-25 12:43 ` [PATCH 2/2 v2] " Dan Carpenter
2018-10-25 12:43 ` Dan Carpenter
2018-10-26 8:30 ` Lee Jones
2018-10-26 8:30 ` Lee Jones
2018-10-31 13:35 ` Linus Walleij
2018-10-31 13:35 ` Linus Walleij
2018-11-13 7:41 ` Lee Jones [this message]
2018-11-13 7:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113074104.GD29388@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.