All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, broonie@kernel.org,
	linus.walleij@linaro.org, robh+dt@kernel.org,
	mark.rutland@arm.com, lgirdwood@gmail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com, linux-clk@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v4 3/6] mfd: lochnagar: Add initial binding documentation
Date: Tue, 13 Nov 2018 08:28:25 +0000	[thread overview]
Message-ID: <20181113082825.GB3513@dell> (raw)
In-Reply-To: <20181108101405.14062-4-ckeepax@opensource.cirrus.com>

On Thu, 08 Nov 2018, Charles Keepax wrote:

> Lochnagar is an evaluation and development board for Cirrus
> Logic Smart CODEC and Amp devices. It allows the connection of
> most Cirrus Logic devices on mini-cards, as well as allowing
> connection of various application processor systems to provide a
> full evaluation platform. This driver supports the board
> controller chip on the Lochnagar board.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> 
> I have dropped Rob and Stephen's Acks from this patch on
> account of the scale of the changes since v3.
> 
> Changes since v3:
>  - Split the binding up into separate parts for the individual subsystems
>  - Added documentation for the fixed clocks that are done through DT
> 
> Thanks,
> Charles
> 
>  .../devicetree/bindings/clock/cirrus,lochnagar.txt |  89 +++++++++++++
>  .../devicetree/bindings/mfd/cirrus,lochnagar.txt   |  70 ++++++++++

I think these should all be seperate patches.

Code looks okay to me though.

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2018-11-13  8:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 10:13 [PATCH v4 0/6] Lochnagar Driver Charles Keepax
2018-11-08 10:13 ` Charles Keepax
2018-11-08 10:14 ` [PATCH 1/6] regulator: lochnagar: Explicitly include register headers Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-08 10:14 ` [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-08 12:16   ` Mark Brown
2018-11-08 21:59     ` Charles Keepax
2018-11-08 21:59       ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 3/6] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-13  8:28   ` Lee Jones [this message]
2018-11-13 11:16     ` Charles Keepax
2018-11-13 11:16       ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 4/6] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-13  8:31   ` Lee Jones
2018-11-08 10:14 ` [PATCH v4 5/6] clk: " Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 6/6] pinctrl: " Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-15 10:54   ` Linus Walleij
2018-11-15 11:53     ` Charles Keepax
2018-11-15 11:53       ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113082825.GB3513@dell \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=patches@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.