All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <linus.walleij@linaro.org>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
	<linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT
Date: Thu, 8 Nov 2018 21:59:41 +0000	[thread overview]
Message-ID: <20181108215941.GU16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181108121629.GD6675@sirena.org.uk>

On Thu, Nov 08, 2018 at 12:16:29PM +0000, Mark Brown wrote:
> On Thu, Nov 08, 2018 at 10:14:01AM +0000, Charles Keepax wrote:
> 
> > +static const struct of_device_id lochnagar_of_match[] = {
> > +	{ .compatible = "cirrus,lochnagar-regulator" },
> > +	{},
> > +};
> 
> This is obviously just dumping the Linux driver model into the DT, the
> regulators are clearly different.  If you want to explicitly list the
> regulators in DT it'd be better to reflect the hardware and enumerate
> the regulators individually - you can use one driver for all the MICVDDs
> and a separate one for VDDCORE for example.

Agreed, would be relatively doable for regulators, might be a bit
verbose for the clock, but I really don't see how to handle
pinctrl.

I guess I will wait and see what the other maintainers think but
personally I would really be inclined to keep the binding the
same as the last version if we can.

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, mturquette@baylibre.com, sboyd@kernel.org,
	linus.walleij@linaro.org, robh+dt@kernel.org,
	mark.rutland@arm.com, lgirdwood@gmail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com, linux-clk@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT
Date: Thu, 8 Nov 2018 21:59:41 +0000	[thread overview]
Message-ID: <20181108215941.GU16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181108121629.GD6675@sirena.org.uk>

On Thu, Nov 08, 2018 at 12:16:29PM +0000, Mark Brown wrote:
> On Thu, Nov 08, 2018 at 10:14:01AM +0000, Charles Keepax wrote:
> 
> > +static const struct of_device_id lochnagar_of_match[] = {
> > +	{ .compatible = "cirrus,lochnagar-regulator" },
> > +	{},
> > +};
> 
> This is obviously just dumping the Linux driver model into the DT, the
> regulators are clearly different.  If you want to explicitly list the
> regulators in DT it'd be better to reflect the hardware and enumerate
> the regulators individually - you can use one driver for all the MICVDDs
> and a separate one for VDDCORE for example.

Agreed, would be relatively doable for regulators, might be a bit
verbose for the clock, but I really don't see how to handle
pinctrl.

I guess I will wait and see what the other maintainers think but
personally I would really be inclined to keep the binding the
same as the last version if we can.

Thanks,
Charles

  reply	other threads:[~2018-11-08 22:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 10:13 [PATCH v4 0/6] Lochnagar Driver Charles Keepax
2018-11-08 10:13 ` Charles Keepax
2018-11-08 10:14 ` [PATCH 1/6] regulator: lochnagar: Explicitly include register headers Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-08 10:14 ` [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-08 12:16   ` Mark Brown
2018-11-08 21:59     ` Charles Keepax [this message]
2018-11-08 21:59       ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 3/6] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-13  8:28   ` Lee Jones
2018-11-13 11:16     ` Charles Keepax
2018-11-13 11:16       ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 4/6] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-13  8:31   ` Lee Jones
2018-11-08 10:14 ` [PATCH v4 5/6] clk: " Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 6/6] pinctrl: " Charles Keepax
2018-11-08 10:14   ` Charles Keepax
2018-11-15 10:54   ` Linus Walleij
2018-11-15 11:53     ` Charles Keepax
2018-11-15 11:53       ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108215941.GU16508@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=patches@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.