All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks
Date: Tue, 13 Nov 2018 22:42:11 +0800	[thread overview]
Message-ID: <20181113144209.GB4557@dragon> (raw)
In-Reply-To: <20181105091230.z2ooz7olbdpopxyd@viti.kaiser.cx>

On Mon, Nov 05, 2018 at 10:12:30AM +0100, Martin Kaiser wrote:
> Hi,
> 
> Thus wrote Shawn Guo (shawnguo at kernel.org):
> 
> > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
> > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
> > > function blocks. Add their ipg and per clocks to the device tree.
> 
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> 
> > Are these EPIT devices actually used in upstream kernel, or just
> > somewhere else?
> 
> Until I saw Vladimir's mail this morning, I wasn't aware of any mainline
> driver that's using the EPIT devices. I found that the clocks are
> missing when I tried to use EPIT with a company-internal driver that's
> not suitable for mainline integration.
> 
> Still, I think that merging this patch does no harm. If the EPIT devices
> are present in the DT, we should add all resources they're using.

Agreed.  I will be happy to apply the patch if I can get an ACK from
Cl?ment saying this works with his driver in upstreaming.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: "Sascha Hauer" <s.hauer@pengutronix.de>,
	"Clément Péron" <peron.clem@gmail.com>,
	"Vladimir Zapolskiy" <vladimir_zapolskiy@mentor.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks
Date: Tue, 13 Nov 2018 22:42:11 +0800	[thread overview]
Message-ID: <20181113144209.GB4557@dragon> (raw)
In-Reply-To: <20181105091230.z2ooz7olbdpopxyd@viti.kaiser.cx>

On Mon, Nov 05, 2018 at 10:12:30AM +0100, Martin Kaiser wrote:
> Hi,
> 
> Thus wrote Shawn Guo (shawnguo@kernel.org):
> 
> > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
> > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
> > > function blocks. Add their ipg and per clocks to the device tree.
> 
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> 
> > Are these EPIT devices actually used in upstream kernel, or just
> > somewhere else?
> 
> Until I saw Vladimir's mail this morning, I wasn't aware of any mainline
> driver that's using the EPIT devices. I found that the clocks are
> missing when I tried to use EPIT with a company-internal driver that's
> not suitable for mainline integration.
> 
> Still, I think that merging this patch does no harm. If the EPIT devices
> are present in the DT, we should add all resources they're using.

Agreed.  I will be happy to apply the patch if I can get an ACK from
Clément saying this works with his driver in upstreaming.

Shawn

  reply	other threads:[~2018-11-13 14:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 17:32 [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks Martin Kaiser
2018-11-01 17:32 ` Martin Kaiser
2018-11-01 17:32 ` Martin Kaiser
2018-11-01 21:19 ` Vladimir Zapolskiy
2018-11-01 21:19   ` Vladimir Zapolskiy
2018-11-04 14:46 ` Shawn Guo
2018-11-04 14:46   ` Shawn Guo
2018-11-05  8:58   ` Vladimir Zapolskiy
2018-11-05  8:58     ` Vladimir Zapolskiy
2018-11-05  8:58     ` Vladimir Zapolskiy
2018-11-05 13:55     ` Clément Péron
2018-11-05 13:55       ` Clément Péron
2018-11-05  9:12   ` Martin Kaiser
2018-11-05  9:12     ` Martin Kaiser
2018-11-13 14:42     ` Shawn Guo [this message]
2018-11-13 14:42       ` Shawn Guo
2018-11-13 14:59       ` Clément Péron
2018-11-13 14:59         ` Clément Péron
2018-11-14  3:04 ` Shawn Guo
2018-11-14  3:04   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113144209.GB4557@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.