From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Struk, Tadeusz" <tadeusz.struk@intel.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>, Jason Gunthorpe <jgg@ziepe.ca>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 00/17] Removed nested TPM operations
Date: Tue, 13 Nov 2018 18:55:19 +0200 [thread overview]
Message-ID: <20181113165519.GA4752@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9DA1CD09@hasmsx108.ger.corp.intel.com>
On Tue, Nov 13, 2018 at 12:30:55PM +0000, Winkler, Tomas wrote:
> >
> > [was Detach TPM space code out of the tpm_transmit() flow but the scope
> > expanded a bit.]
>
> I believe you making this series artificially large we can merge the
> first 4 patches and leave the rest for further discussion.
1/17, 2/17 and 3/17 are fairly obvious changes but they still should
have tested-by's. For 4/17 I need a sanity check from James Bottomley
that I'm not forgetting some tidbit of TPM space implementation (has
been while since I've worked on it so better to have 2nd eyes there).
I think also 5/17, 7/17 and 10/17 could be merged.
I can reposition forementioned patches so that they are in the head of
the series.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 00/17] Removed nested TPM operations
Date: Tue, 13 Nov 2018 18:55:19 +0200 [thread overview]
Message-ID: <20181113165519.GA4752@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9DA1CD09@hasmsx108.ger.corp.intel.com>
On Tue, Nov 13, 2018 at 12:30:55PM +0000, Winkler, Tomas wrote:
> >
> > [was Detach TPM space code out of the tpm_transmit() flow but the scope
> > expanded a bit.]
>
> I believe you making this series artificially large we can merge the
> first 4 patches and leave the rest for further discussion.
1/17, 2/17 and 3/17 are fairly obvious changes but they still should
have tested-by's. For 4/17 I need a sanity check from James Bottomley
that I'm not forgetting some tidbit of TPM space implementation (has
been while since I've worked on it so better to have 2nd eyes there).
I think also 5/17, 7/17 and 10/17 could be merged.
I can reposition forementioned patches so that they are in the head of
the series.
/Jarkko
next prev parent reply other threads:[~2018-11-13 16:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 12:25 [PATCH v6 00/17] Removed nested TPM operations Jarkko Sakkinen
2018-11-13 12:25 ` Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 01/17] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 02/17] tpm: fix invalid return value in pubek_show() Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 03/17] tpm: return 0 from pcrs_show() when tpm1_pcr_read() fails Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 04/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit() Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 05/17] tpm: print tpm2_commit_space() error inside tpm2_commit_space() Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 06/17] tpm: clean up tpm_try_transmit() error handling flow Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 07/17] tpm: declare struct tpm_header Jarkko Sakkinen
2018-11-13 12:25 ` Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 08/17] tpm: access command header through struct in tpm_try_transmit() Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 09/17] tpm: move tpm_validate_commmand() to tpm2-space.c Jarkko Sakkinen
2018-11-13 12:25 ` [PATCH v6 10/17] tpm: encapsulate tpm_dev_transmit() Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 11/17] tpm: move TPM space code out of tpm_transmit() Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 12/17] tpm: remove @space from tpm_transmit() Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 13/17] tpm: use tpm_try_get_ops() in tpm-sysfs.c Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop() Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 16/17] tpm: take TPM chip power gating out of tpm_transmit() Jarkko Sakkinen
2018-11-13 12:26 ` [PATCH v6 17/17] tpm: remove @flags from tpm_transmit() Jarkko Sakkinen
2018-11-13 12:30 ` [PATCH v6 00/17] Removed nested TPM operations Winkler, Tomas
2018-11-13 12:30 ` Winkler, Tomas
2018-11-13 16:55 ` Jarkko Sakkinen [this message]
2018-11-13 16:55 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113165519.GA4752@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tadeusz.struk@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.