From: Nasser Afshin <afshin.nasser@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/3] test-pkg: Use the correct config prefix when merging
Date: Wed, 14 Nov 2018 12:34:47 +0330 [thread overview]
Message-ID: <20181114090447.GC12239@smart-All-Series> (raw)
In-Reply-To: <bfcad053-5720-84af-1530-b188056f7fd0@mind.be>
Hi Arnout,
On Wed, Nov 14, 2018 at 09:24:32AM +0100, Arnout Vandecappelle wrote:
> Hi Nasser,
>
> Two remarks for your future contributions.
>
> On 14/11/2018 08:49, Nasser Afshin wrote:
> > Hi Petr
> > On Wed, Nov 14, 2018 at 08:17:33AM +0100, Petr Vorel wrote:
> >> Hi Nasser,
> >>
> >>> From: Nasser Afshin <Afshin.Nasser@gmail.com>
> >>
> >>> We should use an empty prefix as we do not have any prefix.
> >>> Note that BR2_ is mere a convention.
> >>
> >>> Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
>
> When you send a v2 or later, please include a patch changelog, like so:
>
> ---
> v2: remove quotes from the empty CONFIG_ assignment (suggested by Peter Vorel)
>
>
> The --- splits the commit message from additional notes that won't be included
> when the patch is applied.
>
I thought it's a tiny change. You're right I should have included the
changelog anyway.
> >> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> > Sorry I forgot to mention that. Resent.
>
> There is no need to resend for that: patchwork will include it automatically.
Ok. Thank you for reviewing my patch and sending your tips.
Sorry for being a novice.
>
>
> Regards,
> Arnout
>
> >>> ---
> >>> utils/test-pkg | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>> diff --git a/utils/test-pkg b/utils/test-pkg
> >>> index aa91ee02cf..e4f68ed061 100755
> >>> --- a/utils/test-pkg
> >>> +++ b/utils/test-pkg
> >>> @@ -129,7 +129,7 @@ build_one() {
> >>
> >>> mkdir -p "${dir}"
> >>
> >>> - support/kconfig/merge_config.sh -O "${dir}" \
> >>> + CONFIG_= support/kconfig/merge_config.sh -O "${dir}" \
> >> Thanks for a change.
> >>
> >>
> >> Kind regards,
> >> Petr
> > Kind regards,
> > Nasser
> >
Kind regards,
Nasser
next prev parent reply other threads:[~2018-11-14 9:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 7:11 [Buildroot] [PATCH v3 0/3] Fix merging configuration fragments Nasser Afshin
2018-11-14 7:11 ` [Buildroot] [PATCH v3 1/3] merge_config.sh: Fix merging buildroot config files Nasser Afshin
2018-11-23 21:14 ` Yann E. MORIN
2018-11-24 9:12 ` Thomas Petazzoni
2018-11-14 7:11 ` [Buildroot] [PATCH v3 2/3] test-pkg: Use the correct config prefix when merging Nasser Afshin
2018-11-14 7:17 ` Petr Vorel
2018-11-14 7:49 ` Nasser Afshin
2018-11-14 8:24 ` Arnout Vandecappelle
2018-11-14 8:29 ` Petr Vorel
2018-11-14 8:55 ` Nasser Afshin
2018-11-14 9:04 ` Nasser Afshin [this message]
2018-11-14 7:11 ` [Buildroot] [PATCH v3 3/3] merge_config.sh: Avoid false positive matches from comment lines Nasser Afshin
2018-11-23 21:16 ` Yann E. MORIN
2018-11-24 9:12 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2018-11-05 8:35 [Buildroot] [PATCH] merge_config.sh: Fix merging buildroot config files Petr Vorel
2018-11-13 13:44 ` [Buildroot] [PATCH v3 0/3] Fix merging configuration fragments Nasser Afshin
2018-11-13 13:44 ` [Buildroot] [PATCH v3 2/3] test-pkg: Use the correct config prefix when merging Nasser Afshin
2018-11-13 18:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114090447.GC12239@smart-All-Series \
--to=afshin.nasser@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.