From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: lijie <lijie34@huawei.com>,
shenhong09@huawei.com, xose.vazquez@gmail.com,
chengjike.cheng@huawei.com, linux-nvme@lists.infradead.org,
Keith Busch <keith.busch@intel.com>,
dm-devel@redhat.com, wangzhoumengjian@huawei.com,
Martin Wilck <mwilck@suse.com>,
sschremm@netapp.com
Subject: Re: multipath-tools: add ANA support for NVMe device
Date: Wed, 14 Nov 2018 11:16:45 -0500 [thread overview]
Message-ID: <20181114161645.GA18207@redhat.com> (raw)
In-Reply-To: <20181114153544.GA28758@lst.de>
On Wed, Nov 14 2018 at 10:35am -0500,
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Nov 14, 2018 at 08:24:05AM +0100, Hannes Reinecke wrote:
> > My argument here is that _ANA_ support should not be tied to the NVME
> > native multipathing at all.
>
> It should. Because nvme driver multipathing is the only sanctioned
> way to use it. All other ways aren't supported and might break at
> any time.
Quite a few of us who are multipath-tools oriented would like the proper
separation rather than your more pragmatic isolated approach. And we'd
fix it if it broke in the future.
> > So personally I don't see why the 'raw' ANA support (parsing log pages,
> > figuring out path states etc) needs to be tied in with native NVMe
> > multipathing. _Especially_ not as my patch really is trivial.
>
> And not actually usable for anything.. They only thing you do is to
> increase the code size for embedded nvme users that don't need any
> multipathing.
Isn't that why CONFIG_NVME_MULTIPATH exists? Embedded nvme users
wouldn't set that.
WARNING: multiple messages have this Message-ID (diff)
From: snitzer@redhat.com (Mike Snitzer)
Subject: multipath-tools: add ANA support for NVMe device
Date: Wed, 14 Nov 2018 11:16:45 -0500 [thread overview]
Message-ID: <20181114161645.GA18207@redhat.com> (raw)
In-Reply-To: <20181114153544.GA28758@lst.de>
On Wed, Nov 14 2018 at 10:35am -0500,
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Nov 14, 2018@08:24:05AM +0100, Hannes Reinecke wrote:
> > My argument here is that _ANA_ support should not be tied to the NVME
> > native multipathing at all.
>
> It should. Because nvme driver multipathing is the only sanctioned
> way to use it. All other ways aren't supported and might break at
> any time.
Quite a few of us who are multipath-tools oriented would like the proper
separation rather than your more pragmatic isolated approach. And we'd
fix it if it broke in the future.
> > So personally I don't see why the 'raw' ANA support (parsing log pages,
> > figuring out path states etc) needs to be tied in with native NVMe
> > multipathing. _Especially_ not as my patch really is trivial.
>
> And not actually usable for anything.. They only thing you do is to
> increase the code size for embedded nvme users that don't need any
> multipathing.
Isn't that why CONFIG_NVME_MULTIPATH exists? Embedded nvme users
wouldn't set that.
next prev parent reply other threads:[~2018-11-14 16:16 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 6:09 [PATCH] multipath-tools: add ANA support for NVMe device lijie
2018-11-12 16:23 ` Martin Wilck
2018-11-12 21:53 ` Mike Snitzer
2018-11-12 21:53 ` Mike Snitzer
2018-11-13 6:59 ` Martin Wilck
2018-11-13 6:59 ` Martin Wilck
2018-11-13 16:18 ` Keith Busch
2018-11-13 16:18 ` Keith Busch
2018-11-13 18:00 ` Mike Snitzer
2018-11-13 18:00 ` Mike Snitzer
2018-11-14 5:38 ` Mike Snitzer
2018-11-14 5:38 ` Mike Snitzer
2018-11-14 7:49 ` Hannes Reinecke
2018-11-14 7:49 ` Hannes Reinecke
2018-11-14 10:36 ` [dm-devel] " Martin Wilck
2018-11-14 10:36 ` Martin Wilck
2018-11-14 17:47 ` Mike Snitzer
2018-11-14 17:47 ` Mike Snitzer
2018-11-14 18:51 ` Hannes Reinecke
2018-11-14 18:51 ` Hannes Reinecke
2018-11-14 19:26 ` Mike Snitzer
2018-11-14 19:26 ` Mike Snitzer
2018-11-15 17:46 ` [PATCH] nvme: allow ANA support to be independent of native multipathing Mike Snitzer
2018-11-15 17:46 ` Mike Snitzer
2018-11-16 7:25 ` Hannes Reinecke
2018-11-16 7:25 ` Hannes Reinecke
2018-11-16 14:01 ` Mike Snitzer
2018-11-16 14:01 ` Mike Snitzer
2018-11-16 9:14 ` [PATCH] " Christoph Hellwig
2018-11-16 9:14 ` Christoph Hellwig
2018-11-16 9:40 ` Hannes Reinecke
2018-11-16 9:40 ` Hannes Reinecke
2018-11-16 9:49 ` Christoph Hellwig
2018-11-16 9:49 ` Christoph Hellwig
2018-11-16 10:06 ` Hannes Reinecke
2018-11-16 10:06 ` Hannes Reinecke
2018-11-16 10:17 ` Christoph Hellwig
2018-11-16 10:17 ` Christoph Hellwig
2018-11-16 19:28 ` Mike Snitzer
2018-11-16 19:28 ` Mike Snitzer
2018-11-16 19:34 ` Laurence Oberman
2018-11-16 19:34 ` Laurence Oberman
2018-11-19 9:39 ` Christoph Hellwig
2018-11-19 9:39 ` Christoph Hellwig
2018-11-19 14:56 ` Mike Snitzer
2018-11-19 14:56 ` Mike Snitzer
2018-11-19 14:56 ` Mike Snitzer
2018-11-20 9:42 ` Christoph Hellwig
2018-11-20 9:42 ` Christoph Hellwig
2018-11-20 13:37 ` Mike Snitzer
2018-11-20 13:37 ` Mike Snitzer
2018-11-20 16:23 ` Christoph Hellwig
2018-11-20 16:23 ` Christoph Hellwig
2018-11-16 14:12 ` Mike Snitzer
2018-11-16 14:12 ` Mike Snitzer
2018-11-16 18:59 ` [PATCH v2] " Mike Snitzer
2018-11-16 18:59 ` Mike Snitzer
2018-11-14 7:24 ` multipath-tools: add ANA support for NVMe device Hannes Reinecke
2018-11-14 7:24 ` Hannes Reinecke
2018-11-14 15:35 ` Christoph Hellwig
2018-11-14 15:35 ` Christoph Hellwig
2018-11-14 16:16 ` Mike Snitzer [this message]
2018-11-14 16:16 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114161645.GA18207@redhat.com \
--to=snitzer@redhat.com \
--cc=chengjike.cheng@huawei.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=lijie34@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=shenhong09@huawei.com \
--cc=sschremm@netapp.com \
--cc=wangzhoumengjian@huawei.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.