From: Barret Rhoden <brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: "Dan Williams"
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Dave Jiang" <dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Ross Zwisler" <zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Vishal Verma"
<vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Paolo Bonzini"
<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Radim Krčmář" <rkrcmar-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Ingo Molnar" <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Borislav Petkov" <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yu.c.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
yi.z.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: [PATCH v2 3/3] kvm: remove redundant PageReserved() check
Date: Wed, 14 Nov 2018 16:51:55 -0500 [thread overview]
Message-ID: <20181114215155.259978-4-brho@google.com> (raw)
In-Reply-To: <20181114215155.259978-1-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
kvm_is_reserved_pfn() already checks PageReserved().
Signed-off-by: Barret Rhoden <brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
---
virt/kvm/kvm_main.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 2679e476b6c3..e0ea6d7dac14 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1700,12 +1700,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty);
void kvm_set_pfn_dirty(kvm_pfn_t pfn)
{
- if (!kvm_is_reserved_pfn(pfn)) {
- struct page *page = pfn_to_page(pfn);
-
- if (!PageReserved(page))
- SetPageDirty(page);
- }
+ if (!kvm_is_reserved_pfn(pfn))
+ SetPageDirty(pfn_to_page(pfn));
}
EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
--
2.19.1.1215.g8438c0b245-goog
WARNING: multiple messages have this Message-ID (diff)
From: Barret Rhoden <brho@google.com>
To: "Dan Williams" <dan.j.williams@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ross Zwisler" <zwisler@kernel.org>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org, yu.c.zhang@intel.com,
yi.z.zhang@intel.com
Subject: [PATCH v2 3/3] kvm: remove redundant PageReserved() check
Date: Wed, 14 Nov 2018 16:51:55 -0500 [thread overview]
Message-ID: <20181114215155.259978-4-brho@google.com> (raw)
In-Reply-To: <20181114215155.259978-1-brho@google.com>
kvm_is_reserved_pfn() already checks PageReserved().
Signed-off-by: Barret Rhoden <brho@google.com>
---
virt/kvm/kvm_main.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 2679e476b6c3..e0ea6d7dac14 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1700,12 +1700,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty);
void kvm_set_pfn_dirty(kvm_pfn_t pfn)
{
- if (!kvm_is_reserved_pfn(pfn)) {
- struct page *page = pfn_to_page(pfn);
-
- if (!PageReserved(page))
- SetPageDirty(page);
- }
+ if (!kvm_is_reserved_pfn(pfn))
+ SetPageDirty(pfn_to_page(pfn));
}
EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
--
2.19.1.1215.g8438c0b245-goog
next prev parent reply other threads:[~2018-11-14 21:51 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 20:39 [PATCH 0/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-11-09 20:39 ` [PATCH 1/2] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2018-11-13 9:28 ` David Hildenbrand
2018-11-13 9:28 ` David Hildenbrand
2018-11-13 9:28 ` David Hildenbrand
2018-11-09 20:39 ` [PATCH 2/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-11-12 19:31 ` Paolo Bonzini
2018-11-12 19:31 ` Paolo Bonzini
[not found] ` <861c4adb-e2f0-2caf-8f6e-9f09ecb0b624-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-13 16:21 ` Barret Rhoden
2018-11-13 16:21 ` Barret Rhoden
2018-11-13 18:22 ` Paolo Bonzini
2018-11-13 18:22 ` Paolo Bonzini
2018-11-13 9:36 ` David Hildenbrand
2018-11-13 9:36 ` David Hildenbrand
2018-11-13 9:36 ` David Hildenbrand
2018-11-13 10:02 ` Pankaj Gupta
2018-11-13 10:02 ` Pankaj Gupta
2018-11-13 10:02 ` Pankaj Gupta
2018-11-13 12:41 ` Paolo Bonzini
[not found] ` <286665658.33247363.1542103353780.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-13 15:56 ` Barret Rhoden
2018-11-13 15:56 ` Barret Rhoden
2018-11-14 9:09 ` Pankaj Gupta
2018-11-14 9:09 ` Pankaj Gupta
[not found] ` <043a592d-6592-3053-15a0-68cc54a26deb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-13 15:50 ` Barret Rhoden
2018-11-13 15:50 ` Barret Rhoden
[not found] ` <20181109203921.178363-1-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-11-14 21:51 ` [PATCH v2 0/3] " Barret Rhoden
2018-11-14 21:51 ` Barret Rhoden
2018-11-14 21:51 ` [PATCH v2 1/3] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2018-11-14 21:51 ` Barret Rhoden
2018-11-14 21:51 ` Barret Rhoden
2018-11-26 16:50 ` Paolo Bonzini
2018-11-26 18:32 ` Dan Williams
2018-11-26 18:32 ` Dan Williams
[not found] ` <20181114215155.259978-1-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-11-14 21:51 ` [PATCH v2 2/3] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-11-14 21:51 ` Barret Rhoden
2018-11-14 21:51 ` Barret Rhoden [this message]
2018-11-14 21:51 ` [PATCH v2 3/3] kvm: remove redundant PageReserved() check Barret Rhoden
2018-11-27 13:31 ` David Hildenbrand
2018-11-27 13:31 ` David Hildenbrand
2018-11-15 0:55 ` [PATCH v2 0/3] kvm: Use huge pages for DAX-backed files Dan Williams
2018-11-15 0:55 ` Dan Williams
2018-12-03 17:40 ` Barret Rhoden
2018-12-03 18:32 ` Alexander Duyck
2018-12-03 18:32 ` Alexander Duyck
2018-12-03 18:32 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114215155.259978-4-brho@google.com \
--to=brho-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=rkrcmar-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yi.z.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yu.c.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.