All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: devicetree@vger.kernel.org, sboyd@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org,
	dianders@chromium.org, ath10k@lists.infradead.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	andy.gross@linaro.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node
Date: Wed, 14 Nov 2018 18:26:53 -0800	[thread overview]
Message-ID: <20181115022652.GA205124@google.com> (raw)
In-Reply-To: <1541423318-19312-3-git-send-email-govinds@codeaurora.org>

Hi Govind,

On Mon, Nov 05, 2018 at 06:38:37PM +0530, Govind Singh wrote:
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on SDM845 soc.
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Tested-by: Brian Norris <briannorris@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  8 ++++++++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi    | 26 ++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index eedfaf8..c062c5c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -440,3 +440,11 @@
>  		bias-pull-up;
>  	};
>  };
> +
> +&wifi {
> +	status = "okay";
> +	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
> +	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> +	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> +	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> +};

This node should be above the PINCTRL section.

Brian

> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index b72bdb0..324be5b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -87,6 +87,11 @@
>  			reg = <0 0x86200000 0 0x2d00000>;
>  			no-map;
>  		};
> +
> +		wlan_msa_mem: memory@96700000 {
> +			reg = <0 0x96700000 0 0x100000>;
> +			no-map;
> +		};
>  	};
>  
>  	cpus {
> @@ -1403,5 +1408,26 @@
>  				status = "disabled";
>  			};
>  		};
> +
> +		wifi: wifi@18800000 {
> +			compatible = "qcom,wcn3990-wifi";
> +			status = "disabled";
> +			reg = <0x18800000 0x800000>;
> +			reg-names = "membase";
> +			memory-region = <&wlan_msa_mem>;
> +			interrupts =
> +				<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> +		};
>  	};
>  };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: andy.gross@linaro.org, ath10k@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, linux-wireless@vger.kernel.org,
	robh+dt@kernel.org, sboyd@kernel.org, dianders@chromium.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node
Date: Wed, 14 Nov 2018 18:26:53 -0800	[thread overview]
Message-ID: <20181115022652.GA205124@google.com> (raw)
In-Reply-To: <1541423318-19312-3-git-send-email-govinds@codeaurora.org>

Hi Govind,

On Mon, Nov 05, 2018 at 06:38:37PM +0530, Govind Singh wrote:
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on SDM845 soc.
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Tested-by: Brian Norris <briannorris@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  8 ++++++++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi    | 26 ++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index eedfaf8..c062c5c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -440,3 +440,11 @@
>  		bias-pull-up;
>  	};
>  };
> +
> +&wifi {
> +	status = "okay";
> +	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
> +	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> +	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> +	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> +};

This node should be above the PINCTRL section.

Brian

> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index b72bdb0..324be5b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -87,6 +87,11 @@
>  			reg = <0 0x86200000 0 0x2d00000>;
>  			no-map;
>  		};
> +
> +		wlan_msa_mem: memory@96700000 {
> +			reg = <0 0x96700000 0 0x100000>;
> +			no-map;
> +		};
>  	};
>  
>  	cpus {
> @@ -1403,5 +1408,26 @@
>  				status = "disabled";
>  			};
>  		};
> +
> +		wifi: wifi@18800000 {
> +			compatible = "qcom,wcn3990-wifi";
> +			status = "disabled";
> +			reg = <0x18800000 0x800000>;
> +			reg-names = "membase";
> +			memory-region = <&wlan_msa_mem>;
> +			interrupts =
> +				<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> +		};
>  	};
>  };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2018-11-15  2:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 13:08 [PATCH v4 0/3] Enable ath10k wcn3990 wifi driver support on sdm845 Govind Singh
2018-11-05 13:08 ` Govind Singh
2018-11-05 13:08 ` Govind Singh
2018-11-05 13:08 ` [PATCH v4 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node Govind Singh
2018-11-05 13:08   ` Govind Singh
2018-11-05 13:08   ` Govind Singh
     [not found]   ` <1541423318-19312-2-git-send-email-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-12-20 17:08     ` Kalle Valo
2018-12-20 17:08       ` Kalle Valo
2018-12-20 17:08   ` Kalle Valo
2018-12-20 17:08     ` Kalle Valo
2018-12-20 17:08   ` Kalle Valo
2018-11-05 13:08 ` [PATCH v4 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node Govind Singh
2018-11-05 13:08   ` Govind Singh
2018-11-15  2:26   ` Brian Norris [this message]
2018-11-15  2:26     ` Brian Norris
2018-11-05 13:08 ` [PATCH v4 3/3] dt: bindings: add bindings for wifi iommu node Govind Singh
2018-11-05 13:08   ` Govind Singh
2018-11-05 13:08   ` Govind Singh
2018-11-16 13:29 ` [PATCH v4 0/3] Enable ath10k wcn3990 wifi driver support on sdm845 Kalle Valo
2018-11-16 13:29   ` Kalle Valo
2018-11-16 13:29   ` Kalle Valo
2018-11-16 16:06   ` Govind Singh
2018-11-16 16:06     ` Govind Singh
2018-11-17 11:09     ` Kalle Valo
2018-11-17 11:09       ` Kalle Valo
2018-11-17 11:09       ` Kalle Valo
2018-12-19 15:41       ` Govind Singh
2018-12-19 15:41         ` Govind Singh
2018-12-20 11:58         ` Kalle Valo
2018-12-20 11:58           ` Kalle Valo
2018-12-20 13:18           ` Kalle Valo
2018-12-20 13:18             ` Kalle Valo
2018-12-20 13:24             ` Govind Singh
2018-12-20 13:24               ` Govind Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115022652.GA205124@google.com \
    --to=briannorris@chromium.org \
    --cc=andy.gross@linaro.org \
    --cc=ath10k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=govinds@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.