All of lore.kernel.org
 help / color / mirror / Atom feed
From: martin.jansa@gmail.com (Martin Jansa)
To: linux-snps-arc@lists.infradead.org
Subject: [OE-core] [PATCH] u-boot: Add mkenvimage tool
Date: Thu, 15 Nov 2018 10:27:58 +0100	[thread overview]
Message-ID: <20181115092758.GA1430@jama> (raw)
In-Reply-To: <804b3db998a4d9efa0e9f8f649ea9741274be094.camel@synopsys.com>

On Thu, Nov 15, 2018@05:15:03AM +0000, Alexey Brodkin wrote:
> Hi Marek,
> 
> On Thu, 2018-11-15@06:03 +0100, Marek Vasut wrote:
> > On 11/15/2018 05:57 AM, Khem Raj wrote:
> > > On Wed, Nov 14, 2018 at 8:00 PM Alexey Brodkin
> > > <alexey.brodkin@synopsys.com> wrote:
> > > > This utility is used for creation of images containing
> > > > usable in run-time U-Boot environment.
> > > > 
> > > > As of today this utility is added per-board like here [1]
> > > > for Intel Edison board, here [2] for Altera's SoCFPGA and
> > > > I may guess there're others so instead of adding another one for
> > > > ARC why don't we package it for each and everyone.
> > > > 
> > > > [1] 
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__git.yoctoproject.org_cgit_cgit.cgi_meta-2Dintel-2Dedison_tree_meta-2Dintel-2Dedison-2Dbsp_recipes-2Dbsp_u-2Dboot_u-2Dboot-2Dtools-5F2014.04.bb&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=cK5urAA7P2ER1AvKZdD3CEL5r23DwdtJ4Iohy_QCUSQ&s=VyVOHq5I3FsOXvOf7SQgVlwtTfKX0bN5ZmPPehjD-zw&e=
> > > > [2] 
> > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kraj_meta-2Daltera_blob_master_recipes-2Dbsp_u-2Dboot_u-2Dboot-2Dmkenvimage-5Fv2016.11.bb&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=cK5urAA7P2ER1AvKZdD3CEL5r23DwdtJ4Iohy_QCUSQ&s=TDPtpmofctGuP4dejRGli0SBUReQQPoiFQsWPHs4vV8&e=
> > > 
> > > If this is applicable/works for all u-boot based machines then I think it makes
> > > sense to have it on OE-core.
> > 
> > It is.
> > 
> > > > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > > > Cc: Alexander Kanavin <alexander.kanavin at linux.intel.com>
> > > > Cc: Richard Purdie <richard.purdie at linuxfoundation.org>
> > > > Cc: Otavio Salvador <otavio at ossystems.com.br>
> > > > Cc: Ross Burton <ross.burton at intel.com>
> > > > Cc: Marek Vasut <marex at denx.de>
> > 
> > Reviewed-by: Marek Vasut <marex at denx.de>
> > 
> > That said, could the recipe for mkimage and mkenvimage be somehow
> > deduplicated ? There seems to be a lot of common stuff.
> 
> I'd say why don't we just have one recipe for all U-Boot tools
> instead of adding tools one-by-one?

Or add:
    install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
    ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage

to existing u-boot-mkimage recipe, that's what I'm doing in
u-boot-mkimage bbappend.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-snps-arc/attachments/20181115/be90134e/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Martin Jansa <martin.jansa@gmail.com>
To: Alexey Brodkin <alexey.brodkin@synopsys.com>
Cc: "marex@denx.de" <marex@denx.de>,
	"linux-snps-arc@lists.infradead.org"
	<linux-snps-arc@lists.infradead.org>,
	"otavio@ossystems.com.br" <otavio@ossystems.com.br>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] u-boot: Add mkenvimage tool
Date: Thu, 15 Nov 2018 10:27:58 +0100	[thread overview]
Message-ID: <20181115092758.GA1430@jama> (raw)
In-Reply-To: <804b3db998a4d9efa0e9f8f649ea9741274be094.camel@synopsys.com>

[-- Attachment #1: Type: text/plain, Size: 2507 bytes --]

On Thu, Nov 15, 2018 at 05:15:03AM +0000, Alexey Brodkin wrote:
> Hi Marek,
> 
> On Thu, 2018-11-15 at 06:03 +0100, Marek Vasut wrote:
> > On 11/15/2018 05:57 AM, Khem Raj wrote:
> > > On Wed, Nov 14, 2018 at 8:00 PM Alexey Brodkin
> > > <alexey.brodkin@synopsys.com> wrote:
> > > > This utility is used for creation of images containing
> > > > usable in run-time U-Boot environment.
> > > > 
> > > > As of today this utility is added per-board like here [1]
> > > > for Intel Edison board, here [2] for Altera's SoCFPGA and
> > > > I may guess there're others so instead of adding another one for
> > > > ARC why don't we package it for each and everyone.
> > > > 
> > > > [1] 
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__git.yoctoproject.org_cgit_cgit.cgi_meta-2Dintel-2Dedison_tree_meta-2Dintel-2Dedison-2Dbsp_recipes-2Dbsp_u-2Dboot_u-2Dboot-2Dtools-5F2014.04.bb&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=cK5urAA7P2ER1AvKZdD3CEL5r23DwdtJ4Iohy_QCUSQ&s=VyVOHq5I3FsOXvOf7SQgVlwtTfKX0bN5ZmPPehjD-zw&e=
> > > > [2] 
> > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kraj_meta-2Daltera_blob_master_recipes-2Dbsp_u-2Dboot_u-2Dboot-2Dmkenvimage-5Fv2016.11.bb&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=cK5urAA7P2ER1AvKZdD3CEL5r23DwdtJ4Iohy_QCUSQ&s=TDPtpmofctGuP4dejRGli0SBUReQQPoiFQsWPHs4vV8&e=
> > > 
> > > If this is applicable/works for all u-boot based machines then I think it makes
> > > sense to have it on OE-core.
> > 
> > It is.
> > 
> > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > > Cc: Alexander Kanavin <alexander.kanavin@linux.intel.com>
> > > > Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > > Cc: Otavio Salvador <otavio@ossystems.com.br>
> > > > Cc: Ross Burton <ross.burton@intel.com>
> > > > Cc: Marek Vasut <marex@denx.de>
> > 
> > Reviewed-by: Marek Vasut <marex@denx.de>
> > 
> > That said, could the recipe for mkimage and mkenvimage be somehow
> > deduplicated ? There seems to be a lot of common stuff.
> 
> I'd say why don't we just have one recipe for all U-Boot tools
> instead of adding tools one-by-one?

Or add:
    install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
    ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage

to existing u-boot-mkimage recipe, that's what I'm doing in
u-boot-mkimage bbappend.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  reply	other threads:[~2018-11-15  9:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  4:00 [PATCH] u-boot: Add mkenvimage tool Alexey Brodkin
2018-11-15  4:00 ` Alexey Brodkin
2018-11-15  4:57 ` Khem Raj
2018-11-15  4:57   ` Khem Raj
2018-11-15  5:03   ` Marek Vasut
2018-11-15  5:03     ` Marek Vasut
2018-11-15  5:15     ` Alexey Brodkin
2018-11-15  5:15       ` Alexey Brodkin
2018-11-15  9:27       ` Martin Jansa [this message]
2018-11-15  9:27         ` Martin Jansa
2018-11-15 10:32         ` [OE-core] " Alexey Brodkin
2018-11-15 10:32           ` Alexey Brodkin
2018-11-15 11:34           ` Martin Jansa
2018-11-15 17:03             ` [OE-core] " Otavio Salvador
2018-11-15 17:03               ` Otavio Salvador
2018-11-15  5:05   ` Alexey Brodkin
2018-11-15  5:05     ` Alexey Brodkin
2018-11-15 10:41     ` [OE-core] " Stefano Babic
2018-11-15 10:41       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115092758.GA1430@jama \
    --to=martin.jansa@gmail.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.