From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>, Dave Airlie <airlied@linux.ie>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Biju Das <biju.das@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Peter Rosin <peda@axentia.se>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3] drm/bridge/sii902x: Fix EDID readback
Date: Thu, 15 Nov 2018 11:16:11 +0100 [thread overview]
Message-ID: <20181115111611.783e5c42@bbrezillon> (raw)
In-Reply-To: <CACRpkda+YcxCOQeSo=2Jk5S2b4Sa7WcROeaJitzgPcBzM1qBrA@mail.gmail.com>
On Thu, 15 Nov 2018 11:13:52 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Nov 6, 2018 at 12:52 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
>
> > While adding SiI9022A support to the iwg23s board, it came
> > up that when the HDMI transmitter is in pass through mode the
> > device is not compliant with the I2C specification anymore,
> > as it requires a far bigger tbuf, due to a delay the HDMI
> > transmitter is adding when relaying the STOP condition on the
> > monitor i2c side of things.
> >
> > When not providing an appropriate delay after the STOP condition
> > the i2c bus would get stuck. Also, any other traffic on the bus
> > while talking to the monitor may cause the transaction to fail
> > or even cause issues with the i2c bus as well.
> >
> > I2c-gates seemed to reach consent as a possible way to address
> > these issues, and as such this patch is implementing a solution
> > based on that. Since others are clearly relying on the current
> > implementation of the driver, this patch won't require any DT
> > changes.
> >
> > Since we don't want any interference during the DDC Bus
> > Request/Grant procedure and while talking to the monitor, we
> > have to use the adapter locking primitives rather than the
> > i2c-mux locking primitives.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > v2->v3:
> > * Incorporated comments from Boris Brezillon and Peter Rosin
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do you need help to apply this to drm-misc or do you
> have commit access?
I can do it if needed.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Dave Airlie <airlied@linux.ie>, Peter Rosin <peda@axentia.se>,
Wolfram Sang <wsa@the-dreams.de>, Mark Brown <broonie@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-i2c@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH v3] drm/bridge/sii902x: Fix EDID readback
Date: Thu, 15 Nov 2018 11:16:11 +0100 [thread overview]
Message-ID: <20181115111611.783e5c42@bbrezillon> (raw)
In-Reply-To: <CACRpkda+YcxCOQeSo=2Jk5S2b4Sa7WcROeaJitzgPcBzM1qBrA@mail.gmail.com>
On Thu, 15 Nov 2018 11:13:52 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Nov 6, 2018 at 12:52 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
>
> > While adding SiI9022A support to the iwg23s board, it came
> > up that when the HDMI transmitter is in pass through mode the
> > device is not compliant with the I2C specification anymore,
> > as it requires a far bigger tbuf, due to a delay the HDMI
> > transmitter is adding when relaying the STOP condition on the
> > monitor i2c side of things.
> >
> > When not providing an appropriate delay after the STOP condition
> > the i2c bus would get stuck. Also, any other traffic on the bus
> > while talking to the monitor may cause the transaction to fail
> > or even cause issues with the i2c bus as well.
> >
> > I2c-gates seemed to reach consent as a possible way to address
> > these issues, and as such this patch is implementing a solution
> > based on that. Since others are clearly relying on the current
> > implementation of the driver, this patch won't require any DT
> > changes.
> >
> > Since we don't want any interference during the DDC Bus
> > Request/Grant procedure and while talking to the monitor, we
> > have to use the adapter locking primitives rather than the
> > i2c-mux locking primitives.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > v2->v3:
> > * Incorporated comments from Boris Brezillon and Peter Rosin
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do you need help to apply this to drm-misc or do you
> have commit access?
I can do it if needed.
next prev parent reply other threads:[~2018-11-15 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 11:52 [PATCH v3] drm/bridge/sii902x: Fix EDID readback Fabrizio Castro
2018-11-06 11:52 ` Fabrizio Castro
2018-11-07 19:14 ` Peter Rosin
2018-11-07 19:14 ` Peter Rosin
2018-11-07 19:17 ` Boris Brezillon
2018-11-07 19:17 ` Boris Brezillon
2018-11-15 10:13 ` Linus Walleij
2018-11-15 10:13 ` Linus Walleij
2018-11-15 10:16 ` Boris Brezillon [this message]
2018-11-15 10:16 ` Boris Brezillon
2018-11-15 11:39 ` Fabrizio Castro
2018-11-15 11:39 ` Fabrizio Castro
2018-11-15 16:54 ` Boris Brezillon
2018-11-15 16:54 ` Boris Brezillon
2018-11-15 10:18 ` Peter Rosin
2018-11-15 10:18 ` Peter Rosin
[not found] ` <4aecf795-8a31-209f-95ba-0c5adbd2eb2e@st.com>
2018-11-15 14:32 ` Fwd: " Yannick FERTRE
2018-11-15 14:32 ` Yannick FERTRE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115111611.783e5c42@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Chris.Paterson2@renesas.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=biju.das@bp.renesas.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.