From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: Regression in next with spi return from transfer_one()
Date: Thu, 15 Nov 2018 15:44:00 -0800 [thread overview]
Message-ID: <20181115234359.GJ53235@atomide.com> (raw)
In-Reply-To: <20181115221241.GQ2089@sirena.org.uk>
* Mark Brown <broonie@kernel.org> [181115 22:12]:
> On Thu, Nov 15, 2018 at 01:14:51PM -0800, Tony Lindgren wrote:
>
> > Commit 810923f3bf06 ("spi: Deal with slaves that return from
> > transfer_one() unfinished") causes a regression at least on
> > droid 4 with SPI PMIC and regulators on the PMIC. During boot
> > the device just hangs there waiting for rootfs to appear on
> > MMC. Reverting 810923f3bf06 makes things work again.
>
> > Any ideas why this might be?
>
> Wow, that's not obvious... as far as I can tell the code in the !slave
> case is identical so unless the controller is somehow getting mistakenly
> flagged as a slave it looks like it should be something to do with it
> being pushed into a function. Could you try logging what the timeout
> ends up getting set to?
It seems to be caused because of the now missing "if (ret > 0) {"
line somehow that was there earlier. New code sets ms to 200 it
seems, then dmesg shows:
SPI transfer timed out
The old code is not updating ms and it's set to 1.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Regression in next with spi return from transfer_one()
Date: Thu, 15 Nov 2018 15:44:00 -0800 [thread overview]
Message-ID: <20181115234359.GJ53235@atomide.com> (raw)
In-Reply-To: <20181115221241.GQ2089@sirena.org.uk>
* Mark Brown <broonie@kernel.org> [181115 22:12]:
> On Thu, Nov 15, 2018 at 01:14:51PM -0800, Tony Lindgren wrote:
>
> > Commit 810923f3bf06 ("spi: Deal with slaves that return from
> > transfer_one() unfinished") causes a regression at least on
> > droid 4 with SPI PMIC and regulators on the PMIC. During boot
> > the device just hangs there waiting for rootfs to appear on
> > MMC. Reverting 810923f3bf06 makes things work again.
>
> > Any ideas why this might be?
>
> Wow, that's not obvious... as far as I can tell the code in the !slave
> case is identical so unless the controller is somehow getting mistakenly
> flagged as a slave it looks like it should be something to do with it
> being pushed into a function. Could you try logging what the timeout
> ends up getting set to?
It seems to be caused because of the now missing "if (ret > 0) {"
line somehow that was there earlier. New code sets ms to 200 it
seems, then dmesg shows:
SPI transfer timed out
The old code is not updating ms and it's set to 1.
Regards,
Tony
next prev parent reply other threads:[~2018-11-15 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 21:14 Regression in next with spi return from transfer_one() Tony Lindgren
2018-11-15 21:14 ` Tony Lindgren
2018-11-15 21:14 ` Tony Lindgren
2018-11-15 22:12 ` Mark Brown
2018-11-15 22:12 ` Mark Brown
2018-11-15 23:44 ` Tony Lindgren [this message]
2018-11-15 23:44 ` Tony Lindgren
2018-11-16 0:01 ` Mark Brown
2018-11-16 0:01 ` Mark Brown
2018-11-16 0:01 ` Mark Brown
2018-11-16 0:07 ` Tony Lindgren
2018-11-16 0:07 ` Tony Lindgren
2018-11-16 15:35 ` Lubomir Rintel
2018-11-16 15:35 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115234359.GJ53235@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.