From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jean-Philippe Brucker
<jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
virtio-dev-sDuHXQ4OtrM4h7I2RyI4rWD2FQJk+8+b@public.gmane.org,
kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
marc.zyngier-5wv7dgnIgG8@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
robin.murphy-5wv7dgnIgG8@public.gmane.org,
virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org,
bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v4 3/7] of: Allow the iommu-map property to omit untranslated devices
Date: Fri, 16 Nov 2018 17:26:48 -0600 [thread overview]
Message-ID: <20181116232648.GA12293@bogus> (raw)
In-Reply-To: <20181115165234.43990-4-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
On Thu, 15 Nov 2018 16:52:30 +0000, Jean-Philippe Brucker wrote:
> In PCI root complex nodes, the iommu-map property describes the IOMMU that
> translates each endpoint. On some platforms, the IOMMU itself is presented
> as a PCI endpoint (e.g. AMD IOMMU and virtio-iommu). This isn't supported
> by the current OF driver, which expects all endpoints to have an IOMMU.
> Allow the iommu-map property to have gaps.
>
> Relaxing of_map_rid() also allows the msi-map property to have gaps, which
> is invalid since MSIs always reach an MSI controller. In that case
> pci_msi_setup_msi_irqs() will return an error when attempting to find the
> device's MSI domain.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
> ---
> drivers/of/base.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, joro@8bytes.org, mst@redhat.com,
frowand.list@gmail.com, jasowang@redhat.com, robh+dt@kernel.org,
mark.rutland@arm.com, bhelgaas@google.com,
kvmarm@lists.cs.columbia.edu, eric.auger@redhat.com,
tnowicki@caviumnetworks.com, kevin.tian@intel.com,
marc.zyngier@arm.com, robin.murphy@arm.com, will.deacon@arm.com,
lorenzo.pieralisi@arm.com, bharat.bhushan@nxp.com
Subject: Re: [PATCH v4 3/7] of: Allow the iommu-map property to omit untranslated devices
Date: Fri, 16 Nov 2018 17:26:48 -0600 [thread overview]
Message-ID: <20181116232648.GA12293@bogus> (raw)
In-Reply-To: <20181115165234.43990-4-jean-philippe.brucker@arm.com>
On Thu, 15 Nov 2018 16:52:30 +0000, Jean-Philippe Brucker wrote:
> In PCI root complex nodes, the iommu-map property describes the IOMMU that
> translates each endpoint. On some platforms, the IOMMU itself is presented
> as a PCI endpoint (e.g. AMD IOMMU and virtio-iommu). This isn't supported
> by the current OF driver, which expects all endpoints to have an IOMMU.
> Allow the iommu-map property to have gaps.
>
> Relaxing of_map_rid() also allows the msi-map property to have gaps, which
> is invalid since MSIs always reach an MSI controller. In that case
> pci_msi_setup_msi_irqs() will return an error when attempting to find the
> device's MSI domain.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> ---
> drivers/of/base.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-11-16 23:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 16:52 [PATCH v4 0/7] Add virtio-iommu driver Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [PATCH v4 1/7] dt-bindings: virtio-mmio: Add IOMMU description Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [PATCH v4 2/7] dt-bindings: virtio: Add virtio-pci-iommu node Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-15 16:52 ` [PATCH v4 3/7] of: Allow the iommu-map property to omit untranslated devices Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
[not found] ` <20181115165234.43990-4-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-11-16 23:26 ` Rob Herring [this message]
2018-11-16 23:26 ` Rob Herring
2018-11-16 23:26 ` Rob Herring
2018-11-15 16:52 ` [PATCH v4 4/7] PCI: OF: Initialize dev->fwnode appropriately Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [PATCH v4 5/7] iommu: Add virtio-iommu driver Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-16 6:08 ` Auger Eric
2018-11-16 6:08 ` Auger Eric
2018-11-16 6:08 ` [virtio-dev] " Auger Eric
2018-11-16 18:46 ` Jean-Philippe Brucker
2018-11-16 18:46 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-20 17:30 ` Jean-Philippe Brucker
2018-11-20 17:30 ` Jean-Philippe Brucker
2018-11-20 17:30 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-20 17:30 ` Jean-Philippe Brucker
2018-11-21 12:21 ` Auger Eric
2018-11-21 12:21 ` [virtio-dev] " Auger Eric
2018-11-21 12:21 ` Auger Eric
2018-11-21 12:21 ` Auger Eric
2018-11-16 18:46 ` Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [PATCH v4 6/7] iommu/virtio: Add probe request Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-16 8:56 ` Auger Eric
2018-11-16 8:56 ` [virtio-dev] " Auger Eric
2018-11-16 8:56 ` Auger Eric
2018-11-15 16:52 ` [PATCH v4 7/7] iommu/virtio: Add event queue Jean-Philippe Brucker
2018-11-15 16:52 ` Jean-Philippe Brucker
2018-11-15 16:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-16 6:40 ` Auger Eric
2018-11-16 6:40 ` Auger Eric
2018-11-16 6:40 ` [virtio-dev] " Auger Eric
2018-11-16 13:00 ` [PATCH v4 0/7] Add virtio-iommu driver Auger Eric
2018-11-16 13:00 ` [virtio-dev] " Auger Eric
2018-11-16 13:00 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116232648.GA12293@bogus \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org \
--cc=kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=virtio-dev-sDuHXQ4OtrM4h7I2RyI4rWD2FQJk+8+b@public.gmane.org \
--cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.