* [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor
@ 2018-11-09 7:56 Manivannan Sadhasivam
2018-11-09 8:57 ` Todor Tomov
2018-11-17 16:41 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2018-11-09 7:56 UTC (permalink / raw)
To: mchehab, robh+dt, todor.tomov, hansverk
Cc: linux-media, devicetree, linux-kernel, Manivannan Sadhasivam
The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
incorrectly mentioned as 0x78 in binding. Hence fix that.
Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
index fd7aec9f8e24..1a68ca5eb9a3 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
+++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
@@ -26,9 +26,9 @@ Example:
&i2c1 {
...
- ov5645: ov5645@78 {
+ ov5645: ov5645@3c {
compatible = "ovti,ov5645";
- reg = <0x78>;
+ reg = <0x3c>;
enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
reset-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor
2018-11-09 7:56 [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor Manivannan Sadhasivam
@ 2018-11-09 8:57 ` Todor Tomov
2018-11-17 16:41 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Todor Tomov @ 2018-11-09 8:57 UTC (permalink / raw)
To: Manivannan Sadhasivam, mchehab, robh+dt, hansverk
Cc: linux-media, devicetree, linux-kernel
Hi Mani,
On 9.11.2018 09:56, Manivannan Sadhasivam wrote:
> The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
> incorrectly mentioned as 0x78 in binding. Hence fix that.
The seven bit i2c address of ov5645 is really 0x3c.
Thank you for finding this and sending the fix!
Best regards,
Todor
>
> Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> index fd7aec9f8e24..1a68ca5eb9a3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> @@ -26,9 +26,9 @@ Example:
> &i2c1 {
> ...
>
> - ov5645: ov5645@78 {
> + ov5645: ov5645@3c {
> compatible = "ovti,ov5645";
> - reg = <0x78>;
> + reg = <0x3c>;
>
> enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor
2018-11-09 7:56 [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor Manivannan Sadhasivam
@ 2018-11-17 16:41 ` Rob Herring
2018-11-17 16:41 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-11-17 16:41 UTC (permalink / raw)
Cc: mchehab, robh+dt, todor.tomov, hansverk, linux-media, devicetree,
linux-kernel, Manivannan Sadhasivam
On Fri, 9 Nov 2018 13:26:43 +0530, Manivannan Sadhasivam wrote:
> The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
> incorrectly mentioned as 0x78 in binding. Hence fix that.
>
> Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor
@ 2018-11-17 16:41 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-11-17 16:41 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: mchehab, robh+dt, todor.tomov, hansverk, linux-media, devicetree,
linux-kernel, Manivannan Sadhasivam
On Fri, 9 Nov 2018 13:26:43 +0530, Manivannan Sadhasivam wrote:
> The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
> incorrectly mentioned as 0x78 in binding. Hence fix that.
>
> Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-18 2:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-09 7:56 [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor Manivannan Sadhasivam
2018-11-09 8:57 ` Todor Tomov
2018-11-17 16:41 ` Rob Herring
2018-11-17 16:41 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.