All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, Tony Lindgren <tony@atomide.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	Sebastian Reichel <sre@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCHv4 5/6] drm/omap: add framedone interrupt support
Date: Sat, 17 Nov 2018 22:08:40 +0100	[thread overview]
Message-ID: <20181117210840.GE22813@amd> (raw)
In-Reply-To: <20181115230645.15748-6-sebastian.reichel@collabora.com>


[-- Attachment #1.1: Type: text/plain, Size: 943 bytes --]

Hi!

> This prepares framedone interrupt handling for
> manual display update support.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

> @@ -217,6 +239,9 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
>  
>  		if (irqstatus & priv->dispc_ops->mgr_get_sync_lost_irq(priv->dispc, channel))
>  			omap_crtc_error_irq(crtc, irqstatus);
> +
> +		if (irqstatus & priv->dispc_ops->mgr_get_framedone_irq(priv->dispc, channel))
> +			omap_crtc_framedone_irq(crtc, irqstatus);
>  	}
>  
>  	omap_irq_ocp_error_handler(dev, irqstatus);

Will the mgr_get_framedone_irq(priv->dispc, channel) change from
interrupt to interrupt? Would it make sense to cache result as a
micro-organization?

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv4 5/6] drm/omap: add framedone interrupt support
Date: Sat, 17 Nov 2018 22:08:40 +0100	[thread overview]
Message-ID: <20181117210840.GE22813@amd> (raw)
In-Reply-To: <20181115230645.15748-6-sebastian.reichel@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hi!

> This prepares framedone interrupt handling for
> manual display update support.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

> @@ -217,6 +239,9 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
>  
>  		if (irqstatus & priv->dispc_ops->mgr_get_sync_lost_irq(priv->dispc, channel))
>  			omap_crtc_error_irq(crtc, irqstatus);
> +
> +		if (irqstatus & priv->dispc_ops->mgr_get_framedone_irq(priv->dispc, channel))
> +			omap_crtc_framedone_irq(crtc, irqstatus);
>  	}
>  
>  	omap_irq_ocp_error_handler(dev, irqstatus);

Will the mgr_get_framedone_irq(priv->dispc, channel) change from
interrupt to interrupt? Would it make sense to cache result as a
micro-organization?

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-11-17 21:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 23:06 [PATCHv4 0/6] omapdrm: DSI command mode panel support Sebastian Reichel
2018-11-15 23:06 ` [PATCHv4 1/6] drm/omap: use DRM_DEBUG_DRIVER instead of CORE Sebastian Reichel
2018-11-17 21:01   ` Pavel Machek
2018-11-17 21:01     ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 2/6] drm/omap: populate DSI platform bus earlier Sebastian Reichel
2018-11-17 21:02   ` Pavel Machek
2018-11-17 21:02     ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 3/6] drm/omap: don't check dispc timings for DSI Sebastian Reichel
2018-11-17 21:04   ` Pavel Machek
2018-11-17 21:04     ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 4/6] drm/omap: fix incorrect union usage Sebastian Reichel
2018-11-16 13:41   ` Tomi Valkeinen
2018-11-16 13:41     ` Tomi Valkeinen
2018-11-16 22:36     ` Sebastian Reichel
2018-11-15 23:06 ` [PATCHv4 5/6] drm/omap: add framedone interrupt support Sebastian Reichel
2018-11-17 21:08   ` Pavel Machek [this message]
2018-11-17 21:08     ` Pavel Machek
2018-11-19 12:05     ` Sebastian Reichel
2018-11-19 12:12       ` Pavel Machek
2018-11-15 23:06 ` [PATCHv4 6/6] drm/omap: add support for manually updated displays Sebastian Reichel
2018-11-17 21:16   ` Pavel Machek
2018-11-16 22:09 ` [PATCHv4 0/6] omapdrm: DSI command mode panel support Tony Lindgren
2018-11-17 21:00 ` Pavel Machek
2018-11-17 21:00   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181117210840.GE22813@amd \
    --to=pavel@ucw.cz \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hns@goldelico.com \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.