From: Lee Jones <lee.jones@linaro.org>
To: Julien Grall <julien.grall@arm.com>
Cc: Daniel Kiper <dkiper@net-space.pl>, Fu Wei Fu <fu.wei@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression
Date: Tue, 20 Nov 2018 12:26:50 +0000 [thread overview]
Message-ID: <20181120122650.GU3513@dell> (raw)
In-Reply-To: <1956f6fa-a0e1-0e6b-24b2-e3f040a2ee67@arm.com>
On Tue, 20 Nov 2018, Julien Grall wrote:
> Hi,
>
> On 20/11/2018 11:22, Lee Jones wrote:
> > On Tue, 20 Nov 2018, Julien Grall wrote:
> > > On 20/11/2018 10:46, Lee Jones wrote:
> > > > From: Lee Jones <lee.jones@linaro.org>
> > > >
> > > > arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression
> > >
> > > This patch seems to drop support for --nounzip. Can you explain why?
> >
> > It only seemed to serve the invocation of grub_file_filter_disable_compression()
> > which was removed in this patch.
>
> But --nounzip will not work as expected after this patch. Looking at GRUB,
> it seems the call to that function was replaced by passing
> GRUB_FILE_TYPE_NO_DECOMPRESSION to grub_file_open.
Ah yes, I see. Please bear with me.
I need to split this patch too.
> Is there any reason to not use it for Arm?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-11-20 13:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 19:29 [PATCH 0/5] Fix non-x86 builds after verifiers framework merged Leif Lindholm
2018-11-14 19:29 ` [PATCH 1/5] grub/verify.h: add include guard Leif Lindholm
2018-11-14 19:29 ` [PATCH 2/5] file.h: add device tree file type Leif Lindholm
2018-11-14 19:29 ` [PATCH 3/5] loader/efi/fdt.c: fixup grub_file_open call Leif Lindholm
2018-11-14 19:29 ` [PATCH 4/5] arm64/efi: fix breakage caused by verifiers Leif Lindholm
2018-11-14 19:29 ` [PATCH 5/5] arm-uboot, ia64, sparc64: fix up grub_file_open calls Leif Lindholm
2018-11-16 2:31 ` [PATCH 0/5] Fix non-x86 builds after verifiers framework merged Fu Wei Fu
2018-11-16 14:07 ` Daniel Kiper
2018-11-20 10:45 ` arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’ Lee Jones
2018-11-20 11:12 ` Julien Grall
2018-11-21 14:12 ` Daniel Kiper
2018-11-22 7:26 ` Lee Jones
2018-11-20 10:46 ` arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression Lee Jones
2018-11-20 11:00 ` Julien Grall
2018-11-20 11:22 ` Lee Jones
2018-11-20 11:56 ` Julien Grall
2018-11-20 12:26 ` Lee Jones [this message]
2018-11-20 11:38 ` [PATCH v2] " Lee Jones
2018-11-20 12:35 ` [PATCH v3 (part 1)] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression' Lee Jones
2018-11-21 14:59 ` Daniel Kiper
2018-11-20 12:37 ` [PATCH v3 (part 2)] generic/blocklist: " Lee Jones
2018-11-20 18:55 ` Vladimir 'phcoder' Serbinenko
2018-11-21 14:14 ` Daniel Kiper
2018-11-20 10:48 ` arm64/xen: Fix too few arguments to function ‘grub_file_open’ Lee Jones
2018-11-20 11:05 ` Julien Grall
2018-11-20 11:20 ` Lee Jones
2018-11-20 11:39 ` [PATCH v2] " Lee Jones
2018-11-21 14:57 ` Daniel Kiper
2018-11-20 11:37 ` arm64/xen: Remove duplicate check for arguments Lee Jones
2018-11-20 18:54 ` Vladimir 'phcoder' Serbinenko
2018-11-16 14:05 ` [PATCH 0/5] Fix non-x86 builds after verifiers framework merged Daniel Kiper
2018-11-16 15:20 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120122650.GU3513@dell \
--to=lee.jones@linaro.org \
--cc=dkiper@net-space.pl \
--cc=fu.wei@linaro.org \
--cc=grub-devel@gnu.org \
--cc=julien.grall@arm.com \
--cc=leif.lindholm@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.