From: Yangtao Li <tiny.windzz@gmail.com>
To: rjw@rjwysocki.net, daniel.lezcano@linaro.org, lorenzo.pieralisi@arm.com
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH] cpuidle: big.LITTLE: add of_node_put()
Date: Tue, 20 Nov 2018 08:00:12 -0500 [thread overview]
Message-ID: <20181120130012.19471-1-tiny.windzz@gmail.com> (raw)
use of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpuidle/cpuidle-big_little.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
index db2ede565f1a..a3b8bc09bac8 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -174,8 +174,10 @@ static int __init bl_idle_init(void)
/*
* Initialize the driver just for a compliant set of machines
*/
- if (!of_match_node(compatible_machine_match, root))
- return -ENODEV;
+ if (!of_match_node(compatible_machine_match, root)){
+ ret = -ENODEV;
+ goto out_release_node;
+ }
if (!mcpm_is_available())
return -EUNATCH;
@@ -222,6 +224,8 @@ static int __init bl_idle_init(void)
kfree(bl_idle_big_driver.cpumask);
out_uninit_little:
kfree(bl_idle_little_driver.cpumask);
+out_release_node:
+ of_node_put(root);
return ret;
}
--
2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: tiny.windzz@gmail.com (Yangtao Li)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpuidle: big.LITTLE: add of_node_put()
Date: Tue, 20 Nov 2018 08:00:12 -0500 [thread overview]
Message-ID: <20181120130012.19471-1-tiny.windzz@gmail.com> (raw)
use of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpuidle/cpuidle-big_little.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
index db2ede565f1a..a3b8bc09bac8 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -174,8 +174,10 @@ static int __init bl_idle_init(void)
/*
* Initialize the driver just for a compliant set of machines
*/
- if (!of_match_node(compatible_machine_match, root))
- return -ENODEV;
+ if (!of_match_node(compatible_machine_match, root)){
+ ret = -ENODEV;
+ goto out_release_node;
+ }
if (!mcpm_is_available())
return -EUNATCH;
@@ -222,6 +224,8 @@ static int __init bl_idle_init(void)
kfree(bl_idle_big_driver.cpumask);
out_uninit_little:
kfree(bl_idle_little_driver.cpumask);
+out_release_node:
+ of_node_put(root);
return ret;
}
--
2.17.0
next reply other threads:[~2018-11-20 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:00 Yangtao Li [this message]
2018-11-20 13:00 ` [PATCH] cpuidle: big.LITTLE: add of_node_put() Yangtao Li
2018-11-20 15:23 ` Rafael J. Wysocki
2018-11-20 15:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120130012.19471-1-tiny.windzz@gmail.com \
--to=tiny.windzz@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.