From: Eiichi Tsukata <devel@etsukata.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v1 3/4] f2fs: fix race between llseek SEEK_END and write
Date: Wed, 21 Nov 2018 11:43:59 +0900 [thread overview]
Message-ID: <20181121024400.4346-4-devel@etsukata.com> (raw)
In-Reply-To: <20181121024400.4346-1-devel@etsukata.com>
This patch itself seems to be just a cleanup but with the
commit b25bd1d9fd87 ("vfs: fix race between llseek SEEK_END and write")
it fixes race.
Signed-off-by: Eiichi Tsukata <devel@etsukata.com>
---
fs/f2fs/file.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 88b124677189..14a923607eff 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -447,15 +447,11 @@ static loff_t f2fs_seek_block(struct file *file, loff_t offset, int whence)
static loff_t f2fs_llseek(struct file *file, loff_t offset, int whence)
{
- struct inode *inode = file->f_mapping->host;
- loff_t maxbytes = inode->i_sb->s_maxbytes;
-
switch (whence) {
case SEEK_SET:
case SEEK_CUR:
case SEEK_END:
- return generic_file_llseek_size(file, offset, whence,
- maxbytes, i_size_read(inode));
+ return generic_file_llseek(file, offset, whence);
case SEEK_DATA:
case SEEK_HOLE:
if (offset < 0)
--
2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Eiichi Tsukata <devel@etsukata.com>
To: andi@firstfloor.org, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-unionfs@vger.kernel.org
Cc: Eiichi Tsukata <devel@etsukata.com>
Subject: [PATCH v1 3/4] f2fs: fix race between llseek SEEK_END and write
Date: Wed, 21 Nov 2018 11:43:59 +0900 [thread overview]
Message-ID: <20181121024400.4346-4-devel@etsukata.com> (raw)
In-Reply-To: <20181121024400.4346-1-devel@etsukata.com>
This patch itself seems to be just a cleanup but with the
commit b25bd1d9fd87 ("vfs: fix race between llseek SEEK_END and write")
it fixes race.
Signed-off-by: Eiichi Tsukata <devel@etsukata.com>
---
fs/f2fs/file.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 88b124677189..14a923607eff 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -447,15 +447,11 @@ static loff_t f2fs_seek_block(struct file *file, loff_t offset, int whence)
static loff_t f2fs_llseek(struct file *file, loff_t offset, int whence)
{
- struct inode *inode = file->f_mapping->host;
- loff_t maxbytes = inode->i_sb->s_maxbytes;
-
switch (whence) {
case SEEK_SET:
case SEEK_CUR:
case SEEK_END:
- return generic_file_llseek_size(file, offset, whence,
- maxbytes, i_size_read(inode));
+ return generic_file_llseek(file, offset, whence);
case SEEK_DATA:
case SEEK_HOLE:
if (offset < 0)
--
2.19.1
next prev parent reply other threads:[~2018-11-21 2:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 2:43 [Cluster-devel] [PATCH v1 0/4] fs: fix race between llseek SEEK_END and write Eiichi Tsukata
2018-11-21 2:43 ` Eiichi Tsukata
2018-11-21 2:43 ` [Cluster-devel] [PATCH v1 1/4] vfs: " Eiichi Tsukata
2018-11-21 2:43 ` Eiichi Tsukata
2018-11-21 2:43 ` [Cluster-devel] [PATCH v1 2/4] ext4: " Eiichi Tsukata
2018-11-21 2:43 ` Eiichi Tsukata
2018-11-21 2:43 ` Eiichi Tsukata [this message]
2018-11-21 2:43 ` [PATCH v1 3/4] f2fs: " Eiichi Tsukata
2018-11-21 9:23 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 9:23 ` Christoph Hellwig
2018-11-22 5:42 ` [Cluster-devel] " Eiichi Tsukata
2018-11-22 5:42 ` Eiichi Tsukata
2018-11-21 2:44 ` [Cluster-devel] [PATCH v1 4/4] overlayfs: " Eiichi Tsukata
2018-11-21 2:44 ` Eiichi Tsukata
2018-11-21 4:54 ` [Cluster-devel] [PATCH v1 0/4] fs: " Al Viro
2018-11-21 4:54 ` Al Viro
2018-11-22 5:40 ` [Cluster-devel] " Eiichi Tsukata
2018-11-22 5:40 ` Eiichi Tsukata
2018-11-22 7:06 ` [Cluster-devel] " Al Viro
2018-11-22 7:06 ` Al Viro
2018-11-26 2:54 ` [Cluster-devel] " Eiichi Tsukata
2018-11-26 2:54 ` Eiichi Tsukata
2018-11-26 2:54 ` Eiichi Tsukata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121024400.4346-4-devel@etsukata.com \
--to=devel@etsukata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.