From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Do not touch PCH handshake registers if PCH is not present
Date: Wed, 21 Nov 2018 13:18:52 +0200 [thread overview]
Message-ID: <20181121111852.GZ9144@intel.com> (raw)
In-Reply-To: <20181120223242.27541-2-jose.souza@intel.com>
On Tue, Nov 20, 2018 at 02:32:41PM -0800, José Roberto de Souza wrote:
> If no PCH was detected in intel_detect_pch() don't touch the
> handshake registers.
We are explicitly told to frob this on BXT/GLK. So this doesn't make
sense. What is this supposed to fix?
>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 1c2de9b69a19..f33f335d6106 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -3325,6 +3325,9 @@ static void intel_pch_reset_handshake(struct drm_i915_private *dev_priv,
> i915_reg_t reg;
> u32 reset_bits, val;
>
> + if (!HAS_PCH_SPLIT(dev_priv))
> + return;
> +
> if (IS_IVYBRIDGE(dev_priv)) {
> reg = GEN7_MSG_CTL;
> reset_bits = WAIT_FOR_PCH_FLR_ACK | WAIT_FOR_PCH_RESET_ACK;
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-21 11:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 22:32 [PATCH 1/3] drm/i915: Add HAS_DISPLAY() and use it José Roberto de Souza
2018-11-20 22:32 ` [PATCH 2/3] drm/i915: Do not touch PCH handshake registers if PCH is not present José Roberto de Souza
2018-11-21 11:18 ` Ville Syrjälä [this message]
2018-11-20 22:32 ` [PATCH 3/3] drm/i915: Move display device info capabilities to its own struct José Roberto de Souza
2018-11-20 23:03 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Add HAS_DISPLAY() and use it Patchwork
2018-11-20 23:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-20 23:20 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-21 11:13 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-22 0:20 ` [PATCH 1/3] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121111852.GZ9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.