From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: radu_nicolae.pirea@upb.ro,
Richard Genoud <richard.genoud@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.co>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode
Date: Wed, 21 Nov 2018 17:48:20 +0100 [thread overview]
Message-ID: <20181121164820.GC12656@piout.net> (raw)
In-Reply-To: <CAL_JsqLNURZTWCb5WOyJvN-trUP9r-ueftwUOGWPnrEaQPBKSw@mail.gmail.com>
Hi Rob,
On 21/11/2018 10:41:01-0600, Rob Herring wrote:
> > +Optional properties in serial and SPI mode:
> > +- dma bindings for dma transfer:
> > + - dmas: DMA specifier, consisting of a phandle to DMA controller node,
> > + memory peripheral interface and USART DMA channel ID, FIFO configuration.
> > + Refer to dma.txt and atmel-dma.txt for details.
> > + - dma-names: "rx" for RX channel, "tx" for TX channel.
>
> > + dma-names = "tx", "rx";
>
> The dma-names should have a defined order.
>
Why is that? Isn't the purpose of names to get rid of any particular
ordering?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@bootlin.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode
Date: Wed, 21 Nov 2018 17:48:20 +0100 [thread overview]
Message-ID: <20181121164820.GC12656@piout.net> (raw)
In-Reply-To: <CAL_JsqLNURZTWCb5WOyJvN-trUP9r-ueftwUOGWPnrEaQPBKSw@mail.gmail.com>
Hi Rob,
On 21/11/2018 10:41:01-0600, Rob Herring wrote:
> > +Optional properties in serial and SPI mode:
> > +- dma bindings for dma transfer:
> > + - dmas: DMA specifier, consisting of a phandle to DMA controller node,
> > + memory peripheral interface and USART DMA channel ID, FIFO configuration.
> > + Refer to dma.txt and atmel-dma.txt for details.
> > + - dma-names: "rx" for RX channel, "tx" for TX channel.
>
> > + dma-names = "tx", "rx";
>
> The dma-names should have a defined order.
>
Why is that? Isn't the purpose of names to get rid of any particular
ordering?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-21 16:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 11:27 [PATCH 0/3] Add PM and DMA support for AT91 USART as SPI Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-21 11:27 ` [PATCH 1/3] spi: at91-usart: add power management support Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-28 16:05 ` Applied "spi: at91-usart: add power management support" to the spi tree Mark Brown
2018-11-28 16:05 ` Mark Brown
2018-11-28 16:05 ` Mark Brown
2018-11-28 16:05 ` Mark Brown
2018-11-21 11:27 ` [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-21 16:41 ` Rob Herring
2018-11-21 16:41 ` Rob Herring
2018-11-21 16:48 ` Alexandre Belloni [this message]
2018-11-21 16:48 ` Alexandre Belloni
2018-11-21 20:52 ` Rob Herring
2018-11-21 20:52 ` Rob Herring
2018-11-21 21:21 ` Alexandre Belloni
2018-11-21 21:21 ` Alexandre Belloni
2018-11-23 16:07 ` Radu Nicolae Pirea
2018-11-23 16:07 ` Radu Nicolae Pirea
2018-11-21 11:27 ` [PATCH 3/3] spi: at91-usart: add DMA support Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-21 11:27 ` Radu Pirea
2018-11-21 17:38 ` Robin Murphy
2018-11-21 17:38 ` Robin Murphy
2018-11-23 16:19 ` Radu Nicolae Pirea
2018-11-23 16:19 ` Radu Nicolae Pirea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121164820.GC12656@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ludovic.desroches@microchip.co \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.