All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: Len Brown <len.brown@intel.com>, Michal Hocko <mhocko@suse.com>,
	linux-pm@vger.kernel.org, pv-drivers@vmware.com,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-doc@vger.kernel.org, kexec-ml <kexec@lists.infradead.org>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Pavel Machek <pavel@ucw.cz>,
	xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org,
	devel@linuxdriverproject.org,
	David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 7/8] PM / Hibernate: use pfn_to_online_page()
Date: Thu, 22 Nov 2018 11:06:26 +0100	[thread overview]
Message-ID: <20181122100627.5189-8-david@redhat.com> (raw)
In-Reply-To: <20181122100627.5189-1-david@redhat.com>

Let's use pfn_to_online_page() instead of pfn_to_page() when checking
for saveable pages to not save/restore offline memory sections.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <len.brown@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Suggested-by: Michal Hocko <mhocko@kernel.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 kernel/power/snapshot.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 640b2034edd6..87e6dd57819f 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -1215,8 +1215,8 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
 	if (!pfn_valid(pfn))
 		return NULL;
 
-	page = pfn_to_page(pfn);
-	if (page_zone(page) != zone)
+	page = pfn_to_online_page(pfn);
+	if (!page || page_zone(page) != zone)
 		return NULL;
 
 	BUG_ON(!PageHighMem(page));
@@ -1277,8 +1277,8 @@ static struct page *saveable_page(struct zone *zone, unsigned long pfn)
 	if (!pfn_valid(pfn))
 		return NULL;
 
-	page = pfn_to_page(pfn);
-	if (page_zone(page) != zone)
+	page = pfn_to_online_page(pfn);
+	if (!page || page_zone(page) != zone)
 		return NULL;
 
 	BUG_ON(PageHighMem(page));
-- 
2.17.2


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org,
	linux-pm@vger.kernel.org, xen-devel@lists.xenproject.org,
	kexec-ml <kexec@lists.infradead.org>,
	pv-drivers@vmware.com, David Hildenbrand <david@redhat.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Michal Hocko <mhocko@suse.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH v2 7/8] PM / Hibernate: use pfn_to_online_page()
Date: Thu, 22 Nov 2018 11:06:26 +0100	[thread overview]
Message-ID: <20181122100627.5189-8-david@redhat.com> (raw)
In-Reply-To: <20181122100627.5189-1-david@redhat.com>

Let's use pfn_to_online_page() instead of pfn_to_page() when checking
for saveable pages to not save/restore offline memory sections.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <len.brown@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Suggested-by: Michal Hocko <mhocko@kernel.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 kernel/power/snapshot.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 640b2034edd6..87e6dd57819f 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -1215,8 +1215,8 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
 	if (!pfn_valid(pfn))
 		return NULL;
 
-	page = pfn_to_page(pfn);
-	if (page_zone(page) != zone)
+	page = pfn_to_online_page(pfn);
+	if (!page || page_zone(page) != zone)
 		return NULL;
 
 	BUG_ON(!PageHighMem(page));
@@ -1277,8 +1277,8 @@ static struct page *saveable_page(struct zone *zone, unsigned long pfn)
 	if (!pfn_valid(pfn))
 		return NULL;
 
-	page = pfn_to_page(pfn);
-	if (page_zone(page) != zone)
+	page = pfn_to_online_page(pfn);
+	if (!page || page_zone(page) != zone)
 		return NULL;
 
 	BUG_ON(PageHighMem(page));
-- 
2.17.2


  parent reply	other threads:[~2018-11-22 10:07 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 10:06 [PATCH v2 0/8] mm/kdump: allow to exclude pages that are logically offline David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 1/8] mm: balloon: update comment about isolation/migration/compaction David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 2/8] mm: convert PG_balloon to PG_offline David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2019-03-11  9:04   ` Dave Young
2019-03-11  9:04   ` Dave Young
2019-03-11  9:04     ` Dave Young
2019-03-11  9:55     ` David Hildenbrand
2019-03-11  9:55       ` David Hildenbrand
2019-03-11 10:04       ` Dave Young
2019-03-11 10:04         ` Dave Young
2019-03-11 10:04       ` Dave Young
2019-03-11  9:55     ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 4/8] xen/balloon: mark inflated pages PG_offline David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-23 13:41   ` Juergen Gross
2018-11-23 13:41     ` Juergen Gross
2018-11-23 13:41     ` Juergen Gross
2018-11-23 13:41   ` Juergen Gross
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 5/8] hv_balloon: " David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 6/8] vmw_balloon: " David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 7/8] PM / Hibernate: use pfn_to_online_page() David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand [this message]
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06 ` [PATCH v2 8/8] PM / Hibernate: exclude all PageOffline() pages David Hildenbrand
2018-11-22 10:06   ` David Hildenbrand
2018-11-22 10:06 ` David Hildenbrand
2018-11-22 10:09 ` [PATCH v2] makedumpfile: exclude pages that are logically offline David Hildenbrand
2018-11-22 10:09   ` David Hildenbrand
2018-11-27 16:32   ` Kazuhito Hagio
2018-11-27 16:32   ` Kazuhito Hagio
2018-11-27 16:32     ` Kazuhito Hagio
2018-11-27 16:32     ` Kazuhito Hagio
2019-03-07  8:41     ` David Hildenbrand
2019-03-07  8:41       ` David Hildenbrand
2019-03-11 16:40       ` Kazuhito Hagio
2019-03-11 16:40       ` Kazuhito Hagio
2019-03-11 16:40         ` Kazuhito Hagio
2019-03-07  8:41     ` David Hildenbrand
2018-11-22 10:09 ` David Hildenbrand
2019-02-27  5:32 ` [PATCH v2 0/8] mm/kdump: allow to " Dave Young
2019-02-27  5:32 ` Dave Young
2019-02-27  5:32   ` Dave Young
2019-02-27  5:32   ` Dave Young
2019-02-28 19:45   ` Andrew Morton
2019-02-28 19:45   ` Andrew Morton
2019-02-28 19:45     ` Andrew Morton
2019-02-28 19:45     ` Andrew Morton
2019-02-28 19:54     ` Boris Ostrovsky
2019-02-28 19:54     ` Boris Ostrovsky
2019-02-28 19:54       ` Boris Ostrovsky
2019-02-28 19:54       ` Boris Ostrovsky
2019-03-04  6:21     ` Dave Young
2019-03-04  6:21     ` Dave Young
2019-03-04  6:21       ` Dave Young
2019-03-04  6:21       ` Dave Young
2019-03-04  7:14       ` Juergen Gross
2019-03-04  7:14       ` Juergen Gross
2019-03-04  7:14         ` Juergen Gross
2019-03-04  7:14         ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181122100627.5189-8-david@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=devel@linuxdriverproject.org \
    --cc=kexec@lists.infradead.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=mst@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=pv-drivers@vmware.com \
    --cc=rjw@rjwysocki.net \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.