All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: armada8k: add support for gpio controlled reset signal
Date: Thu, 22 Nov 2018 15:46:51 +0100	[thread overview]
Message-ID: <20181122154651.223c62d9@windsurf> (raw)
In-Reply-To: <20181122154523.5aa652d4@windsurf>

Hello,

On Thu, 22 Nov 2018 15:45:23 +0100, Thomas Petazzoni wrote:

> This should be:
> 
> 	if (!IS_ERR(pcie->reset_gpio))
> 
> Indeed, in the case of an error, pcie->reset_gpio will be non-NULL,
> with the error encoded as a ERR_PTR().

Meh, scrap that. If pcie->reset_gpio was an error, probe() has failed.
So by the time we are in armada8k_pcie_host_init(), pcie->reset_gpio is
either NULL or a valid GPIO. So my comment was stupid.

Since the newline thing is way too minor to require a new iteration:

Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks, and sorry for the noise.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@bootlin.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: armada8k: add support for gpio controlled reset signal
Date: Thu, 22 Nov 2018 15:46:51 +0100	[thread overview]
Message-ID: <20181122154651.223c62d9@windsurf> (raw)
In-Reply-To: <20181122154523.5aa652d4@windsurf>

Hello,

On Thu, 22 Nov 2018 15:45:23 +0100, Thomas Petazzoni wrote:

> This should be:
> 
> 	if (!IS_ERR(pcie->reset_gpio))
> 
> Indeed, in the case of an error, pcie->reset_gpio will be non-NULL,
> with the error encoded as a ERR_PTR().

Meh, scrap that. If pcie->reset_gpio was an error, probe() has failed.
So by the time we are in armada8k_pcie_host_init(), pcie->reset_gpio is
either NULL or a valid GPIO. So my comment was stupid.

Since the newline thing is way too minor to require a new iteration:

Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks, and sorry for the noise.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-22 14:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 12:49 [PATCH] PCI: armada8k: add support for gpio controlled reset signal Baruch Siach
2018-10-03 12:49 ` Baruch Siach
2018-10-03 13:28 ` Andrew Lunn
2018-10-03 13:28   ` Andrew Lunn
2018-10-03 13:35   ` Baruch Siach
2018-10-03 13:35     ` Baruch Siach
2018-11-16 12:10     ` Lorenzo Pieralisi
2018-11-16 12:10       ` Lorenzo Pieralisi
2018-11-21  7:09       ` Baruch Siach
2018-11-21  7:09         ` Baruch Siach
2018-11-21  7:47         ` Thomas Petazzoni
2018-11-21  7:47           ` Thomas Petazzoni
2018-11-22 14:45 ` Thomas Petazzoni
2018-11-22 14:45   ` Thomas Petazzoni
2018-11-22 14:46   ` Thomas Petazzoni [this message]
2018-11-22 14:46     ` Thomas Petazzoni
2018-11-22 15:23 ` Lorenzo Pieralisi
2018-11-22 15:23   ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181122154651.223c62d9@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=baruch@tkos.co.il \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.