From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 2/2] phy: mapphone-mdm6600: Improve phy related runtime PM calls
Date: Fri, 23 Nov 2018 08:58:38 -0800 [thread overview]
Message-ID: <20181123165838.GF53235@atomide.com> (raw)
In-Reply-To: <ac3a7cdd-4f03-069f-844a-072e99759c83@ti.com>
* Kishon Vijay Abraham I <kishon@ti.com> [181123 07:59]:
> On 17/11/18 7:07 PM, Tony Lindgren wrote:
> > + /* Allow aggressive PM for USB, it's only needed for n_gsm port */
> > + if (phy_pm_runtime_enabled(ddata->generic_phy))
> > + phy_pm_runtime_put(ddata->generic_phy);
>
> phy_*() API's are generally added to be used by the consumer driver. I guess in
> this case we can directly use pm_runtime_enabled(x).
OK sure that works for me too.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>
Subject: [2/2] phy: mapphone-mdm6600: Improve phy related runtime PM calls
Date: Fri, 23 Nov 2018 08:58:38 -0800 [thread overview]
Message-ID: <20181123165838.GF53235@atomide.com> (raw)
* Kishon Vijay Abraham I <kishon@ti.com> [181123 07:59]:
> On 17/11/18 7:07 PM, Tony Lindgren wrote:
> > + /* Allow aggressive PM for USB, it's only needed for n_gsm port */
> > + if (phy_pm_runtime_enabled(ddata->generic_phy))
> > + phy_pm_runtime_put(ddata->generic_phy);
>
> phy_*() API's are generally added to be used by the consumer driver. I guess in
> this case we can directly use pm_runtime_enabled(x).
OK sure that works for me too.
Regards,
Tony
next prev parent reply other threads:[~2018-11-23 16:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 13:37 [PATCH 0/2] Improve phy-mapphone pm Tony Lindgren
2018-11-17 13:37 ` [PATCH 1/2] phy: core: Add phy_pm_runtime_enabled Tony Lindgren
2018-11-17 13:37 ` [1/2] " Tony Lindgren
2018-11-17 15:38 ` [PATCH 1/2] " Johan Hovold
2018-11-17 15:38 ` [1/2] " Johan Hovold
2018-11-17 15:43 ` [PATCH 1/2] " Tony Lindgren
2018-11-17 15:43 ` [1/2] " Tony Lindgren
2019-06-02 10:14 ` [PATCH 1/2] " Pavel Machek
2019-06-02 10:25 ` Pavel Machek
2018-11-19 14:46 ` kbuild test robot
2018-11-19 14:46 ` [1/2] " kbuild test robot
2018-11-17 13:37 ` [PATCH 2/2] phy: mapphone-mdm6600: Improve phy related runtime PM calls Tony Lindgren
2018-11-17 13:37 ` [2/2] " Tony Lindgren
2018-11-23 7:59 ` [PATCH 2/2] " Kishon Vijay Abraham I
2018-11-23 7:59 ` Kishon Vijay Abraham I
2018-11-23 7:59 ` [2/2] " Kishon Vijay Abraham I
2018-11-23 16:58 ` Tony Lindgren [this message]
2018-11-23 16:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123165838.GF53235@atomide.com \
--to=tony@atomide.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.