From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Aaro Koskinen <aaro.koskinen@iki.fi>, tony@atomide.com
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
vkoul@kernel.org, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1
Date: Sat, 24 Nov 2018 20:09:42 +0000 [thread overview]
Message-ID: <20181124200942.GS6920@n2100.armlinux.org.uk> (raw)
On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote:
> > On 22/11/2018 17.12, Russell King - ARM Linux wrote:
> > > I'm also not sure about this:
> > >
> > > if (cpu_is_omap15xx())
> > > end++;
> > >
> > > in dma_dest_len() - is that missing from the omap-dma driver? It looks
> > > like a work-around for some problem on OMAP15xx, but I can't make sense
> > > about why it's in the UDC driver rather than the legacy DMA driver.
> >
> > afaik no other legacy drivers were doing similar thing, this must be
> > something which is needed for the omap_udc driver to fix up something?
>
> Here's the patch that added it: https://marc.info/?l=linux-omap&m=119634396324221&w=2
>
> "Make DMA-OUT behave on the 1510 ... the 1510 CPC register was just
> off-by-one with respect to the 1611 CDAC"
... which suggests that's a problem with the CPC register itself, and
we should fix that in the DMAengine driver rather than the USB gadget
driver.
Tony, any input on this?
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Aaro Koskinen <aaro.koskinen@iki.fi>, tony@atomide.com
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
vkoul@kernel.org, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1
Date: Sat, 24 Nov 2018 20:09:42 +0000 [thread overview]
Message-ID: <20181124200942.GS6920@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181123185215.GH12912@darkstar.musicnaut.iki.fi>
On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote:
> > On 22/11/2018 17.12, Russell King - ARM Linux wrote:
> > > I'm also not sure about this:
> > >
> > > if (cpu_is_omap15xx())
> > > end++;
> > >
> > > in dma_dest_len() - is that missing from the omap-dma driver? It looks
> > > like a work-around for some problem on OMAP15xx, but I can't make sense
> > > about why it's in the UDC driver rather than the legacy DMA driver.
> >
> > afaik no other legacy drivers were doing similar thing, this must be
> > something which is needed for the omap_udc driver to fix up something?
>
> Here's the patch that added it: https://marc.info/?l=linux-omap&m=119634396324221&w=2
>
> "Make DMA-OUT behave on the 1510 ... the 1510 CPC register was just
> off-by-one with respect to the 1611 CDAC"
... which suggests that's a problem with the CPC register itself, and
we should fix that in the DMAengine driver rather than the USB gadget
driver.
Tony, any input on this?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next reply other threads:[~2018-11-24 20:09 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 20:09 Russell King - ARM Linux [this message]
2018-11-24 20:09 ` [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1 Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2018-12-18 15:55 Tony Lindgren
2018-12-18 15:55 ` [PATCH] " Tony Lindgren
2018-12-18 10:11 Peter Ujfalusi
2018-12-18 10:11 ` [PATCH] " Peter Ujfalusi
2018-12-18 10:11 ` Peter Ujfalusi
2018-12-17 23:47 Aaro Koskinen
2018-12-17 23:47 ` [PATCH] " Aaro Koskinen
2018-12-17 19:16 Aaro Koskinen
2018-12-17 19:16 ` [PATCH] " Aaro Koskinen
2018-12-17 19:16 ` Aaro Koskinen
2018-11-25 17:14 Tony Lindgren
2018-11-25 17:14 ` [PATCH] " Tony Lindgren
2018-11-25 16:58 Aaro Koskinen
2018-11-25 16:58 ` [PATCH] " Aaro Koskinen
2018-11-25 11:57 Russell King - ARM Linux
2018-11-25 11:57 ` [PATCH] " Russell King - ARM Linux
2018-11-25 11:11 Russell King - ARM Linux
2018-11-25 11:11 ` [PATCH] " Russell King - ARM Linux
2018-11-25 1:11 Tony Lindgren
2018-11-25 1:11 ` [PATCH] " Tony Lindgren
2018-11-25 1:07 Tony Lindgren
2018-11-25 1:07 ` [PATCH] " Tony Lindgren
2018-11-24 19:29 Russell King - ARM Linux
2018-11-24 19:29 ` [PATCH] " Russell King - ARM Linux
2018-11-24 19:06 Aaro Koskinen
2018-11-24 19:06 ` [PATCH] " Aaro Koskinen
2018-11-24 17:48 Russell King - ARM Linux
2018-11-24 17:48 ` [PATCH] " Russell King - ARM Linux
2018-11-24 0:17 Aaro Koskinen
2018-11-24 0:17 ` [PATCH] " Aaro Koskinen
2018-11-23 23:27 Russell King - ARM Linux
2018-11-23 23:27 ` [PATCH] " Russell King - ARM Linux
2018-11-23 18:52 Aaro Koskinen
2018-11-23 18:52 ` [PATCH] " Aaro Koskinen
2018-11-23 16:16 Russell King - ARM Linux
2018-11-23 16:16 ` [PATCH] " Russell King - ARM Linux
2018-11-23 15:43 Russell King - ARM Linux
2018-11-23 15:43 ` [PATCH] " Russell King - ARM Linux
2018-11-23 12:35 Peter Ujfalusi
2018-11-23 12:35 ` [PATCH] " Peter Ujfalusi
2018-11-23 12:35 ` Peter Ujfalusi
2018-11-23 11:54 Peter Ujfalusi
2018-11-23 11:54 ` [PATCH] " Peter Ujfalusi
2018-11-23 11:54 ` Peter Ujfalusi
2018-11-23 11:49 Peter Ujfalusi
2018-11-23 11:49 ` [PATCH] " Peter Ujfalusi
2018-11-23 11:49 ` Peter Ujfalusi
2018-11-23 11:45 Peter Ujfalusi
2018-11-23 11:45 ` [PATCH] " Peter Ujfalusi
2018-11-23 11:45 ` Peter Ujfalusi
2018-11-23 1:23 Aaro Koskinen
2018-11-23 1:23 ` [PATCH] " Aaro Koskinen
2018-11-23 0:25 Russell King - ARM Linux
2018-11-23 0:25 ` [PATCH] " Russell King - ARM Linux
2018-11-22 22:24 Aaro Koskinen
2018-11-22 22:24 ` [PATCH] " Aaro Koskinen
2018-11-22 22:01 Aaro Koskinen
2018-11-22 22:01 ` [PATCH] " Aaro Koskinen
2018-11-22 15:12 Russell King - ARM Linux
2018-11-22 15:12 ` [PATCH] " Russell King - ARM Linux
2018-11-22 10:29 Russell King - ARM Linux
2018-11-22 10:29 ` [PATCH] " Russell King - ARM Linux
2018-11-22 8:31 Peter Ujfalusi
2018-11-22 8:31 ` [PATCH] " Peter Ujfalusi
2018-11-22 8:31 ` Peter Ujfalusi
2018-11-20 21:04 Aaro Koskinen
2018-11-20 21:04 ` [PATCH] " Aaro Koskinen
2018-11-20 7:28 Peter Ujfalusi
2018-11-20 7:28 ` [PATCH] " Peter Ujfalusi
2018-11-20 7:28 ` Peter Ujfalusi
2018-11-19 18:46 Aaro Koskinen
2018-11-19 18:46 ` [PATCH] " Aaro Koskinen
2018-11-19 10:40 Peter Ujfalusi
2018-11-19 10:40 ` [PATCH] " Peter Ujfalusi
2018-11-19 10:40 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124200942.GS6920@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=aaro.koskinen@iki.fi \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.