From: PanBian <bianpan2016@163.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: get rid of potential double free
Date: Tue, 27 Nov 2018 08:40:31 +0800 [thread overview]
Message-ID: <20181127004031.GA125510@bp> (raw)
In-Reply-To: <CAHc6FU4H4y8dDhj5crjqApJAq7ZcjS+9GkE8vUK=1myk5Et2VA@mail.gmail.com>
On Tue, Nov 27, 2018 at 12:19:48AM +0100, Andreas Gruenbacher wrote:
> Pan,
>
> On Mon, 26 Nov 2018 at 09:44, Pan Bian <bianpan2016@163.com> wrote:
>
> > __gfs2_set_acl will not increase the reference count of acl if it fails.
> > In this case, posix_acl_release are called twice, one after
> > __gfs2_set_acl and one in the error handling block. This patch does not
> > release acl when __gfs2_set_acl fails.
> >
>
> thanks for the bug report and patch; I think this should be fixed more
> clearly as in the patch I've posted earlier today.
I have seen the patch. It is really much clearer. Thank you!
Pan
>
> Andreas
WARNING: multiple messages have this Message-ID (diff)
From: PanBian <bianpan2016@163.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Bob Peterson <rpeterso@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
cluster-devel <cluster-devel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gfs2: get rid of potential double free
Date: Tue, 27 Nov 2018 08:40:31 +0800 [thread overview]
Message-ID: <20181127004031.GA125510@bp> (raw)
In-Reply-To: <CAHc6FU4H4y8dDhj5crjqApJAq7ZcjS+9GkE8vUK=1myk5Et2VA@mail.gmail.com>
On Tue, Nov 27, 2018 at 12:19:48AM +0100, Andreas Gruenbacher wrote:
> Pan,
>
> On Mon, 26 Nov 2018 at 09:44, Pan Bian <bianpan2016@163.com> wrote:
>
> > __gfs2_set_acl will not increase the reference count of acl if it fails.
> > In this case, posix_acl_release are called twice, one after
> > __gfs2_set_acl and one in the error handling block. This patch does not
> > release acl when __gfs2_set_acl fails.
> >
>
> thanks for the bug report and patch; I think this should be fixed more
> clearly as in the patch I've posted earlier today.
I have seen the patch. It is really much clearer. Thank you!
Pan
>
> Andreas
next prev parent reply other threads:[~2018-11-27 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 8:43 [Cluster-devel] [PATCH] gfs2: get rid of potential double free Pan Bian
2018-11-26 8:43 ` Pan Bian
2018-11-26 23:19 ` [Cluster-devel] " Andreas Gruenbacher
2018-11-27 0:40 ` PanBian [this message]
2018-11-27 0:40 ` PanBian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127004031.GA125510@bp \
--to=bianpan2016@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.