All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arm-compute-library: bump SRCREV and add TI benchmark test group.
@ 2018-11-21 19:01 Qin Su
  2018-11-26 22:11 ` Denys Dmytriyenko
  0 siblings, 1 reply; 4+ messages in thread
From: Qin Su @ 2018-11-21 19:01 UTC (permalink / raw)
  To: meta-arago

updated to the latest version of 18.08
updated LIC_FILES_CHKSUM as Copyright time changed in LICENSE from 2017 to 2017-2018
updated to generate versioned library
added benchmark preset group for squeezenet and inceptionnet

Signed-off-by: Qin Su <qsu@ti.com>
---
 .../0001-add-ti-benchmark-test-group.patch         | 64 +++++++++++++++++++
 .../0002-add-ti-benchmark-test-group.patch         | 74 ++++++++++++++++++++++
 .../0003-add-ti-benchmark-test-group.patch         | 42 ++++++++++++
 .../0004-add-ti-benchmark-test-group.patch         | 49 ++++++++++++++
 .../0005-add-ti-benchmark-test-group.patch         | 46 ++++++++++++++
 .../0006-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
 .../0007-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
 .../0008-add-ti-benchmark-test-group.patch         | 31 +++++++++
 .../0009-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
 .../0010-add-ti-benchmark-test-group.patch         | 50 +++++++++++++++
 .../0011-add-ti-benchmark-test-group.patch         | 37 +++++++++++
 .../arm-compute-library/arm-compute-library_git.bb | 32 ++++++----
 12 files changed, 546 insertions(+), 11 deletions(-)
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0001-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0002-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0003-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0004-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0005-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0006-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0007-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0008-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0009-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0010-add-ti-benchmark-test-group.patch
 create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0011-add-ti-benchmark-test-group.patch

diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0001-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0001-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..2dc2b2f
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0001-add-ti-benchmark-test-group.patch
@@ -0,0 +1,64 @@
+From 0bd7b0ab0d0a2302d7c161b5276ddcdda118b777 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:09:41 -0500
+Subject: [PATCH 01/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ .../squeezenet/SqueezeNetActivationLayerDataset.h  | 35 ++++++++++++++++++++++
+ 1 file changed, 35 insertions(+)
+ mode change 100644 => 100755 tests/datasets/system_tests/squeezenet/SqueezeNetActivationLayerDataset.h
+
+diff --git a/tests/datasets/system_tests/squeezenet/SqueezeNetActivationLayerDataset.h b/tests/datasets/system_tests/squeezenet/SqueezeNetActivationLayerDataset.h
+old mode 100644
+new mode 100755
+index 7f4bf4d..a66f473
+--- a/tests/datasets/system_tests/squeezenet/SqueezeNetActivationLayerDataset.h
++++ b/tests/datasets/system_tests/squeezenet/SqueezeNetActivationLayerDataset.h
+@@ -71,6 +71,41 @@ public:
+     SqueezeNetActivationLayerDataset(SqueezeNetActivationLayerDataset &&) = default;
+     ~SqueezeNetActivationLayerDataset()                                   = default;
+ };
++class TISqueezeNetActivationLayerDataset final : public
++    framework::dataset::CartesianProductDataset<framework::dataset::InitializerListDataset<TensorShape>, framework::dataset::SingletonDataset<ActivationLayerInfo>>
++{
++public:
++    TISqueezeNetActivationLayerDataset()
++        : CartesianProductDataset
++    {
++        framework::dataset::make("Shape", { // relu_conv1
++            TensorShape(114U, 114U, 64U),
++            // fire2/relu_squeeze1x1, fire3/relu_squeeze1x1
++            TensorShape(57U, 57U, 16U),
++            // fire2/relu_expand1x1, fire2/relu_expand3x3, fire3/relu_expand1x1, fire3/relu_expand3x3
++            TensorShape(57U, 57U, 64U),
++            // fire4/relu_squeeze1x1, fire5/relu_squeeze1x1
++            TensorShape(28U, 28U, 32U),
++            // fire4/relu_expand1x1, fire4/relu_expand3x3, fire5/relu_expand1x1, fire5/relu_expand3x3
++            TensorShape(28U, 28U, 128U),
++            // fire6/relu_squeeze1x1, fire7/relu_squeeze1x1
++            TensorShape(14U, 14U, 48U),
++            // fire6/relu_expand1x1, fire6/relu_expand3x3, fire7/relu_expand1x1, fire7/relu_expand3x3
++            TensorShape(14U, 14U, 192U),
++            // fire8/relu_squeeze1x1, fire9/relu_squeeze1x1
++            TensorShape(14U, 14U, 64U),
++            // fire8/relu_expand1x1, fire8/relu_expand3x3, fire9/relu_expand1x1, fire9/relu_expand3x3
++            TensorShape(14U, 14U, 256U),
++            // relu_conv10
++            TensorShape(14U, 14U, 1000U) }),
++        framework::dataset::make("Info", ActivationLayerInfo(ActivationLayerInfo::ActivationFunction::RELU))
++    }
++    {
++    }
++    TISqueezeNetActivationLayerDataset(TISqueezeNetActivationLayerDataset &&) = default;
++    ~TISqueezeNetActivationLayerDataset()                                   = default;
++};
++
+ } // namespace datasets
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0002-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0002-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..f93b47e
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0002-add-ti-benchmark-test-group.patch
@@ -0,0 +1,74 @@
+From 0c2f4518ef8d4e8616f0c2b5819af6a109721e04 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:17:42 -0500
+Subject: [PATCH 02/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ .../squeezenet/SqueezeNetConvolutionLayerDataset.h | 45 ++++++++++++++++++++++
+ 1 file changed, 45 insertions(+)
+ mode change 100644 => 100755 tests/datasets/system_tests/squeezenet/SqueezeNetConvolutionLayerDataset.h
+
+diff --git a/tests/datasets/system_tests/squeezenet/SqueezeNetConvolutionLayerDataset.h b/tests/datasets/system_tests/squeezenet/SqueezeNetConvolutionLayerDataset.h
+old mode 100644
+new mode 100755
+index f98d90a..cba37eb
+--- a/tests/datasets/system_tests/squeezenet/SqueezeNetConvolutionLayerDataset.h
++++ b/tests/datasets/system_tests/squeezenet/SqueezeNetConvolutionLayerDataset.h
+@@ -96,6 +96,51 @@ public:
+         add_config(TensorShape(13U, 13U, 512U), TensorShape(1U, 1U, 512U, 1000U), TensorShape(1000U), TensorShape(13U, 13U, 1000U), PadStrideInfo(1, 1, 0, 0));
+     }
+ };
++
++class TISqueezeNetConvolutionLayerDataset final : public ConvolutionLayerDataset
++{
++public:
++    TISqueezeNetConvolutionLayerDataset()
++    {
++        // conv1
++        add_config(TensorShape(227U, 227U, 3U), TensorShape(3U, 3U, 3U, 64U), TensorShape(64U), TensorShape(114U, 114U, 64U), PadStrideInfo(2, 2, 0, 0));
++        // fire2/squeeze1x1
++        add_config(TensorShape(57U, 57U, 64U), TensorShape(1U, 1U, 64U, 16U), TensorShape(16U), TensorShape(57U, 57U, 16U), PadStrideInfo(1, 1, 0, 0));
++        // fire2/expand1x1, fire3/expand1x1
++        add_config(TensorShape(57U, 57U, 16U), TensorShape(1U, 1U, 16U, 64U), TensorShape(64U), TensorShape(57U, 57U, 64U), PadStrideInfo(1, 1, 0, 0));
++        // fire2/expand3x3, fire3/expand3x3
++        add_config(TensorShape(57U, 57U, 16U), TensorShape(3U, 3U, 16U, 64U), TensorShape(64U), TensorShape(57U, 57U, 64U), PadStrideInfo(1, 1, 1, 1));
++        // fire3/squeeze1x1
++        add_config(TensorShape(57U, 57U, 128U), TensorShape(1U, 1U, 128U, 16U), TensorShape(16U), TensorShape(57U, 57U, 16U), PadStrideInfo(1, 1, 0, 0));
++        // fire4/squeeze1x1
++        add_config(TensorShape(28U, 28U, 128U), TensorShape(1U, 1U, 128U, 32U), TensorShape(32U), TensorShape(28U, 28U, 32U), PadStrideInfo(1, 1, 0, 0));
++        // fire4/expand1x1, fire5/expand1x1
++        add_config(TensorShape(28U, 28U, 32U), TensorShape(1U, 1U, 32U, 128U), TensorShape(128U), TensorShape(28U, 28U, 128U), PadStrideInfo(1, 1, 0, 0));
++        // fire4/expand3x3, fire5/expand3x3
++        add_config(TensorShape(28U, 28U, 32U), TensorShape(3U, 3U, 32U, 128U), TensorShape(128U), TensorShape(28U, 28U, 128U), PadStrideInfo(1, 1, 1, 1));
++        // fire5/squeeze1x1
++        add_config(TensorShape(28U, 28U, 256U), TensorShape(1U, 1U, 256U, 32U), TensorShape(32U), TensorShape(28U, 28U, 32U), PadStrideInfo(1, 1, 0, 0));
++        // fire6/squeeze1x1
++        add_config(TensorShape(14U, 14U, 256U), TensorShape(1U, 1U, 256U, 48U), TensorShape(48U), TensorShape(14U, 14U, 48U), PadStrideInfo(1, 1, 0, 0));
++        // fire6/expand1x1, fire7/expand1x1
++        add_config(TensorShape(14U, 14U, 48U), TensorShape(1U, 1U, 48U, 192U), TensorShape(192U), TensorShape(14U, 14U, 192U), PadStrideInfo(1, 1, 0, 0));
++        // fire6/expand3x3, fire7/expand3x3
++        add_config(TensorShape(14U, 14U, 48U), TensorShape(3U, 3U, 48U, 192U), TensorShape(192U), TensorShape(14U, 14U, 192U), PadStrideInfo(1, 1, 1, 1));
++        // fire7/squeeze1x1
++        add_config(TensorShape(14U, 14U, 384U), TensorShape(1U, 1U, 384U, 48U), TensorShape(48U), TensorShape(14U, 14U, 48U), PadStrideInfo(1, 1, 0, 0));
++        // fire8/squeeze1x1
++        add_config(TensorShape(14U, 14U, 384U), TensorShape(1U, 1U, 384U, 64U), TensorShape(64U), TensorShape(14U, 14U, 64U), PadStrideInfo(1, 1, 0, 0));
++        // fire8/expand1x1, fire9/expand1x1
++        add_config(TensorShape(14U, 14U, 64U), TensorShape(1U, 1U, 64U, 256U), TensorShape(256U), TensorShape(14U, 14U, 256U), PadStrideInfo(1, 1, 0, 0));
++        // fire8/expand3x3, fire9/expand3x3
++        add_config(TensorShape(14U, 14U, 64U), TensorShape(3U, 3U, 64U, 256U), TensorShape(256U), TensorShape(14U, 14U, 256U), PadStrideInfo(1, 1, 1, 1));
++        // fire9/squeeze1x1
++        add_config(TensorShape(14U, 14U, 512U), TensorShape(1U, 1U, 512U, 64U), TensorShape(64U), TensorShape(14U, 14U, 64U), PadStrideInfo(1, 1, 0, 0));
++        // conv10
++        add_config(TensorShape(14U, 14U, 512U), TensorShape(1U, 1U, 512U, 1000U), TensorShape(1000U), TensorShape(14U, 14U, 1000U), PadStrideInfo(1, 1, 0, 0));
++    }
++};
++
+ } // namespace datasets
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0003-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0003-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..b91d8dc
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0003-add-ti-benchmark-test-group.patch
@@ -0,0 +1,42 @@
+From 3b0c7724dba32bc6c79401850c07e173e03f07c2 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:18:13 -0500
+Subject: [PATCH 03/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ .../system_tests/squeezenet/SqueezeNetPoolingLayerDataset.h | 13 +++++++++++++
+ 1 file changed, 13 insertions(+)
+ mode change 100644 => 100755 tests/datasets/system_tests/squeezenet/SqueezeNetPoolingLayerDataset.h
+
+diff --git a/tests/datasets/system_tests/squeezenet/SqueezeNetPoolingLayerDataset.h b/tests/datasets/system_tests/squeezenet/SqueezeNetPoolingLayerDataset.h
+old mode 100644
+new mode 100755
+index 9518ce5..a168d29
+--- a/tests/datasets/system_tests/squeezenet/SqueezeNetPoolingLayerDataset.h
++++ b/tests/datasets/system_tests/squeezenet/SqueezeNetPoolingLayerDataset.h
+@@ -50,6 +50,19 @@ public:
+         add_config(TensorShape(27U, 27U, 256U), PoolingLayerInfo(PoolingType::MAX, 3, PadStrideInfo(2, 2, 0, 0, DimensionRoundingType::CEIL)));
+     }
+ };
++class TISqueezeNetPoolingLayerDataset final : public PoolingLayerDataset
++{
++public:
++    TISqueezeNetPoolingLayerDataset()
++    {
++        // pool1
++        add_config(TensorShape(114U, 114U, 64U), PoolingLayerInfo(PoolingType::MAX, 3, PadStrideInfo(2, 2, 0, 0, DimensionRoundingType::CEIL)));
++        // pool3
++        add_config(TensorShape(57U, 57U, 128U), PoolingLayerInfo(PoolingType::MAX, 3, PadStrideInfo(2, 2, 0, 0, DimensionRoundingType::CEIL)));
++        // pool5
++        add_config(TensorShape(28U, 28U, 256U), PoolingLayerInfo(PoolingType::MAX, 3, PadStrideInfo(2, 2, 0, 0, DimensionRoundingType::CEIL)));
++    }
++};
+ } // namespace datasets
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0004-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0004-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..8623bd3
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0004-add-ti-benchmark-test-group.patch
@@ -0,0 +1,49 @@
+From a50207dec0de5837a94600c674e0a91edf9a21e9 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:18:34 -0500
+Subject: [PATCH 04/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/ActivationLayer.cpp | 13 +++++++++++++
+ 1 file changed, 13 insertions(+)
+
+diff --git a/tests/benchmark/NEON/ActivationLayer.cpp b/tests/benchmark/NEON/ActivationLayer.cpp
+index 1c4ea21..7b47c11 100644
+--- a/tests/benchmark/NEON/ActivationLayer.cpp
++++ b/tests/benchmark/NEON/ActivationLayer.cpp
+@@ -51,9 +51,11 @@ namespace
+ #ifdef __ARM_FEATURE_FP16_VECTOR_ARITHMETIC
+ const auto data_types           = framework::dataset::make("DataType", { DataType::F16, DataType::F32 });
+ const auto data_types_mobilenet = framework::dataset::make("DataType", { DataType::F16, DataType::F32, DataType::QASYMM8 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #else  /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ const auto data_types           = framework::dataset::make("DataType", { DataType::F32 });
+ const auto data_types_mobilenet = framework::dataset::make("DataType", { DataType::F32, DataType::QASYMM8 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ } // namespace
+ 
+@@ -127,6 +129,17 @@ REGISTER_FIXTURE_DATA_TEST_CASE(YOLOV2ActivationLayer, NEActivationLayerFixture,
+                                                             framework::dataset::make("Batches", { 4, 8 })));
+ TEST_SUITE_END()
+ TEST_SUITE_END()
++TEST_SUITE(TIBENCHMARK_SQUEEZENET)
++REGISTER_FIXTURE_DATA_TEST_CASE(TISqueezeNetActivationLayer, NEActivationLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(datasets::TISqueezeNetActivationLayerDataset(), data_types_tibenchmark),
++                                                            framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
++TEST_SUITE(TIBENCHMARK_INCEPTIONNET)
++REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1ActivationLayer, NEActivationLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(datasets::GoogLeNetInceptionV1ActivationLayerDataset(), data_types_tibenchmark),
++                                                            framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
++
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0005-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0005-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..5dc41e9
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0005-add-ti-benchmark-test-group.patch
@@ -0,0 +1,46 @@
+From da4fe9903f8dcd714e0175d43602dcfc33673646 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:19:38 -0500
+Subject: [PATCH 05/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/ConvolutionLayer.cpp | 11 ++++++++++-
+ 1 file changed, 10 insertions(+), 1 deletion(-)
+
+diff --git a/tests/benchmark/NEON/ConvolutionLayer.cpp b/tests/benchmark/NEON/ConvolutionLayer.cpp
+index ac27e7a..6cfb00d 100644
+--- a/tests/benchmark/NEON/ConvolutionLayer.cpp
++++ b/tests/benchmark/NEON/ConvolutionLayer.cpp
+@@ -52,9 +52,10 @@ namespace
+ {
+ #ifdef __ARM_FEATURE_FP16_VECTOR_ARITHMETIC
+ const auto data_types = framework::dataset::make("DataType", { DataType::F16, DataType::F32, DataType::QASYMM8 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #else /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ const auto data_types = framework::dataset::make("DataType", { DataType::F32, DataType::QASYMM8 });
+-
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ } // namespace
+ 
+@@ -197,6 +198,14 @@ REGISTER_FIXTURE_DATA_TEST_CASE(SqueezeNetWinogradLayer, NEWinogradConvolutionLa
+ 
+ TEST_SUITE_END()
+ TEST_SUITE_END()
++
++TEST_SUITE(TIBENCHMARK_INCEPTIONNET)
++REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1ConvolutionLayer, NEGEMMConvolutionLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(framework::dataset::combine(datasets::GoogLeNetInceptionV1ConvolutionLayerDataset(),
++                                                                                                                    framework::dataset::make("ActivationInfo", ActivationLayerInfo(ActivationLayerInfo::ActivationFunction::RELU))),
++                                                                                        data_types_tibenchmark),
++                                                            framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0006-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0006-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..2fc8c94
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0006-add-ti-benchmark-test-group.patch
@@ -0,0 +1,44 @@
+From 2cf34c3a9377c1970374237a8145e9e049d62e3e Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:21:06 -0500
+Subject: [PATCH 06/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/DirectConvolutionLayer.cpp | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/tests/benchmark/NEON/DirectConvolutionLayer.cpp b/tests/benchmark/NEON/DirectConvolutionLayer.cpp
+index f94ef6b..afdcbad 100644
+--- a/tests/benchmark/NEON/DirectConvolutionLayer.cpp
++++ b/tests/benchmark/NEON/DirectConvolutionLayer.cpp
+@@ -50,8 +50,10 @@ namespace
+ // Special data types for networks that need 5x5 direct convolution
+ #ifdef ARM_COMPUTE_ENABLE_F16
+ const auto data_types = framework::dataset::make("DataType", { DataType::F16, DataType::F32 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #else  /* ARM_COMPUTE_ENABLE_F16 */
+ const auto data_types = framework::dataset::make("DataType", { DataType::F32 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #endif /* ARM_COMPUTE_ENABLE_F16 */
+ } // namespace
+ 
+@@ -122,6 +124,13 @@ REGISTER_FIXTURE_DATA_TEST_CASE(YOLOV2DirectConvolutionLayer, NEDirectConvolutio
+ 
+ TEST_SUITE_END()
+ TEST_SUITE_END()
++TEST_SUITE(TIBENCHMARK_SQUEEZENET)
++REGISTER_FIXTURE_DATA_TEST_CASE(TISqueezeNetDirectConvolutionLayer, NEDirectConvolutionLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(framework::dataset::combine(datasets::TISqueezeNetConvolutionLayerDataset(),
++                                                                                                                    framework::dataset::make("ActivationInfo", ActivationLayerInfo(ActivationLayerInfo::ActivationFunction::RELU))),
++                                                                                        data_types_tibenchmark),
++                                                            framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0007-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0007-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..d50a37a
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0007-add-ti-benchmark-test-group.patch
@@ -0,0 +1,44 @@
+From adf0a75f2af56a6bcc1eccc78dfd6d12b57e45a1 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:22:09 -0500
+Subject: [PATCH 07/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/FullyConnectedLayer.cpp | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/tests/benchmark/NEON/FullyConnectedLayer.cpp b/tests/benchmark/NEON/FullyConnectedLayer.cpp
+index d0fb04f..9ee852d 100644
+--- a/tests/benchmark/NEON/FullyConnectedLayer.cpp
++++ b/tests/benchmark/NEON/FullyConnectedLayer.cpp
+@@ -47,8 +47,10 @@ namespace
+ {
+ #ifdef __ARM_FEATURE_FP16_VECTOR_ARITHMETIC
+ const auto data_types = framework::dataset::make("DataType", { DataType::F16, DataType::F32 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #else  /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ const auto data_types = framework::dataset::make("DataType", { DataType::F32 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ } // namespace
+ 
+@@ -108,6 +110,13 @@ REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV4FullyConnectedLayer, NEFully
+                                                             framework::dataset::make("Batches", { 4, 8 })));
+ TEST_SUITE_END()
+ TEST_SUITE_END()
++TEST_SUITE(TIBENCHMARK_INCEPTIONNET)
++REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1FullyConnectedLayer, NEFullyConnectedLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(datasets::GoogLeNetInceptionV1FullyConnectedLayerDataset(),
++                                                                                        data_types_tibenchmark),
++                                                            framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
++
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0008-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0008-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..9624b32
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0008-add-ti-benchmark-test-group.patch
@@ -0,0 +1,31 @@
+From ec856d0e8532fa5df739971d6211d0f8145c8336 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:22:42 -0500
+Subject: [PATCH 08/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/GEMMLowp.cpp | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/tests/benchmark/NEON/GEMMLowp.cpp b/tests/benchmark/NEON/GEMMLowp.cpp
+index 4b13f31..c2c6bdf 100644
+--- a/tests/benchmark/NEON/GEMMLowp.cpp
++++ b/tests/benchmark/NEON/GEMMLowp.cpp
+@@ -50,6 +50,11 @@ REGISTER_FIXTURE_DATA_TEST_CASE(MatrixMultiplyGEMMLowp, NEGEMMLowpFixture, frame
+ REGISTER_FIXTURE_DATA_TEST_CASE(GoogleNetGEMMLowp, NEGEMMLowpFixture, framework::DatasetMode::NIGHTLY, datasets::GoogleNetGEMMDataset());
+ 
+ TEST_SUITE_END()
++
++TEST_SUITE(TIBENCHMARK_INCEPTIONNET)
++REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1GEMMLowp, NEGEMMLowpFixture, framework::DatasetMode::ALL, datasets::GoogLeNetInceptionV1GEMMDataset());
++TEST_SUITE_END()
++
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0009-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0009-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..50ae579
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0009-add-ti-benchmark-test-group.patch
@@ -0,0 +1,44 @@
+From f884fbb85124ed2c34378e4ac960e2885d80c8dc Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:23:22 -0500
+Subject: [PATCH 09/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/NormalizationLayer.cpp | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/tests/benchmark/NEON/NormalizationLayer.cpp b/tests/benchmark/NEON/NormalizationLayer.cpp
+index 0c9a864..3654ef5 100644
+--- a/tests/benchmark/NEON/NormalizationLayer.cpp
++++ b/tests/benchmark/NEON/NormalizationLayer.cpp
+@@ -44,8 +44,10 @@ namespace
+ {
+ #ifdef __ARM_FEATURE_FP16_VECTOR_ARITHMETIC
+ const auto data_types = framework::dataset::make("DataType", { DataType::F16, DataType::F32 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #else  /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ const auto data_types = framework::dataset::make("DataType", { DataType::F32 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ } // namespace
+ using NENormalizationLayerFixture = NormalizationLayerFixture<Tensor, NENormalizationLayer, Accessor>;
+@@ -74,6 +76,13 @@ REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1NormalizationLayer, NENormal
+                                                             framework::dataset::make("Batches", { 4, 8 })));
+ TEST_SUITE_END()
+ TEST_SUITE_END()
++TEST_SUITE(TIBENCHMARK_INCEPTIONNET)
++REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1NormalizationLayer, NENormalizationLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(datasets::GoogLeNetInceptionV1NormalizationLayerDataset(),
++                                                                                        data_types_tibenchmark),
++                                                            framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
++
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0010-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0010-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..5abc69b
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0010-add-ti-benchmark-test-group.patch
@@ -0,0 +1,50 @@
+From 2e4a48024cb8d2f29f540dac529182d1d19abe46 Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:23:43 -0500
+Subject: [PATCH 10/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/benchmark/NEON/PoolingLayer.cpp | 13 +++++++++++++
+ 1 file changed, 13 insertions(+)
+
+diff --git a/tests/benchmark/NEON/PoolingLayer.cpp b/tests/benchmark/NEON/PoolingLayer.cpp
+index 8b7ee84..de93006 100644
+--- a/tests/benchmark/NEON/PoolingLayer.cpp
++++ b/tests/benchmark/NEON/PoolingLayer.cpp
+@@ -48,10 +48,13 @@ namespace benchmark
+ namespace
+ {
+ const auto data_layouts = framework::dataset::make("DataLayout", { DataLayout::NCHW, DataLayout::NHWC });
++const auto data_layouts_tibenchmark = framework::dataset::make("DataLayout", { DataLayout::NCHW});
+ #ifdef __ARM_FEATURE_FP16_VECTOR_ARITHMETIC
+ const auto data_types = framework::dataset::make("DataType", { DataType::F16, DataType::F32, DataType::QASYMM8 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #else  /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ const auto data_types = framework::dataset::make("DataType", { DataType::F32, DataType::QASYMM8 });
++const auto data_types_tibenchmark = framework::dataset::make("DataType", { DataType::F32 });
+ #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
+ } // namespace
+ 
+@@ -107,6 +110,16 @@ REGISTER_FIXTURE_DATA_TEST_CASE(YOLOV2PoolingLayer, NEPoolingLayerFixture, frame
+                                 framework::dataset::combine(framework::dataset::combine(framework::dataset::combine(datasets::YOLOV2PoolingLayerDataset(), data_types), data_layouts), framework::dataset::make("Batches", { 4, 8 })));
+ TEST_SUITE_END()
+ TEST_SUITE_END()
++
++TEST_SUITE(TIBENCHMARK_SQUEEZENET)
++REGISTER_FIXTURE_DATA_TEST_CASE(TISqueezeNetPoolingLayer, NEPoolingLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(framework::dataset::combine(datasets::TISqueezeNetPoolingLayerDataset(), data_types_tibenchmark), data_layouts_tibenchmark), framework::dataset::make("Batches", 1)));
++TEST_SUITE_END()
++TEST_SUITE(TIBENCHMARK_INCEPTIONNET)
++REGISTER_FIXTURE_DATA_TEST_CASE(GoogLeNetInceptionV1PoolingLayer, NEPoolingLayerFixture, framework::DatasetMode::ALL,
++                                framework::dataset::combine(framework::dataset::combine(framework::dataset::combine(datasets::GoogLeNetInceptionV1PoolingLayerDataset(), data_types_tibenchmark), data_layouts_tibenchmark), framework::dataset::make("Batches",
++                                                            1)));
++TEST_SUITE_END()
+ } // namespace benchmark
+ } // namespace test
+ } // namespace arm_compute
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0011-add-ti-benchmark-test-group.patch b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0011-add-ti-benchmark-test-group.patch
new file mode 100755
index 0000000..28f793a
--- /dev/null
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0011-add-ti-benchmark-test-group.patch
@@ -0,0 +1,37 @@
+From e043c5208ddf837a69e912fd247f8cf8cc618bdd Mon Sep 17 00:00:00 2001
+From: Qin Su <qsu@ti.com>
+Date: Wed, 21 Nov 2018 13:24:07 -0500
+Subject: [PATCH 11/11] add TI benchmark test group
+
+Upstream-Status: Inappropriate [TI only test code]
+
+Signed-off-by: Qin Su <qsu@ti.com>
+---
+ tests/framework/printers/PrettyPrinter.cpp | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tests/framework/printers/PrettyPrinter.cpp b/tests/framework/printers/PrettyPrinter.cpp
+index 3181951..2222286 100644
+--- a/tests/framework/printers/PrettyPrinter.cpp
++++ b/tests/framework/printers/PrettyPrinter.cpp
+@@ -83,7 +83,7 @@ void PrettyPrinter::print_run_footer()
+ 
+ void PrettyPrinter::print_test_header(const TestInfo &info)
+ {
+-    *_stream << begin_color("2") << "Running [" << info.id << "] '" << info.name << "'" << end_color() << "\n";
++    *_stream << begin_color("2") << "Running [" << info.id << "] '" << info.name << "'" << end_color() << "	";
+ }
+ 
+ void PrettyPrinter::print_test_footer()
+@@ -125,7 +125,7 @@ void PrettyPrinter::print_measurements(const Profiler::MeasurementsMap &measurem
+         InstrumentsStats stats(instrument.second);
+ 
+         *_stream << "    ";
+-        *_stream << "AVG=" << stats.mean() << " " << stats.max().unit();
++        *_stream << "AVG=	" << stats.mean() << "	" << stats.max().unit();
+         if(instrument.second.size() > 1)
+         {
+             *_stream << ", STDDEV=" << arithmetic_to_string(stats.relative_standard_deviation(), 2) << " %";
+-- 
+1.9.1
+
diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
index 8a65ade..3c6fae5 100644
--- a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
@@ -1,18 +1,30 @@
 SUMMARY = "The ARM Computer Vision and Machine Learning library"
 DESCRIPTION = "The ARM Computer Vision and Machine Learning library is a set of functions optimised for both ARM CPUs and GPUs."
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=e2c93841b20cd522af621cabaea3aef8"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=762a7ba8d2ddc3b38d88742fbaf0b62d"
 
-COMPATIBLE_MACHINE = "armv7a"
+COMPATIBLE_MACHINE = "armv7a|aarch64"
 
 SRC_URI = " \
     git://github.com/ARM-software/ComputeLibrary.git;branch=${BRANCH} \
+    file://0001-add-ti-benchmark-test-group.patch \
+    file://0002-add-ti-benchmark-test-group.patch \
+    file://0003-add-ti-benchmark-test-group.patch \
+    file://0004-add-ti-benchmark-test-group.patch \
+    file://0005-add-ti-benchmark-test-group.patch \
+    file://0006-add-ti-benchmark-test-group.patch \
+    file://0007-add-ti-benchmark-test-group.patch \
+    file://0008-add-ti-benchmark-test-group.patch \
+    file://0009-add-ti-benchmark-test-group.patch \
+    file://0010-add-ti-benchmark-test-group.patch \
+    file://0011-add-ti-benchmark-test-group.patch \
 "
 
-PV  = "18.05"
+PV  = "18.08"
+PV_MAJOR = "${@d.getVar('PV',d,1).split('.')[0]}"
 
 BRANCH = "master"
-SRCREV = "e2542c9f35ca427286822cd0c9296f49914f78b0"
+SRCREV = "52ba29e936b8e711e8acdfe819e36f884d4f3fe1"
 
 S = "${WORKDIR}/git"
 
@@ -22,7 +34,8 @@ do_compile_prepend() {
 
 inherit scons
 
-EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0"
+EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0 set_soname=1"
+EXTRA_OESCONS_aarch64 = "arch=arm64-v8a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0 set_soname=1"
 
 LIBS += "-larmpl_lp64_mp"
 
@@ -30,7 +43,7 @@ do_install() {
     CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
 
     install -m 0755 -d ${D}${libdir}
-    for lib in ${S}/build/*.so
+    for lib in ${S}/build/*.so*
     do
         install -m 0755 $lib ${D}${libdir}
     done
@@ -43,16 +56,13 @@ do_install() {
     # Install built source package as expected by ARMNN
     install -d ${D}${datadir}/${BPN}
     cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
+    # Remove unneeded symlink .so
+    rm -f ${D}${datadir}/${BPN}/build/*.so
 }
 
-SOLIBS = ".so"
-FILES_SOLIBSDEV = ""
 INSANE_SKIP_${PN} = "ldflags"
 INSANE_SKIP_${PN}-dev = "dev-elf ldflags"
 
-PACKAGES =+ "${PN}-source"
-FILES_${PN} += "${bindir}/*"
-FILES_${PN} += "${libdir}/*.so"
 FILES_${PN}-source = "${datadir}/${BPN}"
 INSANE_SKIP_${PN}-source = "ldflags libdir staticdev"
 INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm-compute-library: bump SRCREV and add TI benchmark test group.
  2018-11-21 19:01 [PATCH v2] arm-compute-library: bump SRCREV and add TI benchmark test group Qin Su
@ 2018-11-26 22:11 ` Denys Dmytriyenko
  2018-11-27 20:00   ` Su, Qin
  0 siblings, 1 reply; 4+ messages in thread
From: Denys Dmytriyenko @ 2018-11-26 22:11 UTC (permalink / raw)
  To: Qin Su; +Cc: meta-arago

On Wed, Nov 21, 2018 at 02:01:53PM -0500, Qin Su wrote:
> updated to the latest version of 18.08
> updated LIC_FILES_CHKSUM as Copyright time changed in LICENSE from 2017 to 2017-2018
> updated to generate versioned library
> added benchmark preset group for squeezenet and inceptionnet

Mostly looks good. 2 comments re: permissions and *.so below.


> Signed-off-by: Qin Su <qsu@ti.com>
> ---
>  .../0001-add-ti-benchmark-test-group.patch         | 64 +++++++++++++++++++
>  .../0002-add-ti-benchmark-test-group.patch         | 74 ++++++++++++++++++++++
>  .../0003-add-ti-benchmark-test-group.patch         | 42 ++++++++++++
>  .../0004-add-ti-benchmark-test-group.patch         | 49 ++++++++++++++
>  .../0005-add-ti-benchmark-test-group.patch         | 46 ++++++++++++++
>  .../0006-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
>  .../0007-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
>  .../0008-add-ti-benchmark-test-group.patch         | 31 +++++++++
>  .../0009-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
>  .../0010-add-ti-benchmark-test-group.patch         | 50 +++++++++++++++
>  .../0011-add-ti-benchmark-test-group.patch         | 37 +++++++++++
>  .../arm-compute-library/arm-compute-library_git.bb | 32 ++++++----
>  12 files changed, 546 insertions(+), 11 deletions(-)
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0001-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0002-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0003-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0004-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0005-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0006-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0007-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0008-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0009-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0010-add-ti-benchmark-test-group.patch
>  create mode 100755 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library/0011-add-ti-benchmark-test-group.patch

Please fix file permissions.

[snip]


> diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
> index 8a65ade..3c6fae5 100644
> --- a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
> +++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
> @@ -1,18 +1,30 @@
>  SUMMARY = "The ARM Computer Vision and Machine Learning library"
>  DESCRIPTION = "The ARM Computer Vision and Machine Learning library is a set of functions optimised for both ARM CPUs and GPUs."
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=e2c93841b20cd522af621cabaea3aef8"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=762a7ba8d2ddc3b38d88742fbaf0b62d"
>  
> -COMPATIBLE_MACHINE = "armv7a"
> +COMPATIBLE_MACHINE = "armv7a|aarch64"
>  
>  SRC_URI = " \
>      git://github.com/ARM-software/ComputeLibrary.git;branch=${BRANCH} \
> +    file://0001-add-ti-benchmark-test-group.patch \
> +    file://0002-add-ti-benchmark-test-group.patch \
> +    file://0003-add-ti-benchmark-test-group.patch \
> +    file://0004-add-ti-benchmark-test-group.patch \
> +    file://0005-add-ti-benchmark-test-group.patch \
> +    file://0006-add-ti-benchmark-test-group.patch \
> +    file://0007-add-ti-benchmark-test-group.patch \
> +    file://0008-add-ti-benchmark-test-group.patch \
> +    file://0009-add-ti-benchmark-test-group.patch \
> +    file://0010-add-ti-benchmark-test-group.patch \
> +    file://0011-add-ti-benchmark-test-group.patch \
>  "
>  
> -PV  = "18.05"
> +PV  = "18.08"
> +PV_MAJOR = "${@d.getVar('PV',d,1).split('.')[0]}"
>  
>  BRANCH = "master"
> -SRCREV = "e2542c9f35ca427286822cd0c9296f49914f78b0"
> +SRCREV = "52ba29e936b8e711e8acdfe819e36f884d4f3fe1"
>  
>  S = "${WORKDIR}/git"
>  
> @@ -22,7 +34,8 @@ do_compile_prepend() {
>  
>  inherit scons
>  
> -EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0"
> +EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0 set_soname=1"
> +EXTRA_OESCONS_aarch64 = "arch=arm64-v8a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0 set_soname=1"
>  
>  LIBS += "-larmpl_lp64_mp"
>  
> @@ -30,7 +43,7 @@ do_install() {
>      CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
>  
>      install -m 0755 -d ${D}${libdir}
> -    for lib in ${S}/build/*.so
> +    for lib in ${S}/build/*.so*
>      do
>          install -m 0755 $lib ${D}${libdir}
>      done
> @@ -43,16 +56,13 @@ do_install() {
>      # Install built source package as expected by ARMNN
>      install -d ${D}${datadir}/${BPN}
>      cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
> +    # Remove unneeded symlink .so
> +    rm -f ${D}${datadir}/${BPN}/build/*.so

Why? They are useful for development and would automatically get packaged into 
${PN}-dev package...


>  }
>  
> -SOLIBS = ".so"
> -FILES_SOLIBSDEV = ""
>  INSANE_SKIP_${PN} = "ldflags"
>  INSANE_SKIP_${PN}-dev = "dev-elf ldflags"
>  
> -PACKAGES =+ "${PN}-source"
> -FILES_${PN} += "${bindir}/*"
> -FILES_${PN} += "${libdir}/*.so"
>  FILES_${PN}-source = "${datadir}/${BPN}"
>  INSANE_SKIP_${PN}-source = "ldflags libdir staticdev"
>  INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm-compute-library: bump SRCREV and add TI benchmark test group.
  2018-11-26 22:11 ` Denys Dmytriyenko
@ 2018-11-27 20:00   ` Su, Qin
  2018-11-27 20:04     ` Denys Dmytriyenko
  0 siblings, 1 reply; 4+ messages in thread
From: Su, Qin @ 2018-11-27 20:00 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org



>-----Original Message-----
>From: Dmytriyenko, Denys
>Sent: Monday, November 26, 2018 5:12 PM
>To: Su, Qin
>Cc: meta-arago@arago-project.org
>Subject: Re: [meta-arago] [PATCH v2] arm-compute-library: bump SRCREV and
>add TI benchmark test group.
>
>On Wed, Nov 21, 2018 at 02:01:53PM -0500, Qin Su wrote:
>> updated to the latest version of 18.08 updated LIC_FILES_CHKSUM as
>> Copyright time changed in LICENSE from 2017 to 2017-2018 updated to
>> generate versioned library added benchmark preset group for squeezenet
>> and inceptionnet
>
>Mostly looks good. 2 comments re: permissions and *.so below.
>
>
>> Signed-off-by: Qin Su <qsu@ti.com>
>> ---
>>  .../0001-add-ti-benchmark-test-group.patch         | 64 +++++++++++++++++++
>>  .../0002-add-ti-benchmark-test-group.patch         | 74
>++++++++++++++++++++++
>>  .../0003-add-ti-benchmark-test-group.patch         | 42 ++++++++++++
>>  .../0004-add-ti-benchmark-test-group.patch         | 49 ++++++++++++++
>>  .../0005-add-ti-benchmark-test-group.patch         | 46 ++++++++++++++
>>  .../0006-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
>>  .../0007-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
>>  .../0008-add-ti-benchmark-test-group.patch         | 31 +++++++++
>>  .../0009-add-ti-benchmark-test-group.patch         | 44 +++++++++++++
>>  .../0010-add-ti-benchmark-test-group.patch         | 50 +++++++++++++++
>>  .../0011-add-ti-benchmark-test-group.patch         | 37 +++++++++++
>>  .../arm-compute-library/arm-compute-library_git.bb | 32 ++++++----
>>  12 files changed, 546 insertions(+), 11 deletions(-)  create mode
>> 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0001-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0002-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0003-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0004-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0005-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0006-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0007-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0008-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0009-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0010-add-ti-benchmark-test-group.patch
>>  create mode 100755
>> meta-arago-extras/recipes-support/arm-compute-library/arm-compute-libr
>> ary/0011-add-ti-benchmark-test-group.patch
>
>Please fix file permissions.
>
Sorry, will fix this in patch v3.

>[snip]
>
>
>> diff --git
>> a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-li
>> brary_git.bb
>> b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-li
>> brary_git.bb
>> index 8a65ade..3c6fae5 100644
>> ---
>> a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-li
>> brary_git.bb
>> +++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-comput
>> +++ e-library_git.bb
>> @@ -1,18 +1,30 @@
>>  SUMMARY = "The ARM Computer Vision and Machine Learning library"
>>  DESCRIPTION = "The ARM Computer Vision and Machine Learning library is a
>set of functions optimised for both ARM CPUs and GPUs."
>>  LICENSE = "MIT"
>> -LIC_FILES_CHKSUM =
>"file://LICENSE;md5=e2c93841b20cd522af621cabaea3aef8"
>> +LIC_FILES_CHKSUM =
>"file://LICENSE;md5=762a7ba8d2ddc3b38d88742fbaf0b62d"
>>
>> -COMPATIBLE_MACHINE = "armv7a"
>> +COMPATIBLE_MACHINE = "armv7a|aarch64"
>>
>>  SRC_URI = " \
>>      git://github.com/ARM-software/ComputeLibrary.git;branch=${BRANCH}
>> \
>> +    file://0001-add-ti-benchmark-test-group.patch \
>> +    file://0002-add-ti-benchmark-test-group.patch \
>> +    file://0003-add-ti-benchmark-test-group.patch \
>> +    file://0004-add-ti-benchmark-test-group.patch \
>> +    file://0005-add-ti-benchmark-test-group.patch \
>> +    file://0006-add-ti-benchmark-test-group.patch \
>> +    file://0007-add-ti-benchmark-test-group.patch \
>> +    file://0008-add-ti-benchmark-test-group.patch \
>> +    file://0009-add-ti-benchmark-test-group.patch \
>> +    file://0010-add-ti-benchmark-test-group.patch \
>> +    file://0011-add-ti-benchmark-test-group.patch \
>>  "
>>
>> -PV  = "18.05"
>> +PV  = "18.08"
>> +PV_MAJOR = "${@d.getVar('PV',d,1).split('.')[0]}"
>>
>>  BRANCH = "master"
>> -SRCREV = "e2542c9f35ca427286822cd0c9296f49914f78b0"
>> +SRCREV = "52ba29e936b8e711e8acdfe819e36f884d4f3fe1"
>>
>>  S = "${WORKDIR}/git"
>>
>> @@ -22,7 +34,8 @@ do_compile_prepend() {
>>
>>  inherit scons
>>
>> -EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1
>validation_tests=0 neon=1 openmp=1 opencl=0"
>> +EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1
>validation_tests=0 neon=1 openmp=1 opencl=0 set_soname=1"
>> +EXTRA_OESCONS_aarch64 = "arch=arm64-v8a extra_cxx_flags="-fPIC"
>benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0
>set_soname=1"
>>
>>  LIBS += "-larmpl_lp64_mp"
>>
>> @@ -30,7 +43,7 @@ do_install() {
>>      CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
>>
>>      install -m 0755 -d ${D}${libdir}
>> -    for lib in ${S}/build/*.so
>> +    for lib in ${S}/build/*.so*
>>      do
>>          install -m 0755 $lib ${D}${libdir}
>>      done
>> @@ -43,16 +56,13 @@ do_install() {
>>      # Install built source package as expected by ARMNN
>>      install -d ${D}${datadir}/${BPN}
>>      cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
>> +    # Remove unneeded symlink .so
>> +    rm -f ${D}${datadir}/${BPN}/build/*.so
>
>Why? They are useful for development and would automatically get packaged
>into ${PN}-dev package...
>
These are the source files used by armnn. I did a clean up here with the change of 
enabling the use of shared library in armnn patch v3
 
Replaced:
    # Install built source package as expected by ARMNN
    install -d ${D}${datadir}/${BPN}
    cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
    # Remove unneeded symlink .so
    rm -f ${D}${datadir}/${BPN}/build/*.so

with:
    # Install built source package as expected by ARMNN
    install -d ${D}${datadir}/${BPN}
    cp $CP_ARGS ${S}/arm_compute ${D}${datadir}/${BPN}/.
    cp $CP_ARGS ${S}/include ${D}${datadir}/${BPN}/.
    cp $CP_ARGS ${S}/support ${D}${datadir}/${BPN}/.

>
>>  }
>>
>> -SOLIBS = ".so"
>> -FILES_SOLIBSDEV = ""
>>  INSANE_SKIP_${PN} = "ldflags"
>>  INSANE_SKIP_${PN}-dev = "dev-elf ldflags"
>>
>> -PACKAGES =+ "${PN}-source"
>> -FILES_${PN} += "${bindir}/*"
>> -FILES_${PN} += "${libdir}/*.so"
>>  FILES_${PN}-source = "${datadir}/${BPN}"
>>  INSANE_SKIP_${PN}-source = "ldflags libdir staticdev"
>>  INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
>> --
>> 1.9.1
>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm-compute-library: bump SRCREV and add TI benchmark test group.
  2018-11-27 20:00   ` Su, Qin
@ 2018-11-27 20:04     ` Denys Dmytriyenko
  0 siblings, 0 replies; 4+ messages in thread
From: Denys Dmytriyenko @ 2018-11-27 20:04 UTC (permalink / raw)
  To: Su, Qin; +Cc: meta-arago@arago-project.org

On Tue, Nov 27, 2018 at 03:00:22PM -0500, Su, Qin wrote:
> 
> 
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Monday, November 26, 2018 5:12 PM
> >To: Su, Qin
> >Cc: meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCH v2] arm-compute-library: bump SRCREV and
> >add TI benchmark test group.
> >
> >On Wed, Nov 21, 2018 at 02:01:53PM -0500, Qin Su wrote:
> >> updated to the latest version of 18.08 updated LIC_FILES_CHKSUM as
> >> Copyright time changed in LICENSE from 2017 to 2017-2018 updated to
> >> generate versioned library added benchmark preset group for squeezenet
> >> and inceptionnet
> >
> >Mostly looks good. 2 comments re: permissions and *.so below.

[snip]

> >> @@ -30,7 +43,7 @@ do_install() {
> >>      CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
> >>
> >>      install -m 0755 -d ${D}${libdir}
> >> -    for lib in ${S}/build/*.so
> >> +    for lib in ${S}/build/*.so*
> >>      do
> >>          install -m 0755 $lib ${D}${libdir}
> >>      done
> >> @@ -43,16 +56,13 @@ do_install() {
> >>      # Install built source package as expected by ARMNN
> >>      install -d ${D}${datadir}/${BPN}
> >>      cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
> >> +    # Remove unneeded symlink .so
> >> +    rm -f ${D}${datadir}/${BPN}/build/*.so
> >
> >Why? They are useful for development and would automatically get packaged
> >into ${PN}-dev package...
> >
> These are the source files used by armnn. I did a clean up here with the change of 
> enabling the use of shared library in armnn patch v3
>  
> Replaced:
>     # Install built source package as expected by ARMNN
>     install -d ${D}${datadir}/${BPN}
>     cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
>     # Remove unneeded symlink .so
>     rm -f ${D}${datadir}/${BPN}/build/*.so
> 
> with:
>     # Install built source package as expected by ARMNN
>     install -d ${D}${datadir}/${BPN}
>     cp $CP_ARGS ${S}/arm_compute ${D}${datadir}/${BPN}/.
>     cp $CP_ARGS ${S}/include ${D}${datadir}/${BPN}/.
>     cp $CP_ARGS ${S}/support ${D}${datadir}/${BPN}/.

Ah, sorry, I misread your code above - you are correct, those are sources 
installed into ${datadir}. Yes, the new code is more clear about that. Thanks!


> >> -SOLIBS = ".so"
> >> -FILES_SOLIBSDEV = ""
> >>  INSANE_SKIP_${PN} = "ldflags"
> >>  INSANE_SKIP_${PN}-dev = "dev-elf ldflags"
> >>
> >> -PACKAGES =+ "${PN}-source"
> >> -FILES_${PN} += "${bindir}/*"
> >> -FILES_${PN} += "${libdir}/*.so"
> >>  FILES_${PN}-source = "${datadir}/${BPN}"
> >>  INSANE_SKIP_${PN}-source = "ldflags libdir staticdev"
> >>  INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> >> --
> >> 1.9.1
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-27 20:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-21 19:01 [PATCH v2] arm-compute-library: bump SRCREV and add TI benchmark test group Qin Su
2018-11-26 22:11 ` Denys Dmytriyenko
2018-11-27 20:00   ` Su, Qin
2018-11-27 20:04     ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.