From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-integrity@vger.kernel.org
Cc: linux-security-module@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>, Jason Gunthorpe <jgg@ziepe.ca>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 00/17] Removed nested TPM operations
Date: Tue, 27 Nov 2018 15:41:01 -0800 [thread overview]
Message-ID: <20181127234101.GA3150@linux.intel.com> (raw)
In-Reply-To: <20181118124753.18613-1-jarkko.sakkinen@linux.intel.com>
On Sun, Nov 18, 2018 at 02:47:33PM +0200, Jarkko Sakkinen wrote:
> [was Detach TPM space code out of the tpm_transmit() flow but the scope
> expanded a bit.]
>
> Make the changes necessary to detach TPM space code and TPM activation
> code out of the tpm_transmit() flow because of both of these can cause
> nested tpm_transmit() calls. The nesteds calls make the whole flow hard
> to maintain, and thus, it is better to just fix things now before this
> turns into a bigger mess.
I will take care to address the feedback from Tomas and Jason but won't
yet try to push this into v4.21. It is a patch set, which is better to
lie in linux-next before landing to a release. Probably will push the
patches soon after my v4.21 PR to linux-next. Then they will get maximum
time of exposure.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 00/17] Removed nested TPM operations
Date: Tue, 27 Nov 2018 15:41:01 -0800 [thread overview]
Message-ID: <20181127234101.GA3150@linux.intel.com> (raw)
In-Reply-To: <20181118124753.18613-1-jarkko.sakkinen@linux.intel.com>
On Sun, Nov 18, 2018 at 02:47:33PM +0200, Jarkko Sakkinen wrote:
> [was Detach TPM space code out of the tpm_transmit() flow but the scope
> expanded a bit.]
>
> Make the changes necessary to detach TPM space code and TPM activation
> code out of the tpm_transmit() flow because of both of these can cause
> nested tpm_transmit() calls. The nesteds calls make the whole flow hard
> to maintain, and thus, it is better to just fix things now before this
> turns into a bigger mess.
I will take care to address the feedback from Tomas and Jason but won't
yet try to push this into v4.21. It is a patch set, which is better to
lie in linux-next before landing to a release. Probably will push the
patches soon after my v4.21 PR to linux-next. Then they will get maximum
time of exposure.
/Jarkko
next prev parent reply other threads:[~2018-11-27 23:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 12:47 [PATCH v9 00/17] Removed nested TPM operations Jarkko Sakkinen
2018-11-18 12:47 ` Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 01/17] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 02/17] tpm: fix invalid return value in pubek_show() Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 03/17] tpm: return 0 from pcrs_show() when tpm1_pcr_read() fails Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 04/17] tpm: print tpm2_commit_space() error inside tpm2_commit_space() Jarkko Sakkinen
2018-11-19 21:25 ` Winkler, Tomas
2018-11-20 12:49 ` Jarkko Sakkinen
2018-11-20 13:12 ` Winkler, Tomas
2018-11-18 12:47 ` [PATCH v9 05/17] tpm: declare struct tpm_header Jarkko Sakkinen
2018-11-18 12:47 ` Jarkko Sakkinen
2018-11-19 21:33 ` Winkler, Tomas
2018-11-19 21:33 ` Winkler, Tomas
2018-11-20 13:08 ` Jarkko Sakkinen
2018-11-20 13:08 ` Jarkko Sakkinen
2018-11-20 16:01 ` Jason Gunthorpe
2018-11-20 16:01 ` Jason Gunthorpe
2018-11-20 22:50 ` Jarkko Sakkinen
2018-11-20 22:50 ` Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 06/17] tpm: access command header through struct in tpm_try_transmit() Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 07/17] tpm: encapsulate tpm_dev_transmit() Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit() Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 09/17] tpm: clean up tpm_try_transmit() error handling flow Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 10/17] tpm: move tpm_validate_commmand() to tpm2-space.c Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 11/17] tpm: move TPM space code out of tpm_transmit() Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 12/17] tpm: remove @space from tpm_transmit() Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 13/17] tpm: use tpm_try_get_ops() in tpm-sysfs.c Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag Jarkko Sakkinen
2018-11-18 19:51 ` Jason Gunthorpe
2018-11-19 12:38 ` Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop() Jarkko Sakkinen
2018-11-19 14:13 ` Stefan Berger
2018-11-19 15:50 ` Jarkko Sakkinen
2018-11-18 12:47 ` [PATCH v9 16/17] tpm: take TPM chip power gating out of tpm_transmit() Jarkko Sakkinen
2018-11-18 22:52 ` Winkler, Tomas
2018-11-19 12:48 ` Jarkko Sakkinen
2018-11-19 13:17 ` Winkler, Tomas
2018-11-19 15:55 ` Jarkko Sakkinen
2018-11-19 14:15 ` Stefan Berger
2018-11-18 12:47 ` [PATCH v9 17/17] tpm: remove @flags from tpm_transmit() Jarkko Sakkinen
2018-11-19 14:23 ` [PATCH v9 00/17] Removed nested TPM operations Stefan Berger
2018-11-19 14:23 ` Stefan Berger
2018-11-19 15:56 ` Jarkko Sakkinen
2018-11-19 15:56 ` Jarkko Sakkinen
2018-11-27 23:41 ` Jarkko Sakkinen [this message]
2018-11-27 23:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127234101.GA3150@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tadeusz.struk@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.