All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: imx1: Fix memory node duplicaton
Date: Wed, 28 Nov 2018 16:53:39 +0800	[thread overview]
Message-ID: <20181128085337.GP20643@dragon> (raw)
In-Reply-To: <7a0bd2b6-a624-85f0-6b63-ae2f80907685@mentor.com>

On Mon, Nov 26, 2018 at 03:13:24PM +0200, Vladimir Zapolskiy wrote:
> Hi Fabio,
> 
> On 11/26/2018 02:40 PM, Fabio Estevam wrote:
> > Boards based on imx1 have duplicate memory nodes:
> > 
> > - One coming from the board dts file: memory@
> > 
> > - One coming from the imx1.dtsi file.
> > 
> > Fix the duplication by removing the memory node from the dtsi file
> > and by adding 'device_type = "memory";' in the board dts.
> > 
> > Reported-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> >  arch/arm/boot/dts/imx1-ads.dts     | 1 +
> >  arch/arm/boot/dts/imx1-apf9328.dts | 1 +
> >  arch/arm/boot/dts/imx1.dtsi        | 2 --
> >  3 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx1-ads.dts b/arch/arm/boot/dts/imx1-ads.dts
> > index a1d81ba..3459a58 100644
> > --- a/arch/arm/boot/dts/imx1-ads.dts
> > +++ b/arch/arm/boot/dts/imx1-ads.dts
> > @@ -21,6 +21,7 @@
> >  	};
> >  
> >  	memory at 8000000 {
> > +		 device_type = "memory";
> >  		reg = <0x08000000 0x04000000>;
> 
> there is an unwanted space symbol before 'device_type'.

I fixed it up and applied the series.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: imx1: Fix memory node duplicaton
Date: Wed, 28 Nov 2018 16:53:39 +0800	[thread overview]
Message-ID: <20181128085337.GP20643@dragon> (raw)
In-Reply-To: <7a0bd2b6-a624-85f0-6b63-ae2f80907685@mentor.com>

On Mon, Nov 26, 2018 at 03:13:24PM +0200, Vladimir Zapolskiy wrote:
> Hi Fabio,
> 
> On 11/26/2018 02:40 PM, Fabio Estevam wrote:
> > Boards based on imx1 have duplicate memory nodes:
> > 
> > - One coming from the board dts file: memory@
> > 
> > - One coming from the imx1.dtsi file.
> > 
> > Fix the duplication by removing the memory node from the dtsi file
> > and by adding 'device_type = "memory";' in the board dts.
> > 
> > Reported-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> >  arch/arm/boot/dts/imx1-ads.dts     | 1 +
> >  arch/arm/boot/dts/imx1-apf9328.dts | 1 +
> >  arch/arm/boot/dts/imx1.dtsi        | 2 --
> >  3 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx1-ads.dts b/arch/arm/boot/dts/imx1-ads.dts
> > index a1d81ba..3459a58 100644
> > --- a/arch/arm/boot/dts/imx1-ads.dts
> > +++ b/arch/arm/boot/dts/imx1-ads.dts
> > @@ -21,6 +21,7 @@
> >  	};
> >  
> >  	memory@8000000 {
> > +		 device_type = "memory";
> >  		reg = <0x08000000 0x04000000>;
> 
> there is an unwanted space symbol before 'device_type'.

I fixed it up and applied the series.

Shawn

  reply	other threads:[~2018-11-28  8:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 12:40 [PATCH 1/3] ARM: dts: imx1: Fix memory node duplicaton Fabio Estevam
2018-11-26 12:40 ` Fabio Estevam
2018-11-26 12:40 ` [PATCH 2/3] ARM: dts: imx27: " Fabio Estevam
2018-11-26 12:40   ` Fabio Estevam
2018-11-26 12:40 ` [PATCH 3/3] ARM: dts: imx25: " Fabio Estevam
2018-11-26 12:40   ` Fabio Estevam
2018-11-26 13:13 ` [PATCH 1/3] ARM: dts: imx1: " Vladimir Zapolskiy
2018-11-26 13:13   ` Vladimir Zapolskiy
2018-11-28  8:53   ` Shawn Guo [this message]
2018-11-28  8:53     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128085337.GP20643@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.