All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "Lothar Wa��mann" <LW@KARO-electronics.de>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"Aisheng DONG" <aisheng.dong@nxp.com>,
	"Andy Gross" <andy.gross@linaro.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
	"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
	"ezequiel@collabora.com" <ezequiel@collabora.com>,
	"olof@lixom.net" <olof@lixom.net>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support
Date: Wed, 28 Nov 2018 10:33:45 +0100	[thread overview]
Message-ID: <20181128093345.GC8952@piout.net> (raw)
In-Reply-To: <DB3PR0402MB39168AC8DB69B81C51CE63C2F5D10@DB3PR0402MB3916.eurprd04.prod.outlook.com>

On 28/11/2018 09:21:56+0000, Anson Huang wrote:
> > > This module is NOT depending on any board design, should it be enabled by
> > default in soc dtsi?
> > > Like wdog etc..
> > >
> > 
> > I guess the point is that you may not want it enabled, even if it should always
> > be working. enabling it by default would affect the RTC ordering for example.
> 
> i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for all i.MX
> SoCs, so do we have to disable it here and enable it in board dts?
> 

I would say that most of the i.MX based boards include another RTC
because the SoC one consumes way too much power.

Note that I don't care too much whether it is enabled by default, I
was simply explaining why you may want to disable it by default.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@bootlin.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support
Date: Wed, 28 Nov 2018 10:33:45 +0100	[thread overview]
Message-ID: <20181128093345.GC8952@piout.net> (raw)
In-Reply-To: <DB3PR0402MB39168AC8DB69B81C51CE63C2F5D10@DB3PR0402MB3916.eurprd04.prod.outlook.com>

On 28/11/2018 09:21:56+0000, Anson Huang wrote:
> > > This module is NOT depending on any board design, should it be enabled by
> > default in soc dtsi?
> > > Like wdog etc..
> > >
> > 
> > I guess the point is that you may not want it enabled, even if it should always
> > be working. enabling it by default would affect the RTC ordering for example.
> 
> i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for all i.MX
> SoCs, so do we have to disable it here and enable it in board dts?
> 

I would say that most of the i.MX based boards include another RTC
because the SoC one consumes way too much power.

Note that I don't care too much whether it is enabled by default, I
was simply explaining why you may want to disable it by default.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "Lothar Wa��mann" <LW@KARO-electronics.de>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"Aisheng DONG" <aisheng.dong@nxp.com>,
	"Andy Gross" <andy.gross@linaro.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
	"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
	"ezequiel@collabora.com" <ezequiel@collabora.com>,
	"olof@lixom.net" <olof@lixom.net>
Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support
Date: Wed, 28 Nov 2018 10:33:45 +0100	[thread overview]
Message-ID: <20181128093345.GC8952@piout.net> (raw)
In-Reply-To: <DB3PR0402MB39168AC8DB69B81C51CE63C2F5D10@DB3PR0402MB3916.eurprd04.prod.outlook.com>

On 28/11/2018 09:21:56+0000, Anson Huang wrote:
> > > This module is NOT depending on any board design, should it be enabled by
> > default in soc dtsi?
> > > Like wdog etc..
> > >
> > 
> > I guess the point is that you may not want it enabled, even if it should always
> > be working. enabling it by default would affect the RTC ordering for example.
> 
> i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for all i.MX
> SoCs, so do we have to disable it here and enable it in board dts?
> 

I would say that most of the i.MX based boards include another RTC
because the SoC one consumes way too much power.

Note that I don't care too much whether it is enabled by default, I
was simply explaining why you may want to disable it by default.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-28  9:36 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  9:41 [PATCH 0/4] Add i.MX system controller RTC driver Anson Huang
2018-11-27  9:41 ` Anson Huang
2018-11-27  9:41 ` [PATCH 1/4] rtc: add i.MX system controller RTC support Anson Huang
2018-11-27  9:41   ` Anson Huang
2018-11-27 21:35   ` Alexandre Belloni
2018-11-27 21:35     ` Alexandre Belloni
2018-11-27 21:35     ` Alexandre Belloni
2018-11-27  9:41 ` Anson Huang
2018-11-27  9:41 ` [PATCH 2/4] dt-bindings: rtc: add binding doc for i.MX system controller RTC driver Anson Huang
2018-11-27  9:41   ` Anson Huang
2018-11-27 21:26   ` Alexandre Belloni
2018-11-27 21:26     ` Alexandre Belloni
2018-11-27 21:26     ` Alexandre Belloni
2018-11-27  9:41 ` Anson Huang
2018-11-27  9:41 ` [PATCH 3/4] defconfig: arm64: add i.MX system controller RTC support Anson Huang
2018-11-27  9:41 ` Anson Huang
2018-11-27  9:41   ` Anson Huang
2018-11-27 21:36   ` Alexandre Belloni
2018-11-27 21:36     ` Alexandre Belloni
2018-11-27 21:36     ` Alexandre Belloni
2018-11-27  9:41 ` [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP " Anson Huang
2018-11-27  9:41   ` Anson Huang
2018-11-28  9:04   ` Lothar Waßmann
2018-11-28  9:04     ` Lothar Waßmann
2018-11-28  9:04     ` Lothar Waßmann
2018-11-28  9:06     ` Anson Huang
2018-11-28  9:06       ` Anson Huang
2018-11-28  9:06       ` Anson Huang
2018-11-28  9:12       ` Lothar Waßmann
2018-11-28  9:12         ` Lothar Waßmann
2018-11-28  9:12         ` Lothar Waßmann
2018-11-28  9:20         ` Anson Huang
2018-11-28  9:20           ` Anson Huang
2018-11-28  9:20           ` Anson Huang
2018-11-28  9:19       ` Alexandre Belloni
2018-11-28  9:19         ` Alexandre Belloni
2018-11-28  9:19         ` Alexandre Belloni
2018-11-28  9:21         ` Anson Huang
2018-11-28  9:21           ` Anson Huang
2018-11-28  9:21           ` Anson Huang
2018-11-28  9:33           ` Alexandre Belloni [this message]
2018-11-28  9:33             ` Alexandre Belloni
2018-11-28  9:33             ` Alexandre Belloni
2018-11-28  9:41             ` Anson Huang
2018-11-28  9:41               ` Anson Huang
2018-11-28  9:41               ` Anson Huang
2018-11-28  9:58               ` Alexandre Belloni
2018-11-28  9:58                 ` Alexandre Belloni
2018-11-28  9:58                 ` Alexandre Belloni
2018-11-28 10:03                 ` Anson Huang
2018-11-28 10:03                   ` Anson Huang
2018-11-28 10:03                   ` Anson Huang
2018-11-27  9:41 ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128093345.GC8952@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=LW@KARO-electronics.de \
    --cc=a.zummo@towertech.it \
    --cc=aisheng.dong@nxp.com \
    --cc=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=anson.huang@nxp.com \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.