From: Amir Goldstein <amir73il@gmail.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it, Jan Stancek <jstancek@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org
Subject: [PATCH v4 0/6] Tests for readahead() and fadvise() on overlayfs
Date: Wed, 28 Nov 2018 18:46:39 +0200 [thread overview]
Message-ID: <20181128164645.783-1-amir73il@gmail.com> (raw)
Cyril,
The following series adds test covergae for readahead() syscall
over overlayfs file and adds test coverage for a specific
posix_fadvise() syscall advice (POSIX_FADV_WILLNEED).
So far, the posix_fadvise syscall tests in LTP only test for error
conditions, but not functionality.
The functionality of the advice POSIX_FADV_WILLNEED is identical
to readahead() and since kernel commit 3d8f7615319b ("vfs: implement
readahead(2) using POSIX_FADV_WILLNEED"), the implementations are
also bound together.
To add test coverage of the advice POSIX_FADV_WILLNEED, I decided not
to duplicate the readahead() functional test and add test cases to
readahead02 that use the POSIX_FADV_WILLNEED implementation.
Thanks,
Amir.
Changed since v3:
- Get rid of check_ret() helper
- Use tst_timer helpers instead of gettimeofday
Changes since v2:
- Runtime check for readahead/fadvise support
- Abort test case immediately if syscall fail
Changes since v1:
- Fix bugs in loop invocation of test (i.e. -i 2)
- Address review comments from Jan Stancek
- Make cached_max a global maximum over all test cases
- Improve reliability of overlayfs readahead test case failure
Amir Goldstein (6):
syscalls/readahead02: Convert to newlib and cleanup
syscalls/readahead02: abort test if readahead syscall fails
syscalls/readahead02: fail test if readahead did not use any cache
syscalls/readahead02: Convert to tst_timer helpers
syscalls/readahead02: test readahead() on an overlayfs file
syscalls/readahead02: test readahead using posix_fadvise()
.../kernel/syscalls/readahead/readahead02.c | 355 ++++++++----------
1 file changed, 164 insertions(+), 191 deletions(-)
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Amir Goldstein <amir73il@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 0/6] Tests for readahead() and fadvise() on overlayfs
Date: Wed, 28 Nov 2018 18:46:39 +0200 [thread overview]
Message-ID: <20181128164645.783-1-amir73il@gmail.com> (raw)
Cyril,
The following series adds test covergae for readahead() syscall
over overlayfs file and adds test coverage for a specific
posix_fadvise() syscall advice (POSIX_FADV_WILLNEED).
So far, the posix_fadvise syscall tests in LTP only test for error
conditions, but not functionality.
The functionality of the advice POSIX_FADV_WILLNEED is identical
to readahead() and since kernel commit 3d8f7615319b ("vfs: implement
readahead(2) using POSIX_FADV_WILLNEED"), the implementations are
also bound together.
To add test coverage of the advice POSIX_FADV_WILLNEED, I decided not
to duplicate the readahead() functional test and add test cases to
readahead02 that use the POSIX_FADV_WILLNEED implementation.
Thanks,
Amir.
Changed since v3:
- Get rid of check_ret() helper
- Use tst_timer helpers instead of gettimeofday
Changes since v2:
- Runtime check for readahead/fadvise support
- Abort test case immediately if syscall fail
Changes since v1:
- Fix bugs in loop invocation of test (i.e. -i 2)
- Address review comments from Jan Stancek
- Make cached_max a global maximum over all test cases
- Improve reliability of overlayfs readahead test case failure
Amir Goldstein (6):
syscalls/readahead02: Convert to newlib and cleanup
syscalls/readahead02: abort test if readahead syscall fails
syscalls/readahead02: fail test if readahead did not use any cache
syscalls/readahead02: Convert to tst_timer helpers
syscalls/readahead02: test readahead() on an overlayfs file
syscalls/readahead02: test readahead using posix_fadvise()
.../kernel/syscalls/readahead/readahead02.c | 355 ++++++++----------
1 file changed, 164 insertions(+), 191 deletions(-)
--
2.17.1
next reply other threads:[~2018-11-28 16:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:46 Amir Goldstein [this message]
2018-11-28 16:46 ` [LTP] [PATCH v4 0/6] Tests for readahead() and fadvise() on overlayfs Amir Goldstein
2018-11-28 16:46 ` [PATCH v4 1/6] syscalls/readahead02: Convert to newlib and cleanup Amir Goldstein
2018-11-28 16:46 ` [LTP] " Amir Goldstein
2018-12-03 14:39 ` Cyril Hrubis
2018-12-03 14:39 ` [LTP] " Cyril Hrubis
2018-12-03 14:59 ` Amir Goldstein
2018-12-03 14:59 ` [LTP] " Amir Goldstein
2018-11-28 16:46 ` [PATCH v4 2/6] syscalls/readahead02: abort test if readahead syscall fails Amir Goldstein
2018-11-28 16:46 ` [LTP] " Amir Goldstein
2018-12-03 14:27 ` Cyril Hrubis
2018-12-03 14:27 ` [LTP] " Cyril Hrubis
2018-12-03 14:52 ` Amir Goldstein
2018-12-03 14:52 ` [LTP] " Amir Goldstein
2018-11-28 16:46 ` [PATCH v4 3/6] syscalls/readahead02: fail test if readahead did not use any cache Amir Goldstein
2018-11-28 16:46 ` [LTP] " Amir Goldstein
2018-11-28 16:46 ` [PATCH v4 4/6] syscalls/readahead02: Convert to tst_timer helpers Amir Goldstein
2018-11-28 16:46 ` [LTP] " Amir Goldstein
2018-11-28 16:46 ` [PATCH v4 5/6] syscalls/readahead02: test readahead() on an overlayfs file Amir Goldstein
2018-11-28 16:46 ` [LTP] " Amir Goldstein
2018-12-04 14:02 ` Cyril Hrubis
2018-12-04 14:02 ` [LTP] " Cyril Hrubis
2018-11-28 16:46 ` [PATCH v4 6/6] syscalls/readahead02: test readahead using posix_fadvise() Amir Goldstein
2018-11-28 16:46 ` [LTP] " Amir Goldstein
2018-12-04 14:10 ` Cyril Hrubis
2018-12-04 14:10 ` [LTP] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128164645.783-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.