From: Will Deacon <will.deacon@arm.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Julien Thierry <Julien.Thierry@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nick Desaulniers <nick.desaulniers@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: io: specify asm operand width for __iormb()
Date: Thu, 29 Nov 2018 16:37:16 +0000 [thread overview]
Message-ID: <20181129163716.GA21475@arm.com> (raw)
In-Reply-To: <20181129161738.GA9805@flashbox>
On Thu, Nov 29, 2018 at 09:17:38AM -0700, Nathan Chancellor wrote:
> On Thu, Nov 29, 2018 at 04:13:37PM +0000, Will Deacon wrote:
> > On Thu, Nov 29, 2018 at 09:10:39AM -0700, Nathan Chancellor wrote:
> > > This doesn't appear to work, I get this error:
> > >
> > > In file included from arch/arm64/kernel/asm-offsets.c:24:
> > > In file included from ./include/linux/dma-mapping.h:11:
> > > In file included from ./include/linux/scatterlist.h:9:
> > > In file included from ./arch/arm64/include/asm/io.h:209:
> > > ./include/asm-generic/io.h:695:9: error: expected expression
> > > return readb(addr);
> > > ^
> > > ./arch/arm64/include/asm/io.h:147:50: note: expanded from macro 'readb'
> > > #define readb(c) ({ u8 __v = readb_relaxed(c); __iormb(__v); __v; })
> > > ^
> > > ./arch/arm64/include/asm/io.h:120:28: note: expanded from macro '__iormb'
> > > : "=r" (tmp) : "r" (unsigned long)(v) : "memory"); \
> > > ^
> >
> > Can you try throwing another set of brackets around it, please?
> >
> > ((unsigned long)(v))
> >
> Thanks, that fixes the warning as well.
Great, I'll push this out tomorrow with your reported-by on it.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Julien Thierry <Julien.Thierry@arm.com>,
Nick Desaulniers <nick.desaulniers@gmail.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Jens Axboe <axboe@kernel.dk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: io: specify asm operand width for __iormb()
Date: Thu, 29 Nov 2018 16:37:16 +0000 [thread overview]
Message-ID: <20181129163716.GA21475@arm.com> (raw)
In-Reply-To: <20181129161738.GA9805@flashbox>
On Thu, Nov 29, 2018 at 09:17:38AM -0700, Nathan Chancellor wrote:
> On Thu, Nov 29, 2018 at 04:13:37PM +0000, Will Deacon wrote:
> > On Thu, Nov 29, 2018 at 09:10:39AM -0700, Nathan Chancellor wrote:
> > > This doesn't appear to work, I get this error:
> > >
> > > In file included from arch/arm64/kernel/asm-offsets.c:24:
> > > In file included from ./include/linux/dma-mapping.h:11:
> > > In file included from ./include/linux/scatterlist.h:9:
> > > In file included from ./arch/arm64/include/asm/io.h:209:
> > > ./include/asm-generic/io.h:695:9: error: expected expression
> > > return readb(addr);
> > > ^
> > > ./arch/arm64/include/asm/io.h:147:50: note: expanded from macro 'readb'
> > > #define readb(c) ({ u8 __v = readb_relaxed(c); __iormb(__v); __v; })
> > > ^
> > > ./arch/arm64/include/asm/io.h:120:28: note: expanded from macro '__iormb'
> > > : "=r" (tmp) : "r" (unsigned long)(v) : "memory"); \
> > > ^
> >
> > Can you try throwing another set of brackets around it, please?
> >
> > ((unsigned long)(v))
> >
> Thanks, that fixes the warning as well.
Great, I'll push this out tomorrow with your reported-by on it.
Will
next prev parent reply other threads:[~2018-11-29 16:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 4:19 [PATCH] arm64: io: specify asm operand width for __iormb() Nick Desaulniers
2018-11-29 4:19 ` Nick Desaulniers
2018-11-29 9:03 ` Julien Thierry
2018-11-29 9:03 ` Julien Thierry
2018-11-29 10:49 ` Will Deacon
2018-11-29 10:49 ` Will Deacon
2018-11-29 16:10 ` Nathan Chancellor
2018-11-29 16:10 ` Nathan Chancellor
2018-11-29 16:13 ` Will Deacon
2018-11-29 16:13 ` Will Deacon
2018-11-29 16:17 ` Nathan Chancellor
2018-11-29 16:17 ` Nathan Chancellor
2018-11-29 16:37 ` Will Deacon [this message]
2018-11-29 16:37 ` Will Deacon
2018-11-29 16:14 ` Russell King - ARM Linux
2018-11-29 16:14 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129163716.GA21475@arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Julien.Thierry@arm.com \
--cc=axboe@kernel.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=nick.desaulniers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.