All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node
Date: Thu, 29 Nov 2018 11:09:34 -0800	[thread overview]
Message-ID: <20181129190934.GX53235@atomide.com> (raw)
In-Reply-To: <1c2e5a69-f0c4-47c6-79d4-a11521b6ecda@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [181128 23:11]:
> 
> 
> On 11/28/18 4:45 AM, Tero Kristo wrote:
> > Hwmod parses the DT hierarchically from root to search for matching
> > ti,hwmod property. With the introduction of L4 data, we have two nodes
> > with the ti,hwmod = "gmac" declaration, and the hwmod core only matches
> > the first one found, which is the target-module one. This node incorrectly
> > dropped the ti,no-idle flag, which causes number of problems, like ignoring
> > errata i877, and also causing an intermittent boot failure on certain dra7
> > boards.
> > 
> > Fix the issue by moving the ti,no-idle flag to the proper node.
> > 
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > FYI: The problem is seen in linux-next.
> 
> Thank you.
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> 

Thanks for catching it, applying into omap-for-v4.21/dt-ti-sysc.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node
Date: Thu, 29 Nov 2018 11:09:34 -0800	[thread overview]
Message-ID: <20181129190934.GX53235@atomide.com> (raw)
In-Reply-To: <1c2e5a69-f0c4-47c6-79d4-a11521b6ecda@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [181128 23:11]:
> 
> 
> On 11/28/18 4:45 AM, Tero Kristo wrote:
> > Hwmod parses the DT hierarchically from root to search for matching
> > ti,hwmod property. With the introduction of L4 data, we have two nodes
> > with the ti,hwmod = "gmac" declaration, and the hwmod core only matches
> > the first one found, which is the target-module one. This node incorrectly
> > dropped the ti,no-idle flag, which causes number of problems, like ignoring
> > errata i877, and also causing an intermittent boot failure on certain dra7
> > boards.
> > 
> > Fix the issue by moving the ti,no-idle flag to the proper node.
> > 
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > FYI: The problem is seen in linux-next.
> 
> Thank you.
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> 

Thanks for catching it, applying into omap-for-v4.21/dt-ti-sysc.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-11-29 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 10:45 [PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node Tero Kristo
2018-11-28 10:45 ` Tero Kristo
2018-11-28 23:11 ` Grygorii Strashko
2018-11-28 23:11   ` Grygorii Strashko
2018-11-29 19:09   ` Tony Lindgren [this message]
2018-11-29 19:09     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129190934.GX53235@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.