From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
mazziesaccount@gmail.com, Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Huang Shijie <sjhuang@iluvatar.ai>,
Daniel Kurtz <djkurtz@chromium.org>,
Akshu Agrawal <akshu.agrawal@amd.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@
Subject: Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations
Date: Fri, 30 Nov 2018 11:06:53 +0000 [thread overview]
Message-ID: <20181130110653.GF30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181130105022.GA15388@localhost.localdomain>
On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote:
> Hello Stephen,
>
> Thanks a bunch for taking the time and reviewing this!
>
> On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote:
> > Quoting Matti Vaittinen (2018-11-13 03:55:58)
> > > With MFD devices the clk properties may be contained in MFD (parent) DT
> > > node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD
> > > subdevice not to MFD device (parent). Add
> > > devm_of_clk_add_hw_provider_parent to tackle this issue.
> > >
> > > Also clkdev registration lacks of managed registration functions and it
> > > seems few drivers do not drop clkdev lookups at exit. Add
> > > devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup
> > > releasing at exit.
> >
> > Please split this into clkdev and non-clkdev devm functionality.
> Allright. I'll split this to two patches.
Definitely, please note that clkdev is separate from the common
clk stuff, and is actually maintained by a different person (me)
although I currently defer much of the review to the common clk
guys.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
mazziesaccount@gmail.com, Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Huang Shijie <sjhuang@iluvatar.ai>,
Daniel Kurtz <djkurtz@chromium.org>,
Akshu Agrawal <akshu.agrawal@amd.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations
Date: Fri, 30 Nov 2018 11:06:53 +0000 [thread overview]
Message-ID: <20181130110653.GF30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181130105022.GA15388@localhost.localdomain>
On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote:
> Hello Stephen,
>
> Thanks a bunch for taking the time and reviewing this!
>
> On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote:
> > Quoting Matti Vaittinen (2018-11-13 03:55:58)
> > > With MFD devices the clk properties may be contained in MFD (parent) DT
> > > node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD
> > > subdevice not to MFD device (parent). Add
> > > devm_of_clk_add_hw_provider_parent to tackle this issue.
> > >
> > > Also clkdev registration lacks of managed registration functions and it
> > > seems few drivers do not drop clkdev lookups at exit. Add
> > > devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup
> > > releasing at exit.
> >
> > Please split this into clkdev and non-clkdev devm functionality.
> Allright. I'll split this to two patches.
Definitely, please note that clkdev is separate from the common
clk stuff, and is actually maintained by a different person (me)
although I currently defer much of the review to the common clk
guys.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: linux-doc@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Sebastian Reichel <sre@kernel.org>,
David Brown <david.brown@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
linux-clk@vger.kernel.org, Rob Herring <robh@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Andy Gross <andy.gross@linaro.org>,
Huang Shijie <sjhuang@iluvatar.ai>,
Guenter Roeck <linux@roeck-us.net>,
mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org,
Akshu Agrawal <akshu.agrawal@amd.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations
Date: Fri, 30 Nov 2018 11:06:53 +0000 [thread overview]
Message-ID: <20181130110653.GF30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181130105022.GA15388@localhost.localdomain>
On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote:
> Hello Stephen,
>
> Thanks a bunch for taking the time and reviewing this!
>
> On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote:
> > Quoting Matti Vaittinen (2018-11-13 03:55:58)
> > > With MFD devices the clk properties may be contained in MFD (parent) DT
> > > node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD
> > > subdevice not to MFD device (parent). Add
> > > devm_of_clk_add_hw_provider_parent to tackle this issue.
> > >
> > > Also clkdev registration lacks of managed registration functions and it
> > > seems few drivers do not drop clkdev lookups at exit. Add
> > > devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup
> > > releasing at exit.
> >
> > Please split this into clkdev and non-clkdev devm functionality.
> Allright. I'll split this to two patches.
Definitely, please note that clkdev is separate from the common
clk stuff, and is actually maintained by a different person (me)
although I currently defer much of the review to the common clk
guys.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-11-30 11:06 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 11:54 [PATCH v4 0/8] clk: clkdev: managed clk lookup and provider registrations Matti Vaittinen
2018-11-13 11:54 ` Matti Vaittinen
2018-11-13 11:54 ` Matti Vaittinen
2018-11-13 11:55 ` [PATCH v4 1/8] clk: clkdev/of_clk - add managed " Matti Vaittinen
2018-11-13 11:55 ` Matti Vaittinen
2018-11-13 11:55 ` Matti Vaittinen
2018-11-30 8:54 ` Stephen Boyd
2018-11-30 8:54 ` Stephen Boyd
2018-11-30 8:54 ` Stephen Boyd
2018-11-30 10:50 ` Matti Vaittinen
2018-11-30 10:50 ` Matti Vaittinen
2018-11-30 10:50 ` Matti Vaittinen
2018-11-30 11:06 ` Russell King - ARM Linux [this message]
2018-11-30 11:06 ` Russell King - ARM Linux
2018-11-30 11:06 ` Russell King - ARM Linux
2018-11-30 12:59 ` Matti Vaittinen
2018-11-30 12:59 ` Matti Vaittinen
2018-11-30 12:59 ` Matti Vaittinen
2018-12-03 12:16 ` Matti Vaittinen
2018-12-03 12:16 ` Matti Vaittinen
2018-12-03 12:16 ` Matti Vaittinen
2018-12-03 23:35 ` Stephen Boyd
2018-12-03 23:35 ` Stephen Boyd
2018-12-03 23:35 ` Stephen Boyd
2018-12-04 7:13 ` Matti Vaittinen
2018-12-04 7:13 ` Matti Vaittinen
2018-12-04 7:13 ` Matti Vaittinen
2018-12-04 18:21 ` Stephen Boyd
2018-12-04 18:21 ` Stephen Boyd
2018-12-04 18:21 ` Stephen Boyd
2018-12-04 18:59 ` Vaittinen, Matti
2018-12-04 18:59 ` Vaittinen, Matti
2018-12-04 18:59 ` Vaittinen, Matti
2018-11-13 11:57 ` [PATCH v4 2/8] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-11-13 11:57 ` Matti Vaittinen
2018-11-13 11:57 ` Matti Vaittinen
2018-11-13 11:59 ` [PATCH v4 3/8] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-11-13 11:59 ` Matti Vaittinen
2018-11-13 11:59 ` Matti Vaittinen
2018-11-13 12:00 ` [PATCH v4 4/8] clk: clk-hi655x: Free of_provider " Matti Vaittinen
2018-11-13 12:00 ` Matti Vaittinen
2018-11-13 12:00 ` Matti Vaittinen
2018-11-13 12:00 ` [PATCH v4 5/8] clk: rk808: use managed version of of_provider registration Matti Vaittinen
2018-11-13 12:00 ` Matti Vaittinen
2018-11-13 12:00 ` Matti Vaittinen
2018-11-13 12:01 ` [PATCH v4 6/8] clk: clk-twl6040: Free of_provider at remove Matti Vaittinen
2018-11-13 12:01 ` Matti Vaittinen
2018-11-13 12:01 ` Matti Vaittinen
2018-11-13 12:02 ` [PATCH v4 7/8] clk: apcs-msm8916: simplify probe cleanup by using devm Matti Vaittinen
2018-11-13 12:02 ` Matti Vaittinen
2018-11-13 12:02 ` Matti Vaittinen
2018-11-13 12:03 ` [PATCH v4 8/8] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock Matti Vaittinen
2018-11-13 12:03 ` Matti Vaittinen
2018-11-13 12:03 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130110653.GF30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akshu.agrawal@amd.com \
--cc=andrew.smirnov@gmail.com \
--cc=andy.gross@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=cw00.choi@samsung.com \
--cc=david.brown@linaro.org \
--cc=djkurtz@chromium.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sjhuang@iluvatar.ai \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.