* Re: [virtio-comment] content: RSC extension support for virtio-net [not found] <20181015094130.244529-1-yuri.benditovich@daynix.com> @ 2018-11-30 20:10 ` Michael S. Tsirkin 2018-11-30 20:22 ` Michael S. Tsirkin 0 siblings, 1 reply; 2+ messages in thread From: Michael S. Tsirkin @ 2018-11-30 20:10 UTC (permalink / raw) To: Yuri Benditovich; +Cc: virtio-comment On Mon, Oct 15, 2018 at 12:41:30PM +0300, Yuri Benditovich wrote: > Allocates feature bit for extended RSC (receive > side coalescing) support. If the device supports > this feature, it is able to process duplicated > ACKs and report number of coalesced TCP segments > amd number of received duplicated ACKs. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/20 > > Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com> > --- > content.tex | 39 ++++++++++++++++++++++++++++++--------- > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/content.tex b/content.tex > index be18234..17d83af 100644 > --- a/content.tex > +++ b/content.tex > @@ -2525,6 +2525,10 @@ features. > > \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control > channel. > + > +\item[VIRTIO_NET_F_RSC_EXT(38)] Device can process duplicated ACKs > + and report number of coalesced segments and duplicated ACKs > + > \end{description} > > \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements} So I went to apply this and I noticed that other devices started growing from bit 64 downward. So e.g. VIRTIO_NET_F_STANDBY is bit 62 now. Is it to late to tweak this bit to match? E.g. to use bit 61? Or was some driver with this feature already get released? -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [virtio-comment] content: RSC extension support for virtio-net 2018-11-30 20:10 ` [virtio-comment] content: RSC extension support for virtio-net Michael S. Tsirkin @ 2018-11-30 20:22 ` Michael S. Tsirkin 0 siblings, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2018-11-30 20:22 UTC (permalink / raw) To: Yuri Benditovich; +Cc: virtio-comment On Fri, Nov 30, 2018 at 03:10:02PM -0500, Michael S. Tsirkin wrote: > On Mon, Oct 15, 2018 at 12:41:30PM +0300, Yuri Benditovich wrote: > > Allocates feature bit for extended RSC (receive > > side coalescing) support. If the device supports > > this feature, it is able to process duplicated > > ACKs and report number of coalesced TCP segments > > amd number of received duplicated ACKs. > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/20 > > > > Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com> > > --- > > content.tex | 39 ++++++++++++++++++++++++++++++--------- > > 1 file changed, 30 insertions(+), 9 deletions(-) > > > > diff --git a/content.tex b/content.tex > > index be18234..17d83af 100644 > > --- a/content.tex > > +++ b/content.tex > > @@ -2525,6 +2525,10 @@ features. > > > > \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control > > channel. > > + > > +\item[VIRTIO_NET_F_RSC_EXT(38)] Device can process duplicated ACKs > > + and report number of coalesced segments and duplicated ACKs > > + > > \end{description} > > > > \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements} > > So I went to apply this and I noticed that other devices started > growing from bit 64 downward. So e.g. VIRTIO_NET_F_STANDBY is bit 62 > now. Is it to late to tweak this bit to match? E.g. to use bit 61? > Or was some driver with this feature already get released? And if you do agree please just post a patch tweaking the number to 61 and I will handle the rest. > -- > MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-30 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181015094130.244529-1-yuri.benditovich@daynix.com>
2018-11-30 20:10 ` [virtio-comment] content: RSC extension support for virtio-net Michael S. Tsirkin
2018-11-30 20:22 ` Michael S. Tsirkin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.