From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Joey Pabalinas <joeypabalinas@gmail.com>,
Joe Stringer <joe@wand.net.nz>,
daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
dsahern@gmail.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0
Date: Fri, 30 Nov 2018 15:20:27 -1000 [thread overview]
Message-ID: <20181201012027.huph7f5wbvref3di@gmail.com> (raw)
In-Reply-To: <20181201003657.kljfgwgxkf66rpdb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Fri, Nov 30, 2018 at 02:36:57PM -1000, Joey Pabalinas wrote:
> On Fri, Nov 30, 2018 at 03:32:20PM -0800, Joe Stringer wrote:
> > + * the netns associated with the *ctx*. *netns* values beyond the
> > + * range of 32-bit integers are reserved for future use.
>
> Would adding a word or two before "*netns*" here be helpful to placate
> the english pedants among us (such as myself)? Starting a sentence with
> a lowercase word, even if it's a variable name, just never really sits
> right with me.
>
> Any *netns* values ...
>
> Doesn't that kind of flow a bit better anyway?
Hah,
> Anyway, now with that unimportant nitpick if off my chest, the rest
^
|
I make an absolutely terrible pedant. ------
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-01 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 23:32 [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0 Joe Stringer
2018-11-30 23:32 ` [PATCHv3 bpf 2/2] bpf: Improve socket lookup reuseport documentation Joe Stringer
2018-12-01 0:36 ` [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0 Joey Pabalinas
2018-12-01 1:20 ` Joey Pabalinas [this message]
2018-12-01 1:35 ` Alexei Starovoitov
2018-12-01 17:18 ` Joe Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201012027.huph7f5wbvref3di@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=joe@wand.net.nz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.