All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
@ 2018-11-27 20:20 Otavio Salvador
  2018-11-29 18:40 ` Tom Rini
  0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2018-11-27 20:20 UTC (permalink / raw)
  To: u-boot

The motivation for this is to allow distributions to distribute all
possible tools in a generic way, avoiding the need of specific tools
building for each machine.

Especially on OpenEmbedded / Yocto Project ecosystem, it is very
common each BSP to end providing their specific tools when they need
to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
case).

Using this, we can package the tools doing:

$: make tools-only_defconfig
$: make tools-only

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 configs/tools-only_defconfig | 3 +++
 tools/Makefile               | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 configs/tools-only_defconfig

diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
new file mode 100644
index 0000000000..be69bdf43a
--- /dev/null
+++ b/configs/tools-only_defconfig
@@ -0,0 +1,3 @@
+CONFIG_SYS_TEXT_BASE=0
+CONFIG_FIT=y
+CONFIG_FIT_SIGNATURE=y
diff --git a/tools/Makefile b/tools/Makefile
index 3c0521f655..e916d0cebb 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs) fit_info.o
 fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
 file2include-objs := file2include.o
 
-ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
+ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
 # Add CONFIG_MXS into host CFLAGS, so we can check whether or not register
 # the mxsimage support within tools/mxsimage.c .
 HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-11-27 20:20 [U-Boot] [RFC PATCH] tools: add a generic config for native tools building Otavio Salvador
@ 2018-11-29 18:40 ` Tom Rini
  2018-11-29 21:58   ` Vagrant Cascadian
  2018-12-01 10:27   ` Peter Robinson
  0 siblings, 2 replies; 8+ messages in thread
From: Tom Rini @ 2018-11-29 18:40 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:

> The motivation for this is to allow distributions to distribute all
> possible tools in a generic way, avoiding the need of specific tools
> building for each machine.
> 
> Especially on OpenEmbedded / Yocto Project ecosystem, it is very
> common each BSP to end providing their specific tools when they need
> to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
> case).
> 
> Using this, we can package the tools doing:
> 
> $: make tools-only_defconfig
> $: make tools-only
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
>  configs/tools-only_defconfig | 3 +++
>  tools/Makefile               | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>  create mode 100644 configs/tools-only_defconfig
> 
> diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
> new file mode 100644
> index 0000000000..be69bdf43a
> --- /dev/null
> +++ b/configs/tools-only_defconfig
> @@ -0,0 +1,3 @@
> +CONFIG_SYS_TEXT_BASE=0
> +CONFIG_FIT=y
> +CONFIG_FIT_SIGNATURE=y
> diff --git a/tools/Makefile b/tools/Makefile
> index 3c0521f655..e916d0cebb 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs) fit_info.o
>  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
>  file2include-objs := file2include.o
>  
> -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
> +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
>  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not register
>  # the mxsimage support within tools/mxsimage.c .
>  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS

Adding in Peter since Fedora had this same problem crop up.  Does
something like this work for you guys?  Also adding in Vagrant Cascadian
since Debian might want to switch to this too.  Thoughts?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/591016c9/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-11-29 18:40 ` Tom Rini
@ 2018-11-29 21:58   ` Vagrant Cascadian
  2018-12-01 10:27   ` Peter Robinson
  1 sibling, 0 replies; 8+ messages in thread
From: Vagrant Cascadian @ 2018-11-29 21:58 UTC (permalink / raw)
  To: u-boot

On 2018-11-29, Tom Rini wrote:
> On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:
>> The motivation for this is to allow distributions to distribute all
>> possible tools in a generic way, avoiding the need of specific tools
>> building for each machine.
>> 
>> Especially on OpenEmbedded / Yocto Project ecosystem, it is very
>> common each BSP to end providing their specific tools when they need
>> to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
>> case).
>> 
>> Using this, we can package the tools doing:
>> 
>> $: make tools-only_defconfig
>> $: make tools-only
>> 
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> 
>>  configs/tools-only_defconfig | 3 +++
>>  tools/Makefile               | 2 +-
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>  create mode 100644 configs/tools-only_defconfig
>> 
>> diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
>> new file mode 100644
>> index 0000000000..be69bdf43a
>> --- /dev/null
>> +++ b/configs/tools-only_defconfig
>> @@ -0,0 +1,3 @@
>> +CONFIG_SYS_TEXT_BASE=0
>> +CONFIG_FIT=y
>> +CONFIG_FIT_SIGNATURE=y
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 3c0521f655..e916d0cebb 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs) fit_info.o
>>  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
>>  file2include-objs := file2include.o
>>  
>> -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
>> +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
>>  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not register
>>  # the mxsimage support within tools/mxsimage.c .
>>  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
>
> Adding in Peter since Fedora had this same problem crop up.  Does
> something like this work for you guys?  Also adding in Vagrant Cascadian
> since Debian might want to switch to this too.  Thoughts?  Thanks!

Thanks.

The u-boot packages in Debian include similar patches and workarounds
that I've been meaning to submit upstream for quite some time now... so
glad to see someone else started the process!

I'll try to follow-up and check if these patches work for Debian.


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/b7cd7b57/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-11-29 18:40 ` Tom Rini
  2018-11-29 21:58   ` Vagrant Cascadian
@ 2018-12-01 10:27   ` Peter Robinson
  2018-12-01 13:54     ` Tom Rini
  1 sibling, 1 reply; 8+ messages in thread
From: Peter Robinson @ 2018-12-01 10:27 UTC (permalink / raw)
  To: u-boot

On Thu, Nov 29, 2018 at 6:40 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:
>
> > The motivation for this is to allow distributions to distribute all
> > possible tools in a generic way, avoiding the need of specific tools
> > building for each machine.
> >
> > Especially on OpenEmbedded / Yocto Project ecosystem, it is very
> > common each BSP to end providing their specific tools when they need
> > to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
> > case).
> >
> > Using this, we can package the tools doing:
> >
> > $: make tools-only_defconfig
> > $: make tools-only
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > ---
> >
> >  configs/tools-only_defconfig | 3 +++
> >  tools/Makefile               | 2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >  create mode 100644 configs/tools-only_defconfig
> >
> > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
> > new file mode 100644
> > index 0000000000..be69bdf43a
> > --- /dev/null
> > +++ b/configs/tools-only_defconfig
> > @@ -0,0 +1,3 @@
> > +CONFIG_SYS_TEXT_BASE=0
> > +CONFIG_FIT=y
> > +CONFIG_FIT_SIGNATURE=y
> > diff --git a/tools/Makefile b/tools/Makefile
> > index 3c0521f655..e916d0cebb 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs) fit_info.o
> >  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
> >  file2include-objs := file2include.o
> >
> > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
> > +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
> >  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not register
> >  # the mxsimage support within tools/mxsimage.c .
> >  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
>
> Adding in Peter since Fedora had this same problem crop up.  Does
> something like this work for you guys?  Also adding in Vagrant Cascadian
> since Debian might want to switch to this too.  Thoughts?  Thanks!

We currently use the tools-all option, details below, to build the
tools, which broken in 2018.11 on non arm/x86 platforms due to the
sandbox dep being added in there. I'm happy to adjust as necessary to
fix that but I'm not sure the difference between tools-all vs the
above.

make CROSS_COMPILE="" defconfig V=1 O=builds/
make CROSS_COMPILE="" tools-all V=1 O=builds/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-12-01 10:27   ` Peter Robinson
@ 2018-12-01 13:54     ` Tom Rini
  2018-12-01 14:18       ` Peter Robinson
  0 siblings, 1 reply; 8+ messages in thread
From: Tom Rini @ 2018-12-01 13:54 UTC (permalink / raw)
  To: u-boot

On Sat, Dec 01, 2018 at 10:27:49AM +0000, Peter Robinson wrote:
> On Thu, Nov 29, 2018 at 6:40 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:
> >
> > > The motivation for this is to allow distributions to distribute all
> > > possible tools in a generic way, avoiding the need of specific tools
> > > building for each machine.
> > >
> > > Especially on OpenEmbedded / Yocto Project ecosystem, it is very
> > > common each BSP to end providing their specific tools when they need
> > > to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
> > > case).
> > >
> > > Using this, we can package the tools doing:
> > >
> > > $: make tools-only_defconfig
> > > $: make tools-only
> > >
> > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > ---
> > >
> > >  configs/tools-only_defconfig | 3 +++
> > >  tools/Makefile               | 2 +-
> > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > >  create mode 100644 configs/tools-only_defconfig
> > >
> > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
> > > new file mode 100644
> > > index 0000000000..be69bdf43a
> > > --- /dev/null
> > > +++ b/configs/tools-only_defconfig
> > > @@ -0,0 +1,3 @@
> > > +CONFIG_SYS_TEXT_BASE=0
> > > +CONFIG_FIT=y
> > > +CONFIG_FIT_SIGNATURE=y
> > > diff --git a/tools/Makefile b/tools/Makefile
> > > index 3c0521f655..e916d0cebb 100644
> > > --- a/tools/Makefile
> > > +++ b/tools/Makefile
> > > @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs) fit_info.o
> > >  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
> > >  file2include-objs := file2include.o
> > >
> > > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
> > > +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
> > >  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not register
> > >  # the mxsimage support within tools/mxsimage.c .
> > >  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
> >
> > Adding in Peter since Fedora had this same problem crop up.  Does
> > something like this work for you guys?  Also adding in Vagrant Cascadian
> > since Debian might want to switch to this too.  Thoughts?  Thanks!
> 
> We currently use the tools-all option, details below, to build the
> tools, which broken in 2018.11 on non arm/x86 platforms due to the
> sandbox dep being added in there. I'm happy to adjust as necessary to
> fix that but I'm not sure the difference between tools-all vs the
> above.
> 
> make CROSS_COMPILE="" defconfig V=1 O=builds/
> make CROSS_COMPILE="" tools-all V=1 O=builds/

Well, with the above you would do tools-only_defconfig then tools-all,
and we would make sure to _not_ enable options in tools-only_defconfig
that may not build on some host platforms as it's intended only for
building tools rather than the myriad of things sandbox is used for.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181201/9b4614e0/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-12-01 13:54     ` Tom Rini
@ 2018-12-01 14:18       ` Peter Robinson
  2018-12-01 14:34         ` Otavio Salvador
  0 siblings, 1 reply; 8+ messages in thread
From: Peter Robinson @ 2018-12-01 14:18 UTC (permalink / raw)
  To: u-boot

On Sat, 1 Dec 2018, 13:54 Tom Rini <trini@konsulko.com wrote:

> On Sat, Dec 01, 2018 at 10:27:49AM +0000, Peter Robinson wrote:
> > On Thu, Nov 29, 2018 at 6:40 PM Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:
> > >
> > > > The motivation for this is to allow distributions to distribute all
> > > > possible tools in a generic way, avoiding the need of specific tools
> > > > building for each machine.
> > > >
> > > > Especially on OpenEmbedded / Yocto Project ecosystem, it is very
> > > > common each BSP to end providing their specific tools when they need
> > > > to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
> > > > case).
> > > >
> > > > Using this, we can package the tools doing:
> > > >
> > > > $: make tools-only_defconfig
> > > > $: make tools-only
> > > >
> > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > > ---
> > > >
> > > >  configs/tools-only_defconfig | 3 +++
> > > >  tools/Makefile               | 2 +-
> > > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > >  create mode 100644 configs/tools-only_defconfig
> > > >
> > > > diff --git a/configs/tools-only_defconfig
> b/configs/tools-only_defconfig
> > > > new file mode 100644
> > > > index 0000000000..be69bdf43a
> > > > --- /dev/null
> > > > +++ b/configs/tools-only_defconfig
> > > > @@ -0,0 +1,3 @@
> > > > +CONFIG_SYS_TEXT_BASE=0
> > > > +CONFIG_FIT=y
> > > > +CONFIG_FIT_SIGNATURE=y
> > > > diff --git a/tools/Makefile b/tools/Makefile
> > > > index 3c0521f655..e916d0cebb 100644
> > > > --- a/tools/Makefile
> > > > +++ b/tools/Makefile
> > > > @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs)
> fit_info.o
> > > >  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
> > > >  file2include-objs := file2include.o
> > > >
> > > > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
> > > > +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
> > > >  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not
> register
> > > >  # the mxsimage support within tools/mxsimage.c .
> > > >  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
> > >
> > > Adding in Peter since Fedora had this same problem crop up.  Does
> > > something like this work for you guys?  Also adding in Vagrant
> Cascadian
> > > since Debian might want to switch to this too.  Thoughts?  Thanks!
> >
> > We currently use the tools-all option, details below, to build the
> > tools, which broken in 2018.11 on non arm/x86 platforms due to the
> > sandbox dep being added in there. I'm happy to adjust as necessary to
> > fix that but I'm not sure the difference between tools-all vs the
> > above.
> >
> > make CROSS_COMPILE="" defconfig V=1 O=builds/
> > make CROSS_COMPILE="" tools-all V=1 O=builds/
>
> Well, with the above you would do tools-only_defconfig then tools-all,
> and we would make sure to _not_ enable options in tools-only_defconfig
> that may not build on some host platforms as it's intended only for
> building tools rather than the myriad of things sandbox is used for.
>

That would be fine as far as I'm concerned.

Thanks
Peter

>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-12-01 14:18       ` Peter Robinson
@ 2018-12-01 14:34         ` Otavio Salvador
  2018-12-04  5:26           ` Peter Robinson
  0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2018-12-01 14:34 UTC (permalink / raw)
  To: u-boot

On Sat, Dec 1, 2018 at 12:18 PM Peter Robinson <pbrobinson@gmail.com> wrote:
> On Sat, 1 Dec 2018, 13:54 Tom Rini <trini@konsulko.com wrote:
> > On Sat, Dec 01, 2018 at 10:27:49AM +0000, Peter Robinson wrote:
> > > On Thu, Nov 29, 2018 at 6:40 PM Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:
> > > >
> > > > > The motivation for this is to allow distributions to distribute all
> > > > > possible tools in a generic way, avoiding the need of specific tools
> > > > > building for each machine.
> > > > >
> > > > > Especially on OpenEmbedded / Yocto Project ecosystem, it is very
> > > > > common each BSP to end providing their specific tools when they need
> > > > > to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
> > > > > case).
> > > > >
> > > > > Using this, we can package the tools doing:
> > > > >
> > > > > $: make tools-only_defconfig
> > > > > $: make tools-only
> > > > >
> > > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > > > ---
> > > > >
> > > > >  configs/tools-only_defconfig | 3 +++
> > > > >  tools/Makefile               | 2 +-
> > > > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > > >  create mode 100644 configs/tools-only_defconfig
> > > > >
> > > > > diff --git a/configs/tools-only_defconfig
> > b/configs/tools-only_defconfig
> > > > > new file mode 100644
> > > > > index 0000000000..be69bdf43a
> > > > > --- /dev/null
> > > > > +++ b/configs/tools-only_defconfig
> > > > > @@ -0,0 +1,3 @@
> > > > > +CONFIG_SYS_TEXT_BASE=0
> > > > > +CONFIG_FIT=y
> > > > > +CONFIG_FIT_SIGNATURE=y
> > > > > diff --git a/tools/Makefile b/tools/Makefile
> > > > > index 3c0521f655..e916d0cebb 100644
> > > > > --- a/tools/Makefile
> > > > > +++ b/tools/Makefile
> > > > > @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs)
> > fit_info.o
> > > > >  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
> > > > >  file2include-objs := file2include.o
> > > > >
> > > > > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
> > > > > +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
> > > > >  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not
> > register
> > > > >  # the mxsimage support within tools/mxsimage.c .
> > > > >  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
> > > >
> > > > Adding in Peter since Fedora had this same problem crop up.  Does
> > > > something like this work for you guys?  Also adding in Vagrant
> > Cascadian
> > > > since Debian might want to switch to this too.  Thoughts?  Thanks!
> > >
> > > We currently use the tools-all option, details below, to build the
> > > tools, which broken in 2018.11 on non arm/x86 platforms due to the
> > > sandbox dep being added in there. I'm happy to adjust as necessary to
> > > fix that but I'm not sure the difference between tools-all vs the
> > > above.
> > >
> > > make CROSS_COMPILE="" defconfig V=1 O=builds/
> > > make CROSS_COMPILE="" tools-all V=1 O=builds/
> >
> > Well, with the above you would do tools-only_defconfig then tools-all,
> > and we would make sure to _not_ enable options in tools-only_defconfig
> > that may not build on some host platforms as it's intended only for
> > building tools rather than the myriad of things sandbox is used for.
> >
>
> That would be fine as far as I'm concerned.

If people are likely to use tools-all, we may use tools-all_defconfig
so we connect both. What do you think guys?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [RFC PATCH] tools: add a generic config for native tools building
  2018-12-01 14:34         ` Otavio Salvador
@ 2018-12-04  5:26           ` Peter Robinson
  0 siblings, 0 replies; 8+ messages in thread
From: Peter Robinson @ 2018-12-04  5:26 UTC (permalink / raw)
  To: u-boot

On Sat, Dec 1, 2018 at 2:34 PM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
>
> On Sat, Dec 1, 2018 at 12:18 PM Peter Robinson <pbrobinson@gmail.com> wrote:
> > On Sat, 1 Dec 2018, 13:54 Tom Rini <trini@konsulko.com wrote:
> > > On Sat, Dec 01, 2018 at 10:27:49AM +0000, Peter Robinson wrote:
> > > > On Thu, Nov 29, 2018 at 6:40 PM Tom Rini <trini@konsulko.com> wrote:
> > > > >
> > > > > On Tue, Nov 27, 2018 at 06:20:08PM -0200, Otavio Salvador wrote:
> > > > >
> > > > > > The motivation for this is to allow distributions to distribute all
> > > > > > possible tools in a generic way, avoiding the need of specific tools
> > > > > > building for each machine.
> > > > > >
> > > > > > Especially on OpenEmbedded / Yocto Project ecosystem, it is very
> > > > > > common each BSP to end providing their specific tools when they need
> > > > > > to generate images for some SoC (e.g MX23 / MX28 in meta-freescale
> > > > > > case).
> > > > > >
> > > > > > Using this, we can package the tools doing:
> > > > > >
> > > > > > $: make tools-only_defconfig
> > > > > > $: make tools-only
> > > > > >
> > > > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > > > > ---
> > > > > >
> > > > > >  configs/tools-only_defconfig | 3 +++
> > > > > >  tools/Makefile               | 2 +-
> > > > > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > > > >  create mode 100644 configs/tools-only_defconfig
> > > > > >
> > > > > > diff --git a/configs/tools-only_defconfig
> > > b/configs/tools-only_defconfig
> > > > > > new file mode 100644
> > > > > > index 0000000000..be69bdf43a
> > > > > > --- /dev/null
> > > > > > +++ b/configs/tools-only_defconfig
> > > > > > @@ -0,0 +1,3 @@
> > > > > > +CONFIG_SYS_TEXT_BASE=0
> > > > > > +CONFIG_FIT=y
> > > > > > +CONFIG_FIT_SIGNATURE=y
> > > > > > diff --git a/tools/Makefile b/tools/Makefile
> > > > > > index 3c0521f655..e916d0cebb 100644
> > > > > > --- a/tools/Makefile
> > > > > > +++ b/tools/Makefile
> > > > > > @@ -124,7 +124,7 @@ fit_info-objs   := $(dumpimage-mkimage-objs)
> > > fit_info.o
> > > > > >  fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
> > > > > >  file2include-objs := file2include.o
> > > > > >
> > > > > > -ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
> > > > > > +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),)
> > > > > >  # Add CONFIG_MXS into host CFLAGS, so we can check whether or not
> > > register
> > > > > >  # the mxsimage support within tools/mxsimage.c .
> > > > > >  HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS
> > > > >
> > > > > Adding in Peter since Fedora had this same problem crop up.  Does
> > > > > something like this work for you guys?  Also adding in Vagrant
> > > Cascadian
> > > > > since Debian might want to switch to this too.  Thoughts?  Thanks!
> > > >
> > > > We currently use the tools-all option, details below, to build the
> > > > tools, which broken in 2018.11 on non arm/x86 platforms due to the
> > > > sandbox dep being added in there. I'm happy to adjust as necessary to
> > > > fix that but I'm not sure the difference between tools-all vs the
> > > > above.
> > > >
> > > > make CROSS_COMPILE="" defconfig V=1 O=builds/
> > > > make CROSS_COMPILE="" tools-all V=1 O=builds/
> > >
> > > Well, with the above you would do tools-only_defconfig then tools-all,
> > > and we would make sure to _not_ enable options in tools-only_defconfig
> > > that may not build on some host platforms as it's intended only for
> > > building tools rather than the myriad of things sandbox is used for.
> > >
> >
> > That would be fine as far as I'm concerned.
>
> If people are likely to use tools-all, we may use tools-all_defconfig
> so we connect both. What do you think guys?

That seems fine to me, let me know when there's something you'd like me to test.

Peter

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-12-04  5:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-27 20:20 [U-Boot] [RFC PATCH] tools: add a generic config for native tools building Otavio Salvador
2018-11-29 18:40 ` Tom Rini
2018-11-29 21:58   ` Vagrant Cascadian
2018-12-01 10:27   ` Peter Robinson
2018-12-01 13:54     ` Tom Rini
2018-12-01 14:18       ` Peter Robinson
2018-12-01 14:34         ` Otavio Salvador
2018-12-04  5:26           ` Peter Robinson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.