From: Jason Gunthorpe <jgg@ziepe.ca>
To: Doug Ledford <dledford@redhat.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, Leon Romanovsky <leonro@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>,
Mark Bloch <markb@mellanox.com>,
Ariel Levkovich <lariel@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings
Date: Mon, 3 Dec 2018 13:47:05 -0700 [thread overview]
Message-ID: <20181203204705.GE12237@ziepe.ca> (raw)
In-Reply-To: <51cb9d8e7b107d37447b9e0d218bb12d8cf49ebb.camel@redhat.com>
On Mon, Dec 03, 2018 at 12:23:35PM -0500, Doug Ledford wrote:
> On Thu, 2018-11-29 at 16:37 -0700, Jason Gunthorpe wrote:
> > On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote:
> > > From: kbuild test robot <fengguang.wu@intel.com>
> > >
> > > drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> > >
> > >
> > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> > >
> > > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> > >
> > > Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
> > > Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> >
> > applied to for-next, thanks
> >
> > Jason
>
> This caused a conflict with your make write() handlers use a consistent
> flow series, which I fixed up during git am run. Just FYI in case you
> want to check out the conflict spot as a double check (but it was a
> simple fixup).
Looks OK to me thanks
Jason
prev parent reply other threads:[~2018-12-03 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201811280723.DnTk8AXL%fengguang.wu@intel.com>
2018-11-27 23:21 ` [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings kbuild test robot
2018-11-29 23:37 ` Jason Gunthorpe
2018-12-03 17:23 ` Doug Ledford
2018-12-03 20:47 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203204705.GE12237@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=lariel@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.